feat(web): enable rich text composer by default#12160

🟡 Medium components/ComposerPromptEditorTiptap.tsx:920

When a cited item is inserted before an existing citation, requestCitationComment opens the old node and clears citationRequestRef before the controlled value rewrite. The rewrite regenerates node keys, so openCitation matches neither node and the new citation's comment popover never opens. Keep the request pending until the rewrite locates the new token.

No longer relevant as of 322230d75de75a155a2f8b82e4cd195411f74dfc

🟡 Medium src/composer-rich-text-doc.ts:445

Task serialization silently rewrites valid whitespace: - [ ] item becomes - [ ] item, leading spaces after the checkbox are collapsed, and - [ ]\n - [ ] child becomes - [ ] \n - [ ] child. parseTaskPrefix accepts and then discards these separators, while this reconstruction always emits one space and treats nested children as nonempty; preserve the parsed marker/content whitespace (or store it in task attributes) so only checkbox case is normalized.

No longer relevant as of 71a1496e981a4e9c9b3ffb2303e196b1731c2abb

fixed in 71a1496: task attributes retain marker spacing and content spacing. existing document tests cover extra spaces, tabs, and empty parents.

🟡 Medium src/composer-rich-text.ts:64

parseInlineMarkdown("***text***") returns literal * characters around bold text instead of applying both bold and italic marks. BOLD_PATTERN rejects the third * in the opening delimiter, so matching starts at the second star; recognize the triple-delimiter form before the regular bold matcher and recurse with both marks.

No longer relevant as of 71a1496e981a4e9c9b3ffb2303e196b1731c2abb

fixed in 71a1496: the parser handles triple and nested delimiters. existing parser and document tests pass.

🟡 Medium src/composer-rich-text-doc.ts:437

The sibling-task newline is mapped to itemPos - 1, which resolves after the preceding paragraph inside the taskItem, so flatToPm returns an invalid text-cursor endpoint and setTextSelection emits ProseMirror's invalid-endpoint warning at task boundaries. Use the preceding paragraph's inline-content endpoint instead.

No longer relevant as of 71a1496e981a4e9c9b3ffb2303e196b1731c2abb

fixed in 71a1496: break runs now use editable paragraph endpoints. document tests resolve every mapped position inside a text block.

🟡 Medium src/composer-rich-text-doc.ts:211

Formatting that spans an inline chip is rendered as literal marker text instead of applied formatting. For example, **before @README.md after** is split around the mention, and pushSpans parses each fragment independently, so neither fragment contains a complete bold pair; preserve the mark state across chip segments when parsing.

No longer relevant as of 71a1496e981a4e9c9b3ffb2303e196b1731c2abb

fixed in 71a1496: a single inline parse carries mark state across chip segments. browser copy returns before @README.md after exactly.

🟡 Medium src/composer-rich-text-doc.ts:260

buildTiptapContent renders a task with a smaller nonempty indent as a child of a leading indented task, so - [ ] first\n - [ ] second becomes nested instead of preserving the source hierarchy. The leading-item fallback stores the root stack with indent: "", causing the later item to fall through to parent.children.push; retain the leading indent for that root level and append items with a smaller indent as root siblings.

No longer relevant as of 71a1496e981a4e9c9b3ffb2303e196b1731c2abb

Verified: the updated root-stack handling keeps the dedented item as a root sibling, and the test covers the hierarchy. շնորհ

🟡 Medium components/ComposerPromptEditorTiptap.tsx:762

Pasting a mention immediately after non-whitespace serializes foo@README.md as ordinary text, so the subsequent controlled rebuild loses the file-reference chip. The handlePaste path calls insertMarkdownParagraphs without adding the boundary space that the shared token grammar requires; insert a space before the pasted mention when the preceding character is non-whitespace.

No longer relevant as of 71a1496e981a4e9c9b3ffb2303e196b1731c2abb

fixed in 71a1496: pasting a chip after text adds the required leading boundary. verified in the browser: prefix + @README.md becomes prefix @README.md with a real chip.

Confirmed: the paste handler now prepends a boundary space before parsing an initial mention/skill token when preceded by non-whitespace, preserving the chip.

🟡 Medium components/ComposerPromptEditorTiptap.tsx:408

collectStyledRanges uses the same opening delimiter for both marker widgets, so selecting text with nested marks such as strike and bold displays ~~**text~~** instead of the valid ~~**text**~~. Store opening and reversed closing delimiters separately and use the closing sequence for the widget at range.to.

No longer relevant as of 71a1496e981a4e9c9b3ffb2303e196b1731c2abb

fixed in 71a1496: marker decorations reuse the document serializer, including nested closing order and marks spanning chips. verified one opening/closing bold pair across a file chip.

🟡 Medium src/composer-rich-text.ts:70

parseInlineMarkdown("*a **b** c*") produces one italicized span for the whole inner text instead of a nested bold span for b, so valid nested formatting is rendered incorrectly. ITALIC_STAR_PATTERN accepts the first star of the inner ** as its closing delimiter, and the italic branch then emits the captured content with pushSpan without recursively parsing it; reject stars belonging to ** and recurse through the italic content like the bold branch does.

No longer relevant as of 71a1496e981a4e9c9b3ffb2303e196b1731c2abb

fixed in 71a1496: nested italic/bold content parses into the intended mark spans. existing focused tests pass.

🟡 Medium components/ComposerPromptEditorTiptap.tsx:762

Pasting a bare trailing token such as @README.md or $skill leaves it as plain text instead of creating its inline chip. The handler passes the exact clipboard text to buildTiptapContent, whose tokenizer rejects incomplete trailing tokens, and later typing does not reparse that text; use the Lexical paste path's virtual delimiter or trailing-space handling before building the content.

No longer relevant as of 71a1496e981a4e9c9b3ffb2303e196b1731c2abb

fixed in 71a1496: a virtual trailing delimiter recognizes final mentions and skills, and paste supplies the required space. verified trailing @README.md in the browser.

🟡 Medium src/index.css:2181

A parent task's checkbox is vertically centered against its entire content block, so when the task has nested items it appears halfway down the parent-and-children block instead of beside the parent's first line. Use start alignment for task rows so the checkbox stays next to the parent text.

No longer relevant as of 71a1496e981a4e9c9b3ffb2303e196b1731c2abb

📐 Maintainability & Code Quality | 🟠 Major | ⚡ Quick win

Remove the unused export keywords to fix the failing Knip check.

vp run knip:check fails in CI for MARK_TO_TIPTAP (Line 30) and randomNodeKey (Line 58). Both symbols are referenced only inside this file: MARK_TO_TIPTAP at Line 158 and randomNodeKey at Line 112. Drop the export keyword on both. MARK_NESTING_ORDER and TIPTAP_TO_MARK have external consumers, so keep them exported.

Also applies to: 58-58

Source: Pipeline failures

✅ Confirmed as addressed by @maria-rcks

fixed in 71a1496: unused exports removed; the inline-token export now has a real paste consumer. scoped knip and the github check job pass.

🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win

Preserve the caret's logical position when indenting. When a collapsed Tab selection is on a list line, ChatComposer.tsx applies the insertion at line.start. replaceTextRange sets the cursor to safeStart + replacement.length, and applyPromptReplacement passes that value to focusAt. For "- foo" with the caret at offset 5, this moves the caret to offset 2, before the marker, instead of offset 7 after the same logical character. Shift the original caret by the inserted two spaces, or restore it after applying the edit.

✅ Addressed in commit 71a1496

🟡 Medium components/ComposerPromptEditor.tsx:16

Typing - [ ] task in rich mode leaves literal text instead of creating a clickable task item. The Tiptap input rule only recognizes [ ] at the start of a line, while bullet-list handling is disabled, and the controlled-value path skips buildDocJson after recording the newly typed document in snapshotRef; add an input/transaction conversion for the composer syntax or ensure that path rebuilds through buildDocJson.

fixed in 71a1496: rich mode has an explicit - [ ] input rule; plain mode installs no task extensions. the uploaded recording shows typing, toggling, and sending the task to codex.

🟡 Medium components/ComposerPromptEditorTiptap.tsx:796

On macOS, unmodified Home and End fall through this handler, so the composer no longer moves the caret to the current visual line boundary as it did previously. The native contenteditable behavior does not provide that navigation reliably; restore the macOS handling using Selection.modify(..., "lineboundary") (including the selection-extension behavior where applicable).

No longer relevant as of 71a1496e981a4e9c9b3ffb2303e196b1731c2abb

fixed in 71a1496: mac home/end uses visual line boundaries, preserving shift selection. the fallback is guarded by browser support.

🟡 Medium src/composer-rich-text-doc.ts:576

flatToPm returns an invalid ProseMirror position for an empty document and for a prompt ending in \n: it returns 0 or the trailing paragraph's start, while the editable caret position is inside the paragraph at 1 or one position later. The fallback uses the last run's end without accounting for the empty paragraph after a break run; adjust the empty-document and trailing-break cases so setTextSelection receives the paragraph content position.

No longer relevant as of 71a1496e981a4e9c9b3ffb2303e196b1731c2abb

fixed in 71a1496: empty paragraphs carry explicit editable anchors, including trailing newlines. document mapping tests pass.

🟡 Medium chat/ChatComposer.tsx:3980

During IME composition, a Tab keydown on a list item is consumed by this path and listIndentForTab rewrites the draft with two spaces, disrupting the candidate UI. Guard the list-edit path when event.isComposing is true so the key remains available to the IME.

✅ Resolved in d5744df7c061c8449e6e03ba3e85e575d7881a57

🟡 Medium src/composer-rich-text-doc.ts:375

Overlapping marks are serialized as malformed Markdown: children marked bold, bold+italic, italic produce **a*****b**c*, which parseInlineMarkdown cannot round-trip, so the next controlled update changes the prompt's formatting/content. The retention logic at line 375 only preserves a common prefix; crossing ranges must close and reopen marks (or otherwise be split into valid nested Markdown) instead of emitting this delimiter sequence.

fixed in d5744df: the parser handles both crossing directions and adjacent nesting. four document-equality cases cover the overlapping mark combinations; focused tests and web typecheck pass on the current head.

🟠 High src/composer-rich-text.ts:94

A matched run of 10,000 * characters creates 5,000 nested frames, and closing them repeatedly copies the entire mark stack at line 92, causing quadratic work and potentially freezing or exhausting the browser tab. Avoid opening a frame when the candidate delimiter duplicates the current top delimiter (or enforce a nesting depth cap) so repeated runs are handled without unbounded stack copying.

No longer relevant as of d5744df7c061c8449e6e03ba3e85e575d7881a57

🟠 High components/ComposerPromptEditorTiptap.tsx:1019

Mounting with a nonzero cursor leaves the ProseMirror caret at the document start, so the first typing or paste edits the beginning of the prompt instead of the supplied position. Because snapshotRef is pre-seeded with the same value and cursor, this equality check exits before setTextSelection, while the editor's default selection is still at the start. Apply the initial controlled selection explicitly rather than treating the seeded snapshot as proof that it has been applied.

No longer relevant as of 55e4b71128704b02b7fe7288a80bcc809df1f7ae

fixed in 55e4b711: initial controlled selection bypasses both equality and blurred cursor-only guards. verified restoring a populated draft with the terminal open: the terminal kept focus while the editor caret initialized at the end; native editor focus and typing appended correctly. web typecheck and scoped lint pass on blacksmith.

Shared primitives: use the existing Button primitive’s chip variant instead of a styled raw <button>.

^{Posted via Macroscope — UI Consistency}

addressed in fdc495e6: the mention uses Button variant="chip", which keeps the existing classes and preview action.

🟡 Medium components/ComposerPromptEditorTiptap.tsx:940

A paste already handled by the capture-phase onPaste callback is inserted into the editor again, so auto-folded content is both attached and pasted, while over-limit text is still inserted after being rejected. Check event.defaultPrevented before reading and inserting the clipboard text.

the native prosemirror event listener already rejects default-prevented bubbling events in eventBelongsToView (prosemirror-view/src/input.ts:93), before invoking handlePaste. React onPasteCapture prevents the native event, so folded/rejected text does not reach this handler. no duplicate guard is needed.

🟠 High components/ComposerPromptEditorTiptap.tsx:876

Pressing Enter in a task item submits the prompt instead of splitting or creating the next task item when Enter is the configured send shortcut. The code invokes onCommandKeyDownRef.current before the isTaskItem split logic, so ChatComposer handles the normal submission intent first; handle task-item Enter before that handler, while preserving any required menu handling.

the configured send shortcut must keep sending in both composer modes. with Enter configured to send, Shift+Enter inserts/splits a task; with a multiline send setting, Enter splits it. native task splitting runs only after menu and submission handling intentionally. the browser verified both sending a task and Shift+Enter splitting bold task content.