Synced from GitHub
Caution
Review failed
The pull request is closed.
Walkthrough
Migrates formatting/linting from Biome to Oxfmt/Oxlint, adds VSCode Oxc recommendations/settings, upgrades Bun and TypeScript targets to newer versions, introduces a new exported helper resolveModelSlug, and applies widespread formatting/refactor-style changes plus one error chaining improvement.
Changes
| Cohort / File(s) | Summary |
|---|---|
Tooling & Editor config ./.oxfmtrc.json, ./.oxlintrc.json, ./.vscode/extensions.json, ./.vscode/settings.json, ./biome.json | Add Oxfmt/Oxlint configs and VSCode recommendations/settings; remove biome.json. Check ignorePatterns and plugin/rule toggles in .oxlintrc.json. |
Repository root config ./package.json, ./turbo.json, ./tsconfig.base.json, ./README.md | Replace Biome tooling with oxfmt/oxlint, update scripts (lint → oxlint, add fmt), add Bun engine and update packageManager to bun@1.3.9, remove top-level lint turbo task, bump TS target/lib to ES2023, and minor README formatting. |
Desktop app scripts & package apps/desktop/package.json, apps/desktop/scripts/dev-electron.mjs, apps/desktop/tsconfig.json | Switch dev script from concurrently to bun run --parallel, remove lint script and concurrently devDependency, and bump TS lib to ES2023; minor script formatting changes. |
Desktop app internals apps/desktop/src/codexAppServerManager.ts, apps/desktop/src/main.ts, apps/desktop/src/preload.ts, apps/desktop/src/processManager.ts, apps/desktop/src/todoStore.ts, apps/desktop/src/*test.ts | Primarily formatting (many multi-line -> single-line refactors). Note: startSession error throw now includes original error as cause; runTerminalCommand signature formatting simplified. Tests and helpers reformatted only. |
Renderer app config & styling apps/renderer/package.json, apps/renderer/tsconfig.json, apps/renderer/src/index.css | Remove renderer lint script, bump TS lib to ES2023, minor CSS formatting adjustments. |
Renderer components & logic apps/renderer/src/components/ChatMarkdown.tsx, apps/renderer/src/components/ChatView.tsx, apps/renderer/src/components/DiffPanel.tsx, apps/renderer/src/components/Sidebar.tsx, apps/renderer/src/persistenceSchema.ts, apps/renderer/src/session-logic.ts, apps/renderer/src/*test.ts | Mostly stylistic and minor behavior-preserving refactors. Notable logic change: use of .toReversed() instead of .reverse() to avoid mutation in reversal logic. Various UI class/token updates. |
Contracts package: types & API packages/contracts/package.json, packages/contracts/src/ipc.ts, packages/contracts/src/model.ts, packages/contracts/src/provider.ts, packages/contracts/src/*test.ts | Add files: ["dist"] canonicalization in package.json and remove redundant entry; reflow type/signature formatting; add exported resolveModelSlug(model) function (normalizes and falls back to DEFAULT_MODEL). |
Misc tests & small utilities apps/desktop/src/ipcHelpers.test.ts, packages/contracts/src/model.test.ts, apps/renderer/src/model-logic.test.ts, other small files | Formatting-only updates to imports, expectations, and helper signatures; no behavioral changes. |
Estimated code review effort
🎯 3 (Moderate) | ⏱️ ~25 minutes
Possibly related PRs
- pingdotgg/codething-mvp#1 — Repository-level tooling migration and configuration changes (adds .oxfmtrc/.oxlintrc, VSCode Oxc settings, replaces Biome with Oxfmt/Oxlint); appears to mirror this PR's migration work.
🚥 Pre-merge checks | ✅ 1 | ❌ 2
❌ Failed checks (1 warning, 1 inconclusive)
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Docstring Coverage | ⚠️ Warning | Docstring coverage is 7.14% which is insufficient. The required threshold is 80.00%. | Write docstrings for the functions missing them to satisfy the coverage threshold. |
| Title check | ❓ Inconclusive | The title 'oxc stack' refers to a core aspect of the changeset—replacing Biome with the Oxc linting/formatting toolchain—but is vague and could be unclear to someone unfamiliar with the project. | Consider a more descriptive title like 'Replace Biome with Oxc toolchain' to clearly communicate the main change to reviewers scanning the history. |
✅ Passed checks (1 passed)
| Check name | Status | Explanation |
|---|---|---|
| Description Check | ✅ Passed | Check skipped - CodeRabbit’s high-level summary is enabled. |
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
✨ Finishing touches
- 📝 Generate docstrings
🧪 Generate unit tests (beta)
- Create PR with unit tests
- Post copyable unit tests in a comment
- Commit unit tests in branch
juliusmarminge/barcelona
Comment @coderabbitai help to get the list of available commands and usage tips.
