# Files changed · PR \#9570 · pingdotgg/t3code [View on GitCafe](https://git.cafe/pingdotgg/t3code/pull/9570/diffs) Repository: [pingdotgg/t3code](https://git.cafe/pingdotgg/t3code) Visibility: public [test\(server\): pin git config for fixtures and compare native realpaths](https://git.cafe/pingdotgg/t3code/pull/9570.md) Version: 1 Head commit: 11da79bf1749dd38c5d89072ca3db3b5a684400f Base commit: 4c642ebd4f8cd9ef61e2fc03210ea536506be7ac Comparison base: 4c642ebd4f8cd9ef61e2fc03210ea536506be7ac Showing up to 20 entries from this revision. If the pull request changes, reopen the first page before continuing. ## apps/server/src/project/RepositoryIdentityResolver.test.ts Status: modified; +8; −4 ```diff @@ -1,3 +1,5 @@ +// @effect-diagnostics nodeBuiltinImport:off - realpathSync.native resolves Windows 8.3 short names, which the Effect realPath does not. +import * as NodeFS from "node:fs"; import * as NodeServices from "@effect/platform-node/NodeServices"; import { expect, it } from "@effect/vitest"; import * as Duration from "effect/Duration"; @@ -131,9 +133,11 @@ const resolver = yield* RepositoryIdentityResolver.RepositoryIdentityResolver; const identity = yield* resolver.resolve(cwd); + // Native realpath, since git reports the long form of a directory the + // temp dir may name by its 8.3 short form on Windows. const resolvedIdentityRoot = - identity?.rootPath === undefined ? "" : yield* fileSystem.realPath(identity.rootPath); - const resolvedCwd = yield* fileSystem.realPath(cwd); + identity?.rootPath === undefined ? "" : NodeFS.realpathSync.native(identity.rootPath); + const resolvedCwd = NodeFS.realpathSync.native(cwd); expect(identity).not.toBeNull(); expect(identity?.canonicalKey).toBe("github.com/t3tools/t3code"); @@ -161,8 +165,8 @@ const resolver = yield* RepositoryIdentityResolver.RepositoryIdentityResolver; const identity = yield* resolver.resolve(nestedWorkspace); const resolvedIdentityRoot = - identity?.rootPath === undefined ? "" : yield* fileSystem.realPath(identity.rootPath); + identity?.rootPath === undefined ? "" : NodeFS.realpathSync.native(identity.rootPath); + const resolvedRepoRoot = NodeFS.realpathSync.native(repoRoot); - const resolvedRepoRoot = yield* fileSystem.realPath(repoRoot); expect(identity).not.toBeNull(); expect(identity?.canonicalKey).toBe("github.com/t3tools/t3code"); ``` ## apps/server/src/testUtils/gitConfig.setup.ts Status: added; +21; −0 ```diff @@ -1,0 +1,21 @@ +// Pins git behaviour for every repository the suite creates, ahead of the +// host's ~/.gitconfig. Git for Windows installs with core.autocrlf=true, +// which checks committed LF files out as CRLF and breaks every byte-exact +// content assertion; a signing key or a non-default init branch on the +// developer's machine breaks fixtures the same way. Set as environment so +// each git child the driver spawns sees it without touching the fixtures. +const entries: ReadonlyArray = [ + ["core.autocrlf", "false"], + ["core.filemode", "false"], + ["core.longpaths", "true"], + ["commit.gpgsign", "false"], + ["tag.gpgsign", "false"], + ["init.defaultBranch", "main"], +]; + +const existing = Number(process.env.GIT_CONFIG_COUNT ?? "0"); +process.env.GIT_CONFIG_COUNT = String(existing + entries.length); +entries.forEach(([key, value], index) => { + process.env[`GIT_CONFIG_KEY_${existing + index}`] = key; + process.env[`GIT_CONFIG_VALUE_${existing + index}`] = value; +}); ``` ## apps/server/src/vcs/GitVcsDriverCore.test.ts Status: modified; +31; −25 ```diff @@ -1,4 +1,7 @@ +// @effect-diagnostics nodeBuiltinImport:off - realpathSync.native resolves Windows 8.3 short names, which the Effect realPath does not. +import * as NodeFS from "node:fs"; import * as NodeServices from "@effect/platform-node/NodeServices"; +import { HostProcessPlatform } from "@t3tools/shared/hostProcess"; import { assert, it, describe } from "@effect/vitest"; import * as Deferred from "effect/Deferred"; import * as Effect from "effect/Effect"; @@ -570,7 +573,6 @@ const driver = yield* makeGitVcsDriverCore().pipe( Effect.provideService(ChildProcessSpawner.ChildProcessSpawner, failingFetchSpawner), ); - const fileSystem = yield* FileSystem.FileSystem; const cwd = yield* makeTmpDir(); const remote = yield* makeTmpDir("git-vcs-driver-remote-"); const worktreesRoot = yield* makeTmpDir("git-vcs-driver-worktrees-"); @@ -606,9 +608,11 @@ "rev-parse", "--git-common-dir", ])).stdout.trim(); + // Native realpath, since git reports the long form of a directory the + // temp dir may name by its 8.3 short form on Windows. assert.equal( - yield* fileSystem.realPath(pathService.resolve(cwd, rootCommonDir)), - yield* fileSystem.realPath(pathService.resolve(worktreePath, linkedCommonDir)), + NodeFS.realpathSync.native(pathService.resolve(cwd, rootCommonDir)), + NodeFS.realpathSync.native(pathService.resolve(worktreePath, linkedCommonDir)), ); yield* Ref.set(fetchAttempts, 0); @@ -1376,31 +1380,33 @@ }); describe("worktree operations", () => { - it.effect("preserves newline characters in worktree paths when listing refs", () => - Effect.gen(function* () { - const cwd = yield* makeTmpDir(); - yield* initRepoWithCommit(cwd); - const worktreesRoot = yield* makeTmpDir("git-vcs-driver-worktrees-"); - const fileSystem = yield* FileSystem.FileSystem; + // NTFS rejects a newline in a file name, so there is nothing to preserve there. + it.effect.skipIf(HostProcessPlatform.defaultValue() === "win32")( - const pathService = yield* Path.Path; - const worktreePath = pathService.join(worktreesRoot, "linked\nworktree"); - const driver = yield* GitVcsDriver.GitVcsDriver; + "preserves newline characters in worktree paths when listing refs", + () => + Effect.gen(function* () { + const cwd = yield* makeTmpDir(); + yield* initRepoWithCommit(cwd); + const worktreesRoot = yield* makeTmpDir("git-vcs-driver-worktrees-"); + const pathService = yield* Path.Path; + const worktreePath = pathService.join(worktreesRoot, "linked\nworktree"); + const driver = yield* GitVcsDriver.GitVcsDriver; - yield* git(cwd, ["worktree", "add", "-b", "feature/newline-path", worktreePath]); + yield* git(cwd, ["worktree", "add", "-b", "feature/newline-path", worktreePath]); - const refs = yield* driver.listRefs({ cwd, refresh: true }); - const listedPath = refs.refs.find( - (ref) => ref.name === "feature/newline-path", + const refs = yield* driver.listRefs({ cwd, refresh: true }); + const listedPath = refs.refs.find( + (ref) => ref.name === "feature/newline-path", + )?.worktreePath; - )?.worktreePath; - if (typeof listedPath !== "string") { - return assert.fail("expected the linked branch to include its worktree path"); - } - assert.equal( - yield* fileSystem.realPath(listedPath), + if (typeof listedPath !== "string") { - yield* fileSystem.realPath(worktreePath), - ); - }), + return assert.fail("expected the linked branch to include its worktree path"); + } + assert.equal( + NodeFS.realpathSync.native(listedPath), + NodeFS.realpathSync.native(worktreePath), + ); + }), ); it.effect("checks out submodules in a new worktree", () => ``` ## apps/server/vite.config.ts Status: modified; +1; −0 ```diff @@ -78,6 +78,7 @@ // The server suite exercises sqlite, git, temp worktrees, and orchestration // runtimes heavily. Running files in parallel introduces load-sensitive flakes. fileParallelism: false, + setupFiles: ["./src/testUtils/gitConfig.setup.ts"], // Server integration tests exercise sqlite, git, and orchestration together. // Under package-wide runs they can exceed the default budget on loaded CI hosts. hookTimeout: 120_000, ```