# Files changed · PR \#23212 · pingdotgg/t3code
[View on GitCafe](https://git.cafe/pingdotgg/t3code/pull/23212/diffs)
Repository: [pingdotgg/t3code](https://git.cafe/pingdotgg/t3code)
Visibility: public
[fix\(web,mobile\): new replies show overwritten local images](https://git.cafe/pingdotgg/t3code/pull/23212.md)
Version: 9
Head commit: f7082ecebb44b72cff641b6ff381b83fad5d7111
Base commit: 89fe509232e787b51d0cf695861afe73316ce85b
Comparison base: ed9b7ca9c53843ea1e6b466bf7d52928d10e7db0
Showing up to 20 entries from this revision. If the pull request changes, reopen the first page before continuing.
## apps/mobile/src/features/threads/ThreadFeed.tsx
Status: modified; +12; −9
```diff
@@ -258,6 +258,7 @@
import { useFileChipShare } from "./useFileChipShare";
import {
MarkdownImageAvailableWidthContext,
+ MarkdownMediaRevisionContext,
ThreadMarkdownImage,
ThreadMarkdownImageUnavailable,
ThreadMarkdownImageView,
@@ -1554,15 +1555,17 @@
>
{renderedText.trim().length > 0 ? (
+
+
-
- renderImage={props.renderMarkdownImage}
- skills={props.skills}
- />
) : null}
{attachments.map((attachment) => {
```
## apps/mobile/src/features/threads/ThreadMarkdownImage.tsx
Status: modified; +9; −1
```diff
@@ -30,6 +30,9 @@
*/
export const MarkdownImageAvailableWidthContext = createContext(0);
+/** The reply an image belongs to, so a file overwritten at the same path is fetched again. */
+export const MarkdownMediaRevisionContext = createContext(undefined);
+
export function ThreadMarkdownImageView(props: {
readonly uri: string | null;
readonly sourceKey: string;
@@ -248,7 +251,12 @@
readonly onPressPreview: (source: FilePreviewSource) => void;
}) {
const withGallery = useFilePreviewGallery();
- const assetUrl = useAssetUrlState(props.environmentId, props.resource);
+ const revision = useContext(MarkdownMediaRevisionContext);
+ const assetUrl = useAssetUrlState(
+ props.environmentId,
+ props.resource,
+ props.resource._tag === "media-file" ? revision : undefined,
+ );
return (
Promise {
const connection = usePreparedConnection(environmentId);
const httpBaseUrl = connection._tag === "Some" ? connection.value.httpBaseUrl : null;
@@ -52,7 +57,7 @@
});
return async () => {
if (environmentId === null || resource === null || httpBaseUrl === null) return null;
- const result = await refresh({ environmentId, input: { resource } });
+ const result = await refresh({ environmentId, input: assetUrlInput(resource, cacheRevision) });
if (result._tag === "Failure") throw squashAtomCommandFailure(result);
return resolveAssetUrl(httpBaseUrl, result.value.relativeUrl);
};
@@ -92,6 +97,10 @@
return urls;
}
+function assetUrlInput(resource: AssetResource, cacheRevision: string | undefined) {
+ return cacheRevision === undefined ? { resource } : { resource, cacheRevision };
+}
+
function isFileResource(resource: AssetResource): boolean {
return (
resource._tag === "workspace-file" ||
```
## apps/web/src/components/ChatMarkdown.tsx
Status: modified; +6; −0
```diff
@@ -233,6 +233,8 @@
onRunShellCommand?: ((command: string) => void) | undefined;
imageBaseDir?: string | undefined;
workspaceMutationId?: string | null | undefined;
+ /** Mints file media URLs once per revision, such as a reply, instead of reusing a cached one. */
+ mediaRevision?: string | undefined;
onImageExpand?: ((preview: ExpandedImagePreview) => void) | undefined;
extraRemarkPlugins?: NonNullable;
renderContextReference?: ((reference: ChatMarkdownContextReference) => ReactNode) | undefined;
@@ -445,6 +447,7 @@
onRunShellCommand,
imageBaseDir,
workspaceMutationId,
+ mediaRevision,
onImageExpand,
renderContextReference,
headingLevelOffset = 0,
@@ -890,6 +893,7 @@
headingLevelOffset,
imageBaseDir,
workspaceMutationId,
+ mediaRevision,
inlineCodeFileLinkMetaByText,
inline,
mathEnabled,
@@ -1350,6 +1354,7 @@
imageBaseDir,
threadRef,
workspaceMutationId,
+ mediaRevision,
renderContextReference,
} = use(ChatMarkdownRendererContext);
const imageExpand = use(MarkdownLinkContext) ? undefined : expandMedia;
@@ -1462,6 +1467,7 @@
style={authoredSizeStyle}
workspaceRoot={cwd}
workspaceMutationId={workspaceMutationId}
+ mediaRevision={kind === "image" ? mediaRevision : undefined}
onImageExpand={imageExpand}
/>
);
```
## apps/web/src/components/chat/ChatMarkdownMedia.tsx
Status: modified; +7; −2
```diff
@@ -332,10 +332,15 @@
readonly fallbackSrc?: string | undefined;
readonly workspaceRoot?: string | undefined;
readonly workspaceMutationId?: string | null | undefined;
+ readonly mediaRevision?: string | undefined;
readonly onImageExpand?: ((preview: ExpandedImagePreview) => void) | undefined;
}) {
+ const assetUrl = useAssetUrlState(props.environmentId, props.resource, props.mediaRevision);
+ const refreshAssetUrl = useAssetUrlRefresh(
+ props.environmentId,
+ props.resource,
- const assetUrl = useAssetUrlState(props.environmentId, props.resource);
- const refreshAssetUrl = useAssetUrlRefresh(props.environmentId, props.resource);
+ props.mediaRevision,
+ );
const connectionReady = usePreparedConnection(props.environmentId)._tag === "Some";
const resource = props.resource;
const refreshToken = JSON.stringify([props.environmentId, resource, props.workspaceMutationId]);
```
## apps/web/src/components/chat/TimelineAssistantRows.tsx
Status: modified; +1; −0
```diff
@@ -43,6 +43,7 @@
text={messageText}
cwd={ctx.markdownCwd}
threadRef={ctx.threadRef ?? undefined}
+ mediaRevision={row.message.id}
isStreaming={Boolean(row.message.streaming)}
lineBreaks={shouldPreserveAssistantLineBreaks(messageText)}
skills={ctx.skills}
```
## packages/client-runtime/src/state/assets.ts
Status: modified; +13; −1
```diff
@@ -127,6 +127,15 @@
};
}
+/**
+ * `cacheRevision` stays on the client: it keys a separate cached URL, so a file overwritten
+ * at the same path is minted again for a new revision (such as a new reply) instead of
+ * reusing a URL the browser already holds the previous bytes for.
+ */
+export type AssetCreateUrlCacheInput = AssetCreateUrlInput & {
+ readonly cacheRevision?: string;
+};
+
export function createAssetEnvironmentAtoms(
runtime: Atom.AtomRuntime,
localMediaEnvironment?: Atom.Atom<{
@@ -134,7 +143,10 @@
readonly httpBaseUrl: string;
} | null>,
) {
+ const execute = Effect.fn("assets.createUrl")(function* ({
+ cacheRevision: _cacheRevision,
+ ...input
+ }: AssetCreateUrlCacheInput) {
- const execute = Effect.fn("assets.createUrl")(function* (input: AssetCreateUrlInput) {
const result = yield* request(WS_METHODS.assetsCreateUrl, input).pipe(Effect.result);
if (Result.isSuccess(result)) return result.success;
const error = result.failure;
```
## scripts/fixtures/image-cache-proof.json
Status: added; +8; −0
```diff
@@ -1,0 +1,8 @@
+{
+ "timestamp": "2026-10-21T12:00:00.000Z",
+ "imagePath": "/tmp/t3-15676-chart.png",
+ "initialReplies": ["R1", "R2", "R3", "R4"],
+ "nextReply": "R5 \u2014 source overwritten to YELLOW v2\n\n",
+ "board": "PNG landscape: \n\nInline PNG  follows prose.\n\nFile URL: \n\nTall PNG: \n\nSVG: \n\nSVG fragment: )\n\nMissing: \n\nBlocked: \n\nLinked: [](https://example.invalid/)\n\nDirect data: ",
+ "supplement": "Authored size: ![\"sized\"](\"./fixtures/chart.png\")
\n\nSpaced path: \n\nEncoded path: "
+}
```
## scripts/fixtures/image-cache-proof.py
Status: added; +80; −0
```diff
@@ -1,0 +1,80 @@
+#!/usr/bin/env python3
+"""Seed static image replies by cloning app-written V2 rows; stop the sandbox server first.
+
+Example: python3 scripts/fixtures/image-cache-proof.py --db .t3/userdata/statev2.sqlite
+--thread --workspace /tmp/issue-15676/workspace
+Requires Pillow for labelled PNG fixtures. This changes projections only, not event history.
+"""
+import argparse, json, pathlib, sqlite3
+from PIL import Image, ImageDraw, ImageFont
+
+p = argparse.ArgumentParser()
+p.add_argument('--db', type=pathlib.Path)
+p.add_argument('--thread')
+p.add_argument('--template-thread')
+p.add_argument('--workspace', type=pathlib.Path, required=True)
+p.add_argument('--color', choices=['blue', 'yellow'], default='blue')
+p.add_argument('--images-only', action='store_true')
+p.add_argument('--board', action='store_true')
+p.add_argument('--supplement', action='store_true')
+p.add_argument('--font', type=pathlib.Path, help='TrueType font for PNG labels; defaults to Liberation Sans Bold, else Pillow default')
+a = p.parse_args()
+f = json.loads(pathlib.Path(__file__).with_suffix('.json').read_text())
+default_font = pathlib.Path('/usr/share/fonts/truetype/liberation/LiberationSans-Bold.ttf')
+if a.font and not a.font.is_file():
+ p.error(f'--font not found: {a.font}')
+font_path = a.font or (default_font if default_font.is_file() else None)
+font = ImageFont.truetype(str(font_path), 28) if font_path else ImageFont.load_default(28)
+label, color, ink = ('BLUE v1', '#1261e8', 'white') if a.color == 'blue' else ('YELLOW v2', '#ffe100', 'black')
+def png(path, size):
+ image = Image.new('RGB', size, color)
+ ImageDraw.Draw(image).text((12, 24), label, font=font, fill=ink)
+ image.save(path)
+assets = a.workspace / 'fixtures'
+assets.mkdir(parents=True, exist_ok=True)
+png(f['imagePath'], (360, 100))
+png(assets / 'chart.png', (360, 100))
+png(assets / 'chart space.png', (360, 100))
+png(assets / 'tall.png', (180, 280))
+(assets / 'chart.svg').write_text('')
+if a.images_only:
+ raise SystemExit()
+if not a.db or not a.thread:
+ p.error('--db and --thread are required for projection seeding')
+resolved = a.db.resolve()
+if '.t3' not in resolved.parts or resolved.is_relative_to(pathlib.Path.home() / '.t3'):
+ p.error('Only an isolated worktree .t3 database is supported')
+c = sqlite3.connect(resolved)
+c.row_factory = sqlite3.Row
+# Keep the first backup: a repeat seed must not replace the pre-seed recovery copy.
+backup_path = pathlib.Path(str(resolved)+'.image-proof-backup')
+if not backup_path.exists():
+ with sqlite3.connect(backup_path) as backup:
+ c.backup(backup)
+msg = c.execute("SELECT * FROM orchestration_v2_projection_messages WHERE thread_id=? AND role='assistant' LIMIT 1", (a.template_thread or a.thread,)).fetchone()
+item = c.execute("SELECT * FROM orchestration_v2_projection_turn_items WHERE thread_id=? AND type='assistant_message' LIMIT 1", (a.template_thread or a.thread,)).fetchone()
+if not msg or not item:
+ p.error('Create this thread and complete a real provider reply before seeding')
+texts = [f['supplement']] if a.supplement else [f['board']] if a.board else [r+' — source BLUE v1\n\n' for r in f['initialReplies']]
+with c:
+ c.execute('DELETE FROM orchestration_v2_projection_messages WHERE thread_id=?', (a.thread,))
+ c.execute('DELETE FROM orchestration_v2_projection_turn_items WHERE thread_id=?', (a.thread,))
+ for i, text in enumerate(texts, 1):
+ mid, iid = a.thread+'-message-'+str(i), a.thread+'-item-'+str(i)
+ for table, template, rowid in [('orchestration_v2_projection_messages',msg,mid), ('orchestration_v2_projection_turn_items',item,iid)]:
+ row = dict(template)
+ payload = json.loads(row['payload_json'])
+ payload.update(id=rowid, text=text, updatedAt=f['timestamp'], threadId=a.thread, nodeId=None, runId='image-proof-static-run-'+str(i))
+ row['thread_id'] = a.thread
+ row['run_id'] = payload['runId']
+ row['node_id'] = payload['nodeId']
+ row['updated_at'] = f['timestamp']
+ if table.endswith('_messages'):
+ row.update(message_id=mid, created_at=f['timestamp'])
+ payload['createdAt'] = f['timestamp']
+ else:
+ row.update(turn_item_id=iid, ordinal=i)
+ payload.update(messageId=mid, nativeItemRef=None, providerTurnId=None, ordinal=i, startedAt=f['timestamp'], completedAt=f['timestamp'])
+ row['payload_json'] = json.dumps(payload)
+ c.execute('INSERT INTO '+table+' ('+','.join(row)+') VALUES ('+','.join('?' for _ in row)+')',tuple(row.values()))
+print('Seeded static projection fixture:',len(texts),'assistant replies; event history unchanged')
```