# Files changed · PR \#10279 · pingdotgg/t3code [View on GitCafe](https://git.cafe/pingdotgg/t3code/pull/10279/diffs) Repository: [pingdotgg/t3code](https://git.cafe/pingdotgg/t3code) Visibility: public [refactor\(server\): classify source control exports](https://git.cafe/pingdotgg/t3code/pull/10279.md) Version: 2 Head commit: 3006c8731afadb92c6bda06891c29bfe01387539 Base commit: 375ccee2e02f7813c81301724d12be054af1e5b1 Comparison base: 375ccee2e02f7813c81301724d12be054af1e5b1 Showing up to 20 entries from this revision. If the pull request changes, reopen the first page before continuing. ## apps/server/src/pullRequest/AzureDevOpsPullRequestCli.ts Status: modified; +1; −0 ```diff @@ -261,6 +261,7 @@ return name.length > 0 && !name.startsWith("-"); } +/** @public Service construction is part of the canonical Effect module API. */ export const make = Effect.gen(function* () { const azure = yield* AzureDevOpsCli.AzureDevOpsCli; ``` ## apps/server/src/pullRequest/BitbucketPullRequestApi.ts Status: modified; +1; −0 ```diff @@ -378,6 +378,7 @@ } } +/** @public Service construction is part of the canonical Effect module API. */ export const make = Effect.gen(function* () { const bitbucket = yield* BitbucketApi.BitbucketApi; ``` ## apps/server/src/pullRequest/GitHubPullRequestCli.ts Status: modified; +2; −1 ```diff @@ -714,7 +714,7 @@ * The host is not read off the identity: it travels alongside it, because the identity a * project records is the path below its host and never names the host itself. */ -export function parseRepositorySelector(value: string): { +function parseRepositorySelector(value: string): { readonly owner: string; readonly name: string; } { @@ -980,6 +980,7 @@ } } +/** @public Service construction is part of the canonical Effect module API. */ export const make = Effect.gen(function* () { const github = yield* GitHubCli.GitHubCli; const graphQlBudget = yield* GitHubGraphQlBudget.GitHubGraphQlBudget; ``` ## apps/server/src/pullRequest/GitLabPullRequestCli.ts Status: modified; +1; −0 ```diff @@ -511,6 +511,7 @@ } } +/** @public Service construction is part of the canonical Effect module API. */ export const make = Effect.gen(function* () { const gitlab = yield* GitLabCli.GitLabCli; ``` ## apps/server/src/pullRequest/PullRequestProviderRegistry.ts Status: modified; +2; −0 ```diff @@ -41,6 +41,8 @@ /** * The hosts this build can read change requests from. A host with no entry here still shows up * in the provider list as unimplemented, so its projects are explained rather than missing. + * + * @public Service construction is part of the canonical Effect module API. */ export const make = Effect.map( Effect.all([ ``` ## apps/server/src/sourceControl/AzureDevOpsCli.ts Status: modified; +1; −2 ```diff @@ -203,8 +203,6 @@ ]); export type AzureDevOpsCliError = typeof AzureDevOpsCliError.Type; -export const isAzureDevOpsCliError = Schema.is(AzureDevOpsCliError); - export interface AzureDevOpsRepositoryCloneUrls { readonly nameWithOwner: string; readonly url: string; @@ -352,6 +350,7 @@ ); } +/** @public Service construction is part of the canonical Effect module API. */ export const make = Effect.gen(function* () { const process = yield* VcsProcess.VcsProcess; ``` ## apps/server/src/sourceControl/AzureDevOpsSourceControlProvider.ts Status: modified; +0; −3 ```diff @@ -1,5 +1,4 @@ import * as Effect from "effect/Effect"; -import * as Layer from "effect/Layer"; import { SourceControlProviderError, type ChangeRequest } from "@t3tools/contracts"; import * as AzureDevOpsCli from "./AzureDevOpsCli.ts"; @@ -235,5 +234,3 @@ ), }); }); - -export const layer = Layer.effect(SourceControlProvider.SourceControlProvider, make); ``` ## apps/server/src/sourceControl/BitbucketApi.ts Status: modified; +2; −1 ```diff @@ -262,7 +262,7 @@ BitbucketCheckoutError, ]); export type BitbucketApiError = typeof BitbucketApiError.Type; -export const isBitbucketApiError = Schema.is(BitbucketApiError); +const isBitbucketApiError = Schema.is(BitbucketApiError); const RawBitbucketRepositorySchema = Schema.Struct({ full_name: TrimmedNonEmptyString, @@ -606,6 +606,7 @@ }); } +/** @public Service construction is part of the canonical Effect module API. */ export const make = Effect.gen(function* () { const config = yield* BitbucketApiEnvConfig; const httpClient = yield* HttpClient.HttpClient; ``` ## apps/server/src/sourceControl/BitbucketSourceControlProvider.ts Status: modified; +0; −3 ```diff @@ -1,5 +1,4 @@ import * as Effect from "effect/Effect"; -import * as Layer from "effect/Layer"; import * as Option from "effect/Option"; import { SourceControlProviderError, type ChangeRequest } from "@t3tools/contracts"; @@ -186,8 +185,6 @@ }); }); -export const layer = Layer.effect(SourceControlProvider.SourceControlProvider, make); - export const makeDiscovery = Effect.gen(function* () { const bitbucket = yield* BitbucketApi.BitbucketApi; ``` ## apps/server/src/sourceControl/GitHubCli.ts Status: modified; +1; −0 ```diff @@ -338,6 +338,7 @@ }; } +/** @public Service construction is part of the canonical Effect module API. */ export const make = Effect.gen(function* () { const process = yield* VcsProcess.VcsProcess; ``` ## apps/server/src/sourceControl/GitHubSourceControlProvider.ts Status: modified; +0; −3 ```diff @@ -1,6 +1,5 @@ import * as DateTime from "effect/DateTime"; import * as Effect from "effect/Effect"; -import * as Layer from "effect/Layer"; import * as Option from "effect/Option"; import * as Result from "effect/Result"; import { @@ -322,5 +321,3 @@ ), }); }); - -export const layer = Layer.effect(SourceControlProvider.SourceControlProvider, make); ``` ## apps/server/src/sourceControl/GitLabCli.ts Status: modified; +1; −1 ```diff @@ -237,7 +237,6 @@ GitLabNamespaceDecodeError, ]); export type GitLabCliError = typeof GitLabCliError.Type; -export const isGitLabCliError = Schema.is(GitLabCliError); export interface GitLabMergeRequestSummary { readonly number: number; @@ -409,6 +408,7 @@ return { namespacePath, projectPath }; } +/** @public Service construction is part of the canonical Effect module API. */ export const make = Effect.gen(function* () { const process = yield* VcsProcess.VcsProcess; ``` ## apps/server/src/sourceControl/GitLabSourceControlProvider.ts Status: modified; +0; −3 ```diff @@ -1,5 +1,4 @@ import * as Effect from "effect/Effect"; -import * as Layer from "effect/Layer"; import * as Option from "effect/Option"; import { SourceControlProviderError, type ChangeRequest } from "@t3tools/contracts"; @@ -250,5 +249,3 @@ ), }); }); - -export const layer = Layer.effect(SourceControlProvider.SourceControlProvider, make); ``` ## apps/server/src/sourceControl/SourceControlDiscovery.ts Status: modified; +1; −0 ```diff @@ -64,6 +64,7 @@ } >()("t3/sourceControl/SourceControlDiscovery") {} +/** @public Service construction is part of the canonical Effect module API. */ export const make = Effect.gen(function* () { const config = yield* ServerConfig; const process = yield* VcsProcess.VcsProcess; ``` ## apps/server/src/sourceControl/SourceControlProvider.ts Status: modified; +1; −1 ```diff @@ -61,7 +61,7 @@ return owner && refName ? { owner, refName } : undefined; } -export function normalizeSourceBranch(headSelector: string): string { +function normalizeSourceBranch(headSelector: string): string { return parseSourceControlOwnerRef(headSelector)?.refName ?? headSelector.trim(); } ``` ## apps/server/src/sourceControl/SourceControlProviderDiscovery.ts Status: modified; +1; −1 ```diff @@ -115,7 +115,7 @@ }; } -export function unknownAuth(detail?: string): SourceControlProviderAuth { +function unknownAuth(detail?: string): SourceControlProviderAuth { return providerAuth({ status: "unknown", detail }); } ``` ## apps/server/src/sourceControl/SourceControlRateLimit.ts Status: modified; +1; −0 ```diff @@ -82,6 +82,7 @@ return Number.isFinite(retryAt) && retryAt > now ? retryAt : undefined; } +/** @public Service construction is part of the canonical Effect module API. */ export const make = Effect.gen(function* () { const entries = yield* Ref.make>(new Map()); ``` ## apps/server/src/sourceControl/SourceControlRepositoryService.ts Status: modified; +1; −0 ```diff @@ -77,6 +77,7 @@ } } +/** @public Service construction is part of the canonical Effect module API. */ export const make = Effect.gen(function* () { const config = yield* ServerConfig; const fileSystem = yield* FileSystem.FileSystem; ``` ## apps/server/src/sourceControl/azureDevOpsPullRequests.ts Status: modified; +1; −3 ```diff @@ -5,7 +5,7 @@ import * as Result from "effect/Result"; import * as Schema from "effect/Schema"; import { PositiveInt, TrimmedNonEmptyString } from "@t3tools/contracts"; -import { decodeJsonResult, formatSchemaError } from "@t3tools/shared/schemaJson"; +import { decodeJsonResult } from "@t3tools/shared/schemaJson"; export interface NormalizedAzureDevOpsPullRequestRecord { readonly number: number; @@ -190,8 +190,6 @@ const decodeAzureDevOpsPullRequest = decodeJsonResult(AzureDevOpsPullRequestSchema); const decodeAzureDevOpsPullRequestEntry = Schema.decodeUnknownExit(AzureDevOpsPullRequestSchema); -export const formatAzureDevOpsJsonDecodeError = formatSchemaError; - export function decodeAzureDevOpsPullRequestListJson( raw: string, ): Result.Result< ``` ## apps/server/src/sourceControl/gitHubPullRequests.ts Status: modified; +1; −3 ```diff @@ -5,7 +5,7 @@ import * as Result from "effect/Result"; import * as Schema from "effect/Schema"; import { PositiveInt, TrimmedNonEmptyString } from "@t3tools/contracts"; -import { decodeJsonResult, formatSchemaError } from "@t3tools/shared/schemaJson"; +import { decodeJsonResult } from "@t3tools/shared/schemaJson"; export interface NormalizedGitHubPullRequestRecord { readonly number: number; @@ -114,8 +114,6 @@ const decodeGitHubPullRequest = decodeJsonResult(GitHubPullRequestSchema); const decodeGitHubPullRequestEntry = Schema.decodeUnknownExit(GitHubPullRequestSchema); -export const formatGitHubJsonDecodeError = formatSchemaError; - export function decodeGitHubPullRequestListJson( raw: string, ): Result.Result< ``` [Next page](https://git.cafe/pingdotgg/t3code/pull/10279/diffs?after=ImFwcHMvc2VydmVyL3NyYy9zb3VyY2VDb250cm9sL2dpdEh1YlB1bGxSZXF1ZXN0cy50cyI&expectedVersion=2&format=markdown)