[Bug]: Add project, clone, and new-project submit buttons can't be reached with Tab#32566

opened3d agobyNnibarAhmed

Before submitting

  • I searched existing issues and did not find a duplicate.
  • I included enough detail to reproduce or investigate the problem.

Area

apps/web

Steps to reproduce

  1. Open the command palette and choose Add project → Clone repository (the step where you type a repository URL), or New project.
  2. Type something so the submit button (Continue, Lookup, Create) is enabled.
  3. Press Tab.

Expected behavior

Focus moves to the submit button next to the input, so keyboard and screen reader users can reach it the same way as any other button.

Actual behavior

Focus skips the submit button. CommandPaletteSubmitButton in apps/web/src/components/CommandPaletteAddProject.tsx sets tabIndex={-1}, so it is never in the Tab order. It is shared by the add-project folder, clone, and new-project flows.

That came in with the original folder picker (#2024), when Tab in the path field always meant completion and never left the input, so the button could not be reached by Tab anyway. #32468 (fixing #32452) lets Tab leave the folder path field when there is nothing to complete; with tabIndex={-1} still in place, focus then jumps past the submit button and wraps to Back.

Mouse clicks are unaffected either way: the button cancels mousedown, so clicking it keeps focus in the input.

Related to #32452. Independent of it: the clone and new-project steps don't use Tab for completion, so they are affected today.

Impact

Minor bug or occasional failure

Version or commit

main @ 25bf84ab07

Environment

Windows 11, T3 Code desktop, NVDA (also applies to web, same component)

Workaround

Press Enter (or Ctrl/⌘+Enter when a list row is highlighted) in the input. In NVDA browse mode the button can also be reached with the arrow keys and activated.