GitHub check
256 KB of 598 KB loaded Download the full log (598 KB)
342 KB of earlier output not loaded
03:47.6579027Z 964 โ const combinedContentInsetEndAdjustment = useSharedValue(
ยท โโโโโโโโโโโโโโโโโฌโโโโโโโโโโโโโโโโ
ยท โฐโโ `combinedContentInsetEndAdjustment` originates here
965 โ Math.max(0, estimatedOverlayHeight - nativeInsetOvercount),
966 โ );
967 โ useAnimatedReaction(
968 โ () =>
969 โ contentInsetEndAdjustment.value +
970 โ floatingControlCoverage.value +
971 โ (userInputCoverageApplies ? userInputInsetProgress.value * userInputCardCoverage.value : 0),
972 โ (value) => {
973 โ combinedContentInsetEndAdjustment.value = value;
ยท โโโโโโโโโโโโโโโโโฌโโโโโโโโโโโโโโโโ
ยท โฐโโ `combinedContentInsetEndAdjustment` cannot be modified
974 โ },
โฐโโโโ
help: Modifying a value returned from a hook is not allowed. Consider moving the modification into the hook where the value is constructed
note: React Compiler skipped optimizing this component or hook. Additional guidance: https://react.dev/reference/eslint-plugin-react-hooks/lints/immutability
โ react(set-state-in-effect): Calling setState synchronously within an effect can trigger cascading renders
โญโ[apps/mobile/src/features/threads/ThreadMarkdownImage.tsx:57:5]
55 โ
56 โ useEffect(() => {
ยท โโโโโฌโโโโ
ยท โฐโโ This is the containing effect
57 โ setDecodedSize(null);
ยท โโโโโโโโฌโโโโโโ
ยท โฐโโ Avoid calling setState() directly within an effect
58 โ }, [props.sourceKey]);
โฐโโโโ
help: Effects should synchronize React with external systems. Calling setState synchronously inside an effect starts another render and is usually unnecessary. Derive the value during render, initialize state directly, or update it from the event that caused the change. Use an effect only when synchronizing with an external system.
note: React Compiler skipped optimizing this component or hook. Additional guidance: https://react.dev/reference/eslint-plugin-react-hooks/lints/set-state-in-effect
โ react(set-state-in-effect): Calling setState synchronously within an effect can trigger cascading renders
โญโ[apps/mobile/src/features/threads/ThreadMarkdownImage.tsx:61:5]
59 โ
60 โ useEffect(() => {
ยท โโโโโฌโโโโ
ยท โฐโโ This is the containing effect
61 โ setFailedUri(null);
ยท โโโโโโโฌโโโโโ
ยท โฐโโ Avoid calling setState() directly within an effect
62 โ }, [props.uri]);
โฐโโโโ
help: Effects should synchronize React with external systems. Calling setState synchronously inside an effect starts another render and is usually unnecessary. Derive the value during render, initialize state directly, or update it from the event that caused the change. Use an effect only when synchronizing with an external system.
note: React Compiler skipped optimizing this component or hook. Additional guidance: https://react.dev/reference/eslint-plugin-react-hooks/lints/set-state-in-effect
โ eslint(no-unused-vars): Identifier 'ActivityIndicator' is imported but never used.
โญโ[apps/mobile/src/features/threads/ThreadMarkdownImage.tsx:7:10]
6 โ import { parse, SvgAst, type JsxAST } from "react-native-svg";
7 โ import { ActivityIndicator, Pressable, StyleSheet, View, type ViewStyle } from "react-native";
ยท โโโโโโโโโฌโโโโโโโโ
ยท โฐโโ 'ActivityIndicator' is imported here
8 โ
โฐโโโโ
help: Consider removing this import.
โ react(exhaustive-effect-dependencies): Found extra effect dependencies
โญโ[apps/mobile/src/features/threads/ThreadMarkdownImage.tsx:58:7]
57 โ setDecodedSize(null);
58 โ }, [props.sourceKey]);
ยท โโโโโโโโฌโโโโโโโ
ยท โฐโโ Unnecessary dependency `props.sourceKey`
59 โ
โฐโโโโ
help: Extra dependencies can cause an effect to fire more often than it should, resulting in performance problems such as excessive renders and side effects
note: React Compiler skipped optimizing this component or hook. Additional guidance: https://react.dev/reference/eslint-plugin-react-hooks/lints/exhaustive-deps
โ react(exhaustive-effect-dependencies): Found extra effect dependencies
โญโ[apps/mobile/src/features/threads/ThreadMarkdownImage.tsx:62:7]
61 โ setFailedUri(null);
62 โ }, [props.uri]);
ยท โโโโโฌโโโโ
ยท โฐโโ Unnecessary dependency `props.uri`
63 โ
โฐโโโโ
help: Extra dependencies can cause an effect to fire more often than it should, resulting in performance problems such as excessive renders and side effects
note: React Compiler skipped optimizing this component or hook. Additional guidance: https://react.dev/reference/eslint-plugin-react-hooks/lints/exhaustive-deps
โ eslint(no-unused-vars): Type 'AuthSessionState' is imported but never used.
โญโ[apps/web/src/components/settings/ProviderSettingsPanel.logic.ts:4:8]
3 โ AuthProvidersManageScope,
4 โ type AuthSessionState,
ยท โโโโโโโโโฌโโโโโโโ
ยท โฐโโ 'AuthSessionState' is imported here
5 โ type EnvironmentId,
โฐโโโโ
help: Consider removing this import.
โ t3code(no-inline-schema-compile): Hoist Schema.encodeUnknownSync(...) to module scope: both the inline schema literal and the compiled function are rebuilt on every call. Move the compiled function to a module-level const.
โญโ[packages/contracts/src/baseSchemas.test.ts:39:9]
38 โ JSON.stringify(
39 โ Schema.encodeUnknownSync(Schema.toCodecJson(Named))([
ยท โโโโโโโโโโโโโโโโโโโโโโโโ
40 โ { name: "a" },
โฐโโโโ
โ eslint(no-unused-vars): Variable 'layer' is declared but never used. Unused variables should start with a '_'.
โญโ[packages/provider-grok/src/server/adapter.ts:408:7]
407 โ
408 โ const layer: Layer.Layer<
ยท โโโฌโโ
ยท โฐโโ 'layer' is declared here
409 โ ProviderAdapter.ProviderAdapterV2,
โฐโโโโ
help: Consider removing this declaration.
โ react(set-state-in-effect): Calling setState synchronously within an effect can trigger cascading renders
โญโ[apps/mobile/src/features/threads/use-composer-command-menu.ts:215:7]
211 โ };
212 โ useEffect(() => {
ยท โโโโโฌโโโโ
ยท โฐโโ This is the containing effect
213 โ const inserted = ownerKey ? readComposerDraftSelection(ownerKey, draftMessage) : null;
214 โ if (inserted) {
215 โ setSelection((current) =>
ยท โโโโโโโฌโโโโโ
ยท โฐโโ Avoid calling setState() directly within an effect
216 โ current.start === inserted.start && current.end === inserted.end ? current : inserted,
โฐโโโโ
help: Effects should synchronize React with external systems. Calling setState synchronously inside an effect starts another render and is usually unnecessary. Derive the value during render, initialize state directly, or update it from the event that caused the change. Use an effect only when synchronizing with an external system.
note: React Compiler skipped optimizing this component or hook. Additional guidance: https://react.dev/reference/eslint-plugin-react-hooks/lints/set-state-in-effect
โ react(set-state-in-effect): Calling setState synchronously within an effect can trigger cascading renders
โญโ[apps/mobile/src/features/threads/use-composer-command-menu.ts:296:7]
284 โ }, [hasWorkspaceSnapshot]);
285 โ useEffect(() => {
ยท โโโโโฌโโโโ
ยท โฐโโ This is the containing effect
286 โ if (!environmentId || !projectCwd || !selectedProviderInstanceId) return;
287 โ const key = `${environmentId}:${selectedProviderInstanceId}:${projectCwd}`;
288 โ const now = Date.now();
289 โ const lastRequest = workspaceRefreshKeyRef.current;
290 โ if (
291 โ lastRequest?.key === key &&
292 โ now - lastRequest.requestedAt < PROVIDER_WORKSPACE_SNAPSHOT_TTL_MS
293 โ )
294 โ return;
295 โ if (hasCurrentProviderWorkspaceSnapshot(selectedProviderStatus, projectCwd, now)) {
296 โ setWorkspaceRefreshRetry(null);
ยท โโโโโโโโโโโโโฌโโโโโโโโโโโ
ยท โฐโโ Avoid calling setState() directly within an effect
297 โ return;
โฐโโโโ
help: Effects should synchronize React with external systems. Calling setState synchronously inside an effect starts another render and is usually unnecessary. Derive the value during render, initialize state directly, or update it from the event that caused the change. Use an effect only when synchronizing with an external system.
note: React Compiler skipped optimizing this component or hook. Additional guidance: https://react.dev/reference/eslint-plugin-react-hooks/lints/set-state-in-effect
โ react(exhaustive-effect-dependencies): Found extra effect dependencies
โญโ[apps/mobile/src/features/threads/use-composer-command-menu.ts:326:5]
325 โ }, [
326 โ draftMessage,
ยท โโโโโโโฌโโโโโ
ยท โฐโโ Unnecessary dependency `draftMessage`
327 โ environmentId,
โฐโโโโ
help: Extra dependencies can cause an effect to fire more often than it should, resulting in performance problems such as excessive renders and side effects
note: React Compiler skipped optimizing this component or hook. Additional guidance: https://react.dev/reference/eslint-plugin-react-hooks/lints/exhaustive-deps
โ eslint(no-unused-vars): Function 'promptResponseHasMissingXAiStopReason' is declared but never used.
โญโ[packages/provider-grok/src/server/xaiAcpExtension.ts:1620:10]
1619 โ
1620 โ function promptResponseHasMissingXAiStopReason(response: EffectAcpSchema.PromptResponse): boolean {
ยท โโโโโโโโโโโโโโโโโโโฌโโโโโโโโโโโโโโโโโโ
ยท โฐโโ 'promptResponseHasMissingXAiStopReason' is declared here
1621 โ const meta = response._meta;
โฐโโโโ
help: Consider removing this declaration.
โ unicorn(no-new-array): Do not use `new Array(singleArgument)`.
โญโ[apps/web/src/terminal/ghostty/core.ts:194:19]
193 โ const count = Math.min(CHUNK_SIZE, graphemeLength - start);
194 โ const codes = new Array<number>(count);
ยท โโโโโโโโโโโโโโโโโโโโโโโโ
195 โ for (let index = 0; index < count; index += 1) {
โฐโโโโ
help: It's not clear whether the argument is meant to be the length of the array or the only element. If the argument is the array's length, consider using `Array.from({ length: n })`. If the argument is the only element, use `[element]`.
โ eslint(no-unused-vars): Variable 'layer' is declared but never used. Unused variables should start with a '_'.
โญโ[packages/provider-opencode/src/server/adapter.ts:3755:7]
3754 โ
3755 โ const layer: Layer.Layer<ProviderAdapter.ProviderAdapterV2, never, OpenCodeAdapterV2DriverEnv> =
ยท โโโฌโโ
ยท โฐโโ 'layer' is declared here
3756 โ Layer.effect(
โฐโโโโ
help: Consider removing this declaration.
โ react(set-state-in-effect): Calling setState synchronously within an effect can trigger cascading renders
โญโ[apps/mobile/src/features/threads/ThreadRouteScreen.tsx:400:5]
398 โ
399 โ useEffect(() => {
ยท โโโโโฌโโโโ
ยท โฐโโ This is the containing effect
400 โ setInspectorSelection((current) => {
ยท โโโโโโโโโโโฌโโโโโโโโโโ
ยท โฐโโ Avoid calling setState() directly within an effect
401 โ if (props.renderInspector === undefined) {
โฐโโโโ
help: Effects should synchronize React with external systems. Calling setState synchronously inside an effect starts another render and is usually unnecessary. Derive the value during render, initialize state directly, or update it from the event that caused the change. Use an effect only when synchronizing with an external system.
note: React Compiler skipped optimizing this component or hook. Additional guidance: https://react.dev/reference/eslint-plugin-react-hooks/lints/set-state-in-effect
โ react(no-unstable-nested-components): Do not define components during render.
โญโ[apps/mobile/src/features/threads/ThreadRouteScreen.tsx:528:24]
527 โ const inspectorHeaderInset = Platform.OS === "ios" ? 0 : safeAreaInsets.top;
528 โ โญโโถ const GitInspector = () => (
529 โ โ <GitOverviewSheet
530 โ โ headerInset={inspectorHeaderInset}
531 โ โ presentation="inspector"
532 โ โ route={{ params: { environmentId: environmentId!, threadId: threadId! } }}
533 โ โ />
534 โ โฐโโถ );
535 โ const FilesInspector = () =>
โฐโโโโ
help: Move this component definition out of the parent component `ThreadRouteContent` and pass data as props.
โ react(no-unstable-nested-components): Do not define components during render.
โญโ[apps/mobile/src/features/threads/ThreadRouteScreen.tsx:535:26]
534 โ );
535 โ โญโโถ const FilesInspector = () =>
536 โ โ selectedThread !== null && selectedThreadCwd !== null ? (
537 โ โ <ThreadFileNavigatorPane
538 โ โ cwd={selectedThreadCwd}
539 โ โ environmentId={selectedThread.environmentId}
540 โ โ headerInset={inspectorHeaderInset}
541 โ โ projectName={selectedThreadProject?.title ?? "Files"}
542 โ โ selectedPath={null}
543 โ โ onSelectFile={handleSelectInspectorFile}
544 โ โ />
545 โ โฐโโถ ) : null;
546 โ const RouteInspector = () => props.renderInspector?.(inspectorHeaderInset);
โฐโโโโ
help: Move this component definition out of the parent component `ThreadRouteContent` and pass data as props.
โ unicorn(no-useless-fallback-in-spread): Empty fallbacks in spreads are unnecessary
โญโ[apps/mobile/src/state/use-composer-drafts.ts:1022:15]
1021 โ instanceId,
1022 โ { ...(persisted.modelOptionMemory[instanceId] ?? {}), ...models },
ยท โโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโ
1023 โ ]),
โฐโโโโ
help: Spreading falsy values in object literals won't add any unexpected properties, so it's unnecessary to add an empty object as fallback.
โ eslint(no-empty-pattern): Empty object binding pattern
โญโ[packages/provider-opencode/src/server/OpenCodeRuntime.environment.test.ts:53:14]
52 โ
53 โ for (const {} of [
ยท โโ
54 โ { healthy: true },
โฐโโโโ
help: Passing `null` or `undefined` will result in runtime error because `null` and `undefined` cannot be destructured.
โ t3code(no-inline-schema-compile): Hoist Schema.is(...) to module scope: the compiled function is rebuilt on every call. Move it to a module-level const.
โญโ[packages/effect-codex-app-server/src/schema.test.ts:50:18]
49 โ for (const tool of ["sendMessage", "followupTask", "interruptAgent", "listAgents"]) {
50 โ assert.equal(Schema.is(CodexSchema.ServerNotification__CollabAgentTool)(tool), true);
ยท โโโโโโโโโ
51 โ assert.equal(Schema.is(CodexSchema.V2ThreadResumeResponse__CollabAgentTool)(tool), true);
โฐโโโโ
โ t3code(no-inline-schema-compile): Hoist Schema.is(...) to module scope: the compiled function is rebuilt on every call. Move it to a module-level const.
โญโ[packages/effect-codex-app-server/src/schema.test.ts:51:18]
50 โ assert.equal(Schema.is(CodexSchema.ServerNotification__CollabAgentTool)(tool), true);
51 โ assert.equal(Schema.is(CodexSchema.V2ThreadResumeResponse__CollabAgentTool)(tool), true);
ยท โโโโโโโโโ
52 โ }
โฐโโโโ
โ t3code(no-inline-schema-compile): Hoist Schema.is(...) to module scope: the compiled function is rebuilt on every call. Move it to a module-level const.
โญโ[packages/effect-codex-app-server/src/schema.test.ts:55:5]
54 โ assert.equal(
55 โ Schema.is(CodexSchema.ServerNotification__CollabAgentToolCallStatus)("interrupted"),
ยท โโโโโโโโโ
56 โ true,
โฐโโโโ
โ t3code(no-inline-schema-compile): Hoist Schema.is(...) to module scope: the compiled function is rebuilt on every call. Move it to a module-level const.
โญโ[packages/effect-codex-app-server/src/schema.test.ts:59:5]
58 โ assert.equal(
59 โ Schema.is(CodexSchema.V2ThreadResumeResponse__CollabAgentToolCallStatus)("interrupted"),
ยท โโโโโโโโโ
60 โ true,
โฐโโโโ
โ t3code(no-inline-schema-compile): Hoist Schema.is(...) to module scope: the compiled function is rebuilt on every call. Move it to a module-level const.
โญโ[packages/effect-codex-app-server/src/schema.test.ts:103:16]
102 โ
103 โ assert.equal(Schema.is(CodexSchema.V2ThreadResumeResponse)(resumeResponse), true);
ยท โโโโโโโโโ
104 โ });
โฐโโโโ
โ react(immutability): This value cannot be modified
โญโ[apps/mobile/src/features/threads/PendingUserInputCard.tsx:100:7]
86 โ
87 โ const cardCoverage = props.cardCoverage;
ยท โโโโโโโฌโโโโโ
ยท โฐโโ `cardCoverage` originates here
88 โ const barHeightRef = useRef(0);
89 โ const cardHeightRef = useRef(0);
90 โ const cardHeight = useSharedValue(0);
91 โ const notifyCoverage = useCallback(() => {
92 โ if (!cardCoverage) {
93 โ return;
94 โ }
95 โ const coverage = Math.max(0, cardHeightRef.current - barHeightRef.current);
96 โ if (coverage === cardCoverage.value) {
97 โ return;
98 โ }
99 โ if (cardCoverage.value === 0) {
100 โ cardCoverage.value = coverage;
ยท โโโโโโโฌโโโโโ
ยท โฐโโ `cardCoverage` cannot be modified
101 โ return;
โฐโโโโ
help: Do not mutate component props or hook arguments. If the value should change, update it where it is owned and pass an update callback, or use local state
note: React Compiler skipped optimizing this component or hook. Additional guidance: https://react.dev/reference/eslint-plugin-react-hooks/lints/immutability
โ react(immutability): This value cannot be modified
โญโ[apps/mobile/src/features/threads/PendingUserInputCard.tsx:118:7]
89 โ const cardHeightRef = useRef(0);
90 โ const cardHeight = useSharedValue(0);
ยท โโโโโโฌโโโโ
ยท โฐโโ `cardHeight` originates here
91 โ const notifyCoverage = useCallback(() => {
92 โ if (!cardCoverage) {
93 โ return;
94 โ }
95 โ const coverage = Math.max(0, cardHeightRef.current - barHeightRef.current);
96 โ if (coverage === cardCoverage.value) {
97 โ return;
98 โ }
99 โ if (cardCoverage.value === 0) {
100 โ cardCoverage.value = coverage;
101 โ return;
102 โ }
103 โ cardCoverage.value = withTiming(coverage, {
104 โ duration: USER_INPUT_TOGGLE_DURATION_MS,
105 โ easing: Easing.out(Easing.cubic),
106 โ });
107 โ }, [cardCoverage]);
108 โ const handleBarLayout = useCallback(
109 โ (event: LayoutChangeEvent) => {
110 โ barHeightRef.current = event.nativeEvent.layout.height;
111 โ notifyCoverage();
112 โ },
113 โ [notifyCoverage],
114 โ );
115 โ const handleCardLayout = useCallback(
116 โ (event: LayoutChangeEvent) => {
117 โ cardHeightRef.current = event.nativeEvent.layout.height;
118 โ cardHeight.value = event.nativeEvent.layout.height;
ยท โโโโโโฌโโโโ
ยท โฐโโ `cardHeight` cannot be modified
119 โ notifyCoverage();
โฐโโโโ
help: Modifying a value returned from a hook is not allowed. Consider moving the modification into the hook where the value is constructed
note: React Compiler skipped optimizing this component or hook. Additional guidance: https://react.dev/reference/eslint-plugin-react-hooks/lints/immutability
โ react(immutability): Cannot modify local variables after render completes
โญโ[apps/mobile/src/features/threads/PendingUserInputCard.tsx:100:7]
90 โ const cardHeight = useSharedValue(0);
91 โ const notifyCoverage = useCallback(() => {
ยท โโโโฌโโโ
ยท โฐโโ This function may (indirectly) reassign or modify `cardCoverage` after render
92 โ if (!cardCoverage) {
93 โ return;
94 โ }
95 โ const coverage = Math.max(0, cardHeightRef.current - barHeightRef.current);
96 โ if (coverage === cardCoverage.value) {
97 โ return;
98 โ }
99 โ if (cardCoverage.value === 0) {
100 โ cardCoverage.value = coverage;
ยท โโโโโโโฌโโโโโ
ยท โฐโโ This modifies `cardCoverage`
101 โ return;
โฐโโโโ
help: This argument is a function which may reassign or mutate `cardCoverage` after render, which can cause inconsistent behavior on subsequent renders. Consider using state instead
note: React Compiler skipped optimizing this component or hook. Additional guidance: https://react.dev/reference/eslint-plugin-react-hooks/lints/immutability
โ react(immutability): Cannot modify local variables after render completes
โญโ[apps/mobile/src/features/threads/PendingUserInputCard.tsx:100:7]
99 โ if (cardCoverage.value === 0) {
100 โ cardCoverage.value = coverage;
ยท โโโโโโโฌโโโโโ
ยท โฐโโ This modifies `cardCoverage`
101 โ return;
102 โ }
103 โ cardCoverage.value = withTiming(coverage, {
104 โ duration: USER_INPUT_TOGGLE_DURATION_MS,
105 โ easing: Easing.out(Easing.cubic),
106 โ });
107 โ }, [cardCoverage]);
108 โ const handleBarLayout = useCallback(
109 โ (event: LayoutChangeEvent) => {
ยท โโโโโโโโโโโโโโโโฌโโโโโโโโโโโโโโโ
ยท โฐโโ This function may (indirectly) reassign or modify `cardCoverage` after render
110 โ barHeightRef.current = event.nativeEvent.layout.height;
โฐโโโโ
help: This argument is a function which may reassign or mutate `cardCoverage` after render, which can cause inconsistent behavior on subsequent renders. Consider using state instead
note: React Compiler skipped optimizing this component or hook. Additional guidance: https://react.dev/reference/eslint-plugin-react-hooks/lints/immutability
โ react(immutability): Cannot modify local variables after render completes
โญโ[apps/mobile/src/features/threads/PendingUserInputCard.tsx:118:7]
115 โ const handleCardLayout = useCallback(
116 โ (event: LayoutChangeEvent) => {
ยท โโโโโโโโโโโโโโโโฌโโโโโโโโโโโโโโโ
ยท โฐโโ This function may (indirectly) reassign or modify `cardHeight` after render
117 โ cardHeightRef.current = event.nativeEvent.layout.height;
118 โ cardHeight.value = event.nativeEvent.layout.height;
ยท โโโโโโฌโโโโ
ยท โฐโโ This modifies `cardHeight`
119 โ notifyCoverage();
โฐโโโโ
help: This argument is a function which may reassign or mutate `cardHeight` after render, which can cause inconsistent behavior on subsequent renders. Consider using state instead
note: React Compiler skipped optimizing this component or hook. Additional guidance: https://react.dev/reference/eslint-plugin-react-hooks/lints/immutability
โ react(no-object-type-as-default-prop): Do not use an array literal as default prop value. Use a stable reference instead.
โญโ[apps/web/src/components/pullRequest/PullRequestListFilters.tsx:387:19]
386 โ onFilters,
387 โ authorOptions = [],
ยท โโ
388 โ labelOptions = [],
โฐโโโโ
help: Default values are re-created on every render and break referential equality, causing unnecessary re-renders. Move the value out of the component or memoize it.
โ react(no-object-type-as-default-prop): Do not use an array literal as default prop value. Use a stable reference instead.
โญโ[apps/web/src/components/pullRequest/PullRequestListFilters.tsx:388:18]
387 โ authorOptions = [],
388 โ labelOptions = [],
ยท โโ
389 โ host,
โฐโโโโ
help: Default values are re-created on every render and break referential equality, causing unnecessary re-renders. Move the value out of the component or memoize it.
โ react(exhaustive-effect-dependencies): Found extra effect dependencies
โญโ[apps/mobile/src/state/use-thread-outbox-drain.ts:1315:5]
1314 โ queuedMessagesByThreadKey,
1315 โ retryTick,
ยท โโโโโฌโโโโ
ยท โฐโโ Unnecessary dependency `retryTick`
1316 โ restoreQueuedMessage,
โฐโโโโ
help: Extra dependencies can cause an effect to fire more often than it should, resulting in performance problems such as excessive renders and side effects
note: React Compiler skipped optimizing this component or hook. Additional guidance: https://react.dev/reference/eslint-plugin-react-hooks/lints/exhaustive-deps
โ eslint(no-control-regex): Unexpected control character
โญโ[apps/mobile/src/features/settings/SettingsProviderAccountsRouteScreen.tsx:220:46]
219 โ <Text selectable className="font-mono text-sm text-foreground">
220 โ {interaction.output.replace(/\x1b\[[0-?]*[ -/]*[@-~]/g, "")}
ยท โโโฌโ
ยท โฐโโ 'U+001B' is a control character.
221 โ </Text>
โฐโโโโ
help: Avoid matching control characters in regular expressions. If intentional, disable this rule for the expression.
โ eslint(no-unused-vars): Variable 'legacyCredentials' is declared but never used. Unused variables should start with a '_'.
โญโ[packages/provider-cursor/src/server/credentialStore.test.ts:15:7]
14 โ
15 โ const legacyCredentials = {
ยท โโโโโโโโโฌโโโโโโโโ
ยท โฐโโ 'legacyCredentials' is declared here
16 โ version: 1 as const,
โฐโโโโ
help: Consider removing this declaration.
โ react(no-array-index-key): Usage of Array index in keys is not allowed
โญโ[apps/web/src/components/pullRequest/PullRequestSummaryTab.tsx:814:17]
813 โ <div
814 โ key={`${index}:${check.name}:${check.url ?? ""}`}
ยท โโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโ
815 โ className="group flex items-center gap-2 rounded-md pr-1 hover:bg-accent/60"
โฐโโโโ
help: Use a unique data-dependent key to avoid unnecessary rerenders
โ react(memo-dependencies): Found extra memoization dependencies
โญโ[apps/mobile/src/features/settings/scheduled-task-editor.tsx:100:85]
99 โ const startEditor = startScheduledTaskEditor;
100 โ const resetEditor = useCallback(() => startEditor(defaultEditor), [defaultEditor, startEditor]);
ยท โโโโโโฌโโโโโ
ยท โฐโโ Unnecessary dependency `startEditor`
101 โ const readEditor = useCallback(
โฐโโโโ
help: Extra dependencies can cause a value to update more often than it should, resulting in performance problems such as excessive renders or effects firing too often
note: React Compiler skipped optimizing this component or hook. Additional guidance: https://react.dev/reference/eslint-plugin-react-hooks/lints/exhaustive-deps
โ react(memo-dependencies): Found extra memoization dependencies
โญโ[apps/mobile/src/features/settings/scheduled-task-editor.tsx:121:7]
120 โ setEditor,
121 โ startEditor,
ยท โโโโโโฌโโโโโ
ยท โฐโโ Unnecessary dependency `startEditor`
122 โ hasChanges,
โฐโโโโ
help: Extra dependencies can cause a value to update more often than it should, resulting in performance problems such as excessive renders or effects firing too often
note: React Compiler skipped optimizing this component or hook. Additional guidance: https://react.dev/reference/eslint-plugin-react-hooks/lints/exhaustive-deps
โ unicorn(require-module-specifiers): Empty import specifier is not allowed
โญโ[packages/contracts/src/rpc.ts:295:8]
294 โ } from "./device.ts";
295 โ import {} from "./previewAutomation.ts";
ยท โโ
296 โ import {
โฐโโโโ
help: Remove empty braces
โ react(set-state-in-effect): Calling setState synchronously within an effect can trigger cascading renders
โญโ[apps/mobile/src/state/use-vcs-action-state.ts:86:5]
83 โ const [nowMs, setNowMs] = useState(() => Date.now());
84 โ useEffect(() => {
ยท โโโโโฌโโโโ
ยท โฐโโ This is the containing effect
85 โ if (!actionState.isRunning) return;
86 โ setNowMs(Date.now());
ยท โโโโโฌโโโ
ยท โฐโโ Avoid calling setState() directly within an effect
87 โ const interval = setInterval(() => setNowMs(Date.now()), 1000);
โฐโโโโ
help: Effects should synchronize React with external systems. Calling setState synchronously inside an effect starts another render and is usually unnecessary. Derive the value during render, initialize state directly, or update it from the event that caused the change. Use an effect only when synchronizing with an external system.
note: React Compiler skipped optimizing this component or hook. Additional guidance: https://react.dev/reference/eslint-plugin-react-hooks/lints/set-state-in-effect
โ eslint(no-unused-vars): Parameter 'stopSessions' is declared but never used. Unused parameters should start with a '_'.
โญโ[packages/provider-cursor/src/server/auth.ts:249:20]
248 โ },
249 โ (effect, flow, stopSessions) =>
ยท โโโโโโโฌโโโโโ
ยท โฐโโ 'stopSessions' is declared here
250 โ effect.pipe(
โฐโโโโ
help: Consider removing this parameter.
โ eslint(no-unused-vars): Identifier 'HostProcess' is imported but never used.
โญโ[apps/server/src/orchestration-v2/ProviderTurnStartService.ts:25:13]
24 โ import * as Schema from "effect/Schema";
25 โ import * as HostProcess from "@t3tools/shared/HostProcess";
ยท โโโโโโฌโโโโโ
ยท โฐโโ 'HostProcess' is imported here
26 โ
โฐโโโโ
help: Consider removing this import.
โ eslint(no-unused-vars): Variable 'serverConfig' is declared but never used. Unused variables should start with a '_'.
โญโ[apps/server/src/orchestration-v2/ProviderTurnStartService.ts:124:11]
123 โ const path = yield* Path.Path;
124 โ const serverConfig = yield* ServerConfig.ServerConfig;
ยท โโโโโโโฌโโโโโ
ยท โฐโโ 'serverConfig' is declared here
125 โ const serverSettings = yield* ServerSettings.ServerSettingsService;
โฐโโโโ
help: Consider removing this declaration.
โ eslint(no-unused-vars): Variable 'serverSettings' is declared but never used. Unused variables should start with a '_'.
โญโ[apps/server/src/orchestration-v2/ProviderTurnStartService.ts:125:11]
124 โ const serverConfig = yield* ServerConfig.ServerConfig;
125 โ const serverSettings = yield* ServerSettings.ServerSettingsService;
ยท โโโโโโโโฌโโโโโโ
ยท โฐโโ 'serverSettings' is declared here
126 โ const gitWorkflow = yield* GitWorkflowService.GitWorkflowService;
โฐโโโโ
help: Consider removing this declaration.
โ react(exhaustive-effect-dependencies): Found extra effect dependencies
โญโ[apps/mobile/src/state/thread-order.ts:29:7]
28 โ getPendingThreadOrder();
29 โ }, [nowMinute, snoozeWakeTick]);
ยท โโโโโฌโโโโ โโโโโโโโฌโโโโโโ
ยท โ โฐโโ Unnecessary dependency `snoozeWakeTick`
ยท โฐโโ Unnecessary dependency `nowMinute`
30 โ return pending;
โฐโโโโ
help: Extra dependencies can cause an effect to fire more often than it should, resulting in performance problems such as excessive renders and side effects
note: React Compiler skipped optimizing this component or hook. Additional guidance: https://react.dev/reference/eslint-plugin-react-hooks/lints/exhaustive-deps
โ t3code(no-inline-schema-compile): Hoist Schema.decodeUnknownSync(...) to module scope: the compiled function is rebuilt on every call. Move it to a module-level const.
โญโ[packages/contracts/src/auth.test.ts:17:12]
16 โ it("decodes legacy review credentials without offering them in new grants", () => {
17 โ expect(Schema.decodeUnknownSync(AuthEnvironmentScopes)(["review:write"])).toEqual([
ยท โโโโโโโโโโโโโโโโโโโโโโโโ
18 โ "review:write",
โฐโโโโ
โ t3code(no-inline-schema-compile): Hoist Schema.decodeUnknownSync(...) to module scope: the compiled function is rebuilt on every call. Move it to a module-level const.
โญโ[packages/contracts/src/auth.test.ts:20:18]
19 โ ]);
20 โ expect(() => Schema.decodeUnknownSync(AuthGrantScopes)(["review:write"])).toThrow();
ยท โโโโโโโโโโโโโโโโโโโโโโโโ
21 โ expect(AuthStandardClientScopes).not.toContain("review:write");
โฐโโโโ
โ t3code(no-inline-schema-compile): Hoist Schema.decodeUnknownSync(...) to module scope: the compiled function is rebuilt on every call. Move it to a module-level const.
โญโ[packages/contracts/src/auth.test.ts:58:21]
57 โ it("ignores unknown response permissions without falling back to broader scopes", () => {
58 โ const session = Schema.decodeUnknownSync(AuthSessionState)({
ยท โโโโโโโโโโโโโโโโโโโโโโโโ
59 โ authenticated: true,
โฐโโโโ
โ eslint(no-unused-vars): Function 'layerClaudeAgentSdkReplayQueryRunner' is declared but never used.
โญโ[apps/server/src/orchestration-v2/Adapters/ClaudeAdapterV2.testkit.ts:960:10]
959 โ
960 โ function layerClaudeAgentSdkReplayQueryRunner(
ยท โโโโโโโโโโโโโโโโโโโฌโโโโโโโโโโโโโโโโโ
ยท โฐโโ 'layerClaudeAgentSdkReplayQueryRunner' is declared here
961 โ transcript: ClaudeAgentSdkReplayTranscript,
โฐโโโโ
help: Consider removing this declaration.
โ unicorn(no-useless-fallback-in-spread): Empty fallbacks in spreads are unnecessary
โญโ[apps/mobile/src/state/use-model-option-memory.ts:21:7]
20 โ [instanceId]: {
21 โ ...(state[instanceId] ?? {}),
ยท โโโโโโโโโโโโโโโโโโโโโโโโโโโโ
22 โ [model]: options,
โฐโโโโ
help: Spreading falsy values in object literals won't add any unexpected properties, so it's unnecessary to add an empty object as fallback.
โ eslint(no-unused-vars): Variable 'layer' is declared but never used. Unused variables should start with a '_'.
โญโ[apps/server/src/orchestration-v2/Adapters/ClaudeAdapterV2.ts:10578:7]
10577 โ
10578 โ const layer: Layer.Layer<
ยท โโโฌโโ
ยท โฐโโ 'layer' is declared here
10579 โ ProviderAdapter.ProviderAdapterV2,
โฐโโโโ
help: Consider removing this declaration.
โ unicorn(prefer-array-find): Prefer `find` over filtering and accessing the first result.
โญโ[apps/server/src/orchestration-v2/Adapters/AcpAdapterV2.test.ts:1998:15]
1997 โ assert.equal(
1998 โ items.filter((item) => item.type === "assistant_message").at(-1)?.text,
ยท โโโโโโ
1999 โ "authoritative answer",
โฐโโโโ
help: Use `find(predicate)` instead of `filter(predicate)[0]` or similar patterns.
โ t3code(no-polling-loop-in-tests): Polling loop in a test. Spinning on `yieldNow`/`sleep` is scheduler- and load-dependent. Await the `Deferred`, `Queue.take`, `Stream` element, `drain()`, or `expect.poll` that marks the milestone.
โญโ[apps/server/src/orchestration-v2/Adapters/AcpAdapterV2.test.ts:3951:7]
3950 โ const closeFiber = yield* Scope.close(sessionScope, Exit.void).pipe(Effect.forkScoped);
3951 โ โญโโถ while (!responseLifecycle.includes("failed")) {
3952 โ โ yield* Effect.yieldNow;
3953 โ โฐโโถ }
3954 โ const responseExit = yield* Fiber.join(responseFiber);
โฐโโโโ
โ t3code(no-polling-loop-in-tests): Polling loop in a test. Spinning on `yieldNow`/`sleep` is scheduler- and load-dependent. Await the `Deferred`, `Queue.take`, `Stream` element, `drain()`, or `expect.poll` that marks the milestone.
โญโ[apps/server/src/orchestration-v2/Adapters/AcpAdapterV2.test.ts:6062:9]
6061 โ .pipe(Effect.forkScoped);
6062 โ โญโโถ while (promptGates.length < 1) {
6063 โ โ yield* Effect.yieldNow;
6064 โ โฐโโถ }
6065 โ assert.isDefined(sessionUpdateHandler, "session update handler must be wired");
โฐโโโโ
โ t3code(no-polling-loop-in-tests): Polling loop in a test. Spinning on `yieldNow`/`sleep` is scheduler- and load-dependent. Await the `Deferred`, `Queue.take`, `Stream` element, `drain()`, or `expect.poll` that marks the milestone.
โญโ[apps/server/src/orchestration-v2/Adapters/AcpAdapterV2.test.ts:6197:9]
6196 โ .pipe(Effect.forkScoped);
6197 โ โญโโถ while (promptGates.length < 2) {
6198 โ โ yield* Effect.yieldNow;
6199 โ โฐโโถ }
6200 โ if (sessionUpdateHandler === undefined || capturedMutation.current === null) {
โฐโโโโ
โ react(immutability): This value cannot be modified
โญโ[apps/mobile/src/features/layout/workspace-inspector-pane.tsx:42:5]
35 โ
36 โ const inspectorProgress = useSharedValue(inspectorVisible ? 1 : 0);
ยท โโโโโโโโโฌโโโโโโโโ
ยท โฐโโ `inspectorProgress` originates here
37 โ const { renderedInspectorWidth } = props;
38 โ const renderedContentWidth = useSharedValue(inspectorWidth ?? 0);
39 โ
40 โ const onClosed = props.onClosed;
41 โ useEffect(() => {
42 โ inspectorProgress.value = withTiming(
ยท โโโโโโโโโฌโโโโโโโโ
ยท โฐโโ `inspectorProgress` cannot be modified
43 โ inspectorVisible ? 1 : 0,
โฐโโโโ
help: Modifying a value returned from a hook is not allowed. Consider moving the modification into the hook where the value is constructed
note: React Compiler skipped optimizing this component or hook. Additional guidance: https://react.dev/reference/eslint-plugin-react-hooks/lints/immutability
โ react(immutability): This value cannot be modified
โญโ[apps/mobile/src/features/layout/workspace-inspector-pane.tsx:67:7]
37 โ const { renderedInspectorWidth } = props;
38 โ const renderedContentWidth = useSharedValue(inspectorWidth ?? 0);
ยท โโโโโโโโโโโฌโโโโโโโโโ
ยท โฐโโ `renderedContentWidth` originates here
39 โ
40 โ const onClosed = props.onClosed;
41 โ useEffect(() => {
42 โ inspectorProgress.value = withTiming(
43 โ inspectorVisible ? 1 : 0,
44 โ WORKSPACE_PANE_TIMING,
45 โ (finished) => {
46 โ if (finished === true && !inspectorVisible && onClosed !== undefined) {
47 โ runOnJS(onClosed)();
48 โ }
49 โ },
50 โ );
51 โ const targetWidth = inspectorVisible ? (inspectorWidth ?? 0) : 0;
52 โ renderedInspectorWidth.set(
53 โ resizing ? targetWidth : withTiming(targetWidth, WORKSPACE_PANE_TIMING),
54 โ );
55 โ }, [
56 โ inspectorProgress,
57 โ inspectorVisible,
58 โ inspectorWidth,
59 โ onClosed,
60 โ renderedInspectorWidth,
61 โ resizing,
62 โ ]);
63 โ
64 โ useEffect(() => {
65 โ const targetWidth = inspectorWidth ?? 0;
66 โ if (!inspectorVisible || resizing) {
67 โ renderedContentWidth.value = targetWidth;
ยท โโโโโโโโโโโฌโโโโโโโโโ
ยท โฐโโ `renderedContentWidth` cannot be modified
68 โ return;
โฐโโโโ
help: Modifying a value returned from a hook is not allowed. Consider moving the modification into the hook where the value is constructed
note: React Compiler skipped optimizing this component or hook. Additional guidance: https://react.dev/reference/eslint-plugin-react-hooks/lints/immutability
โ eslint(no-unused-vars): Variable 'layerCodexAppServerClientFactoryCommand' is declared but never used. Unused variables should start with a '_'.
โญโ[apps/server/src/orchestration-v2/Adapters/CodexAdapterV2.ts:1444:7]
1443 โ
1444 โ const layerCodexAppServerClientFactoryCommand = (
ยท โโโโโโโโโโโโโโโโโโโโฌโโโโโโโโโโโโโโโโโโโ
ยท โฐโโ 'layerCodexAppServerClientFactoryCommand' is declared here
1445 โ options: CodexClient.CodexAppServerClientOptions & {
โฐโโโโ
help: Consider removing this declaration.
โ eslint(no-unused-vars): Variable 'layer' is declared but never used. Unused variables should start with a '_'.
โญโ[apps/server/src/orchestration-v2/Adapters/CodexAdapterV2.ts:1680:7]
1679 โ
1680 โ const layer: Layer.Layer<
ยท โโโฌโโ
ยท โฐโโ 'layer' is declared here
1681 โ ProviderAdapter.ProviderAdapterV2,
โฐโโโโ
help: Consider removing this declaration.
โ t3code(no-inline-schema-compile): Hoist Schema.decodeEffect(...) to module scope: the compiled function is rebuilt on every call. Move it to a module-level const.
โญโ[apps/server/src/vcs/GitVcsDriverCore.test.ts:1786:34]
1785 โ const stat = branch.files!.find((file) => file.path === path)!;
1786 โ const request = yield* Schema.decodeEffect(ReviewDiffPreviewInput)({
ยท โโโโโโโโโโโโโโโโโโโ
1787 โ cwd,
โฐโโโโ
โ react(refs): Cannot access refs during render
โญโ[apps/mobile/src/features/home/thread-swipe-actions.tsx:494:27]
493 โ >
494 โ {props.children(close)}
ยท โโโฌโโ
ยท โฐโโ Cannot access ref value during render
495 โ </ReanimatedSwipeable>
โฐโโโโ
help: React refs are values that are not needed for rendering. Refs should only be accessed outside of render, such as in event handlers or effects. Accessing a ref value (the `current` property) during render can cause your component not to update as expected
note: React Compiler skipped optimizing this component or hook. Additional guidance: https://react.dev/reference/eslint-plugin-react-hooks/lints/refs
โ unicorn(prefer-string-starts-ends-with): Prefer String#startsWith over a regex with a caret.
โญโ[apps/server/src/vcs/GitVcsDriverCore.ts:509:11]
508 โ GIT_DIAGNOSTIC_LINE_PATTERN.test(line) ||
509 โ (!/^remote:/.test(line) && SSH_TRANSPORT_REFUSAL_PATTERN.test(line)),
ยท โโโโโโโโโโโโโโโ
510 โ )
โฐโโโโ
help: Replace `/^remote:/.test(line)` with `line.startsWith('remote:')`.
โ react(exhaustive-effect-dependencies): Found extra effect dependencies
โญโ[apps/mobile/src/features/home/HomeScreen.tsx:542:25]
541 โ // range) the boundary string is identical and the chain would die.
542 โ }, [nextSnoozeWakeAt, snoozeWakeTick]);
ยท โโโโโโโโฌโโโโโโ
ยท โฐโโ Unnecessary dependency `snoozeWakeTick`
543 โ const v2SearchQuery = props.searchQuery.trim().toLocaleLowerCase();
โฐโโโโ
help: Extra dependencies can cause an effect to fire more often than it should, resulting in performance problems such as excessive renders and side effects
note: React Compiler skipped optimizing this component or hook. Additional guidance: https://react.dev/reference/eslint-plugin-react-hooks/lints/exhaustive-deps
โ react(purity): Cannot call impure function during render
โญโ[apps/mobile/src/features/home/HomeScreen.tsx:533:53]
532 โ if (Number.isNaN(wakeAtMs)) return;
533 โ const delayMs = Math.min(Math.max(0, wakeAtMs - Date.now()) + 50, 2_147_483_647);
ยท โโโโโโฌโโโโ
ยท โฐโโ Cannot call impure function
534 โ const id = setTimeout(() => {
โฐโโโโ
help: `Date.now` is an impure function. Calling an impure function can produce unstable results that update unpredictably when the component re-renders
note: React Compiler skipped optimizing this component or hook. Additional guidance: https://react.dev/reference/eslint-plugin-react-hooks/lints/purity
โ eslint(no-empty-pattern): Empty array binding pattern
โญโ[apps/server/src/pullRequest/PullRequestService.test.ts:1475:12]
1474 โ
1475 โ for (const [] of [
ยท โโ
1476 โ ["github", "github.com"],
โฐโโโโ
help: Passing non-iterable values (null, undefined, numbers, booleans, etc.) will result in a runtime error because these values are not iterable.
โ t3code(no-inline-schema-compile): Hoist Schema.is(...) to module scope: both the inline schema literal and the compiled function are rebuilt on every call. Move the compiled function to a module-level const.
โญโ[apps/server/src/provider/acp/AntigravityProtocol.ts:263:20]
262 โ ...(update._meta !== undefined
263 โ ? { _meta: Schema.is(Schema.Record(Schema.String, Schema.Json))(meta) ? meta : null }
ยท โโโโโโโโโ
264 โ : {}),
โฐโโโโ
โ eslint(no-unused-vars): Variable 'layerTest' is declared but never used. Unused variables should start with a '_'.
โญโ[apps/server/src/telemetry/AnalyticsService.ts:340:7]
339 โ
340 โ const layerTest = AnalyticsService.layerTest;
ยท โโโโโฌโโโโ
ยท โฐโโ 'layerTest' is declared here
โฐโโโโ
help: Consider removing this declaration.
โ eslint(no-new): Do not use 'new' for side effects.
โญโ[apps/server/src/mcp/McpToolAccess.test.ts:168:3]
167 โ // @ts-expect-error a declaration constructed directly
168 โ new McpToolAccess.Declaration(unchecked);
ยท โโโโโโโโโโโโโโโโโโโโโโโโโโโโโ
169 โ // @ts-expect-error a handlers layer built outside McpToolAccess
โฐโโโโ
help: Assign the result of 'new' to a variable or compare it to a reference.
โ eslint(no-unused-vars): Type 'AuthSessionState' is imported but never used.
โญโ[packages/client-runtime/src/state/usageAccess.ts:3:8]
2 โ AuthDiagnosticsReadScope,
3 โ type AuthSessionState,
ยท โโโโโโโโโฌโโโโโโโ
ยท โฐโโ 'AuthSessionState' is imported here
4 โ sessionGrantsScope,
โฐโโโโ
help: Consider removing this import.
โ eslint(no-unused-vars): Function 'nonEmptyString' is declared but never used.
โญโ[packages/client-runtime/src/work-log/presentation.ts:234:10]
233 โ
234 โ function nonEmptyString(value: unknown): string | null {
ยท โโโโโโโโฌโโโโโโ
ยท โฐโโ 'nonEmptyString' is declared here
235 โ return typeof value === "string" && value.trim().length > 0 ? value : null;
โฐโโโโ
help: Consider removing this declaration.
โ react(no-array-index-key): Usage of Array index in keys is not allowed
โญโ[apps/mobile/src/features/review/ReviewCommentCard.tsx:223:31]
222 โ ? snippetTokens.map((line, lineIndex) => (
223 โ <NativeText key={lineIndex}>
ยท โโโโโโโโโโโโโโโ
224 โ {lineIndex > 0 ? "\n" : ""}
โฐโโโโ
help: Use a unique data-dependent key to avoid unnecessary rerenders
โ react(no-array-index-key): Usage of Array index in keys is not allowed
โญโ[apps/mobile/src/features/review/ReviewCommentCard.tsx:227:25]
226 โ <NativeText
227 โ key={tokenIndex}
ยท โโโโโโโโโโโโโโโโ
228 โ style={{
โฐโโโโ
help: Use a unique data-dependent key to avoid unnecessary rerenders
โ react(set-state-in-effect): Calling setState synchronously within an effect can trigger cascading renders
โญโ[apps/mobile/src/features/review/useReviewCommentSelectionController.ts:107:5]
104 โ
105 โ useEffect(() => {
ยท โโโโโฌโโโโ
ยท โฐโโ This is the containing effect
106 โ clearReviewCommentTarget();
107 โ setPendingNativeCommentSelection(null);
ยท โโโโโโโโโโโโโโโโโฌโโโโโโโโโโโโโโโ
ยท โฐโโ Avoid calling setState() directly within an effect
108 โ }, [selectedSection?.id]);
โฐโโโโ
help: Effects should synchronize React with external systems. Calling setState synchronously inside an effect starts another render and is usually unnecessary. Derive the value during render, initialize state directly, or update it from the event that caused the change. Use an effect only when synchronizing with an external system.
note: React Compiler skipped optimizing this component or hook. Additional guidance: https://react.dev/reference/eslint-plugin-react-hooks/lints/set-state-in-effect
โ react(set-state-in-effect): Calling setState synchronously within an effect can trigger cascading renders
โญโ[apps/mobile/src/features/review/useReviewCommentSelectionController.ts:112:7]
109 โ
110 โ useEffect(() => {
ยท โโโโโฌโโโโ
ยท โฐโโ This is the containing effect
111 โ if (activeCommentTarget === null) {
112 โ setPendingNativeCommentSelection(null);
ยท โโโโโโโโโโโโโโโโโฌโโโโโโโโโโโโโโโ
ยท โฐโโ Avoid calling setState() directly within an effect
113 โ }
โฐโโโโ
help: Effects should synchronize React with external systems. Calling setState synchronously inside an effect starts another render and is usually unnecessary. Derive the value during render, initialize state directly, or update it from the event that caused the change. Use an effect only when synchronizing with an external system.
note: React Compiler skipped optimizing this component or hook. Additional guidance: https://react.dev/reference/eslint-plugin-react-hooks/lints/set-state-in-effect
โ react(exhaustive-effect-dependencies): Found extra effect dependencies
โญโ[apps/mobile/src/features/review/useReviewCommentSelectionController.ts:108:7]
107 โ setPendingNativeCommentSelection(null);
108 โ }, [selectedSection?.id]);
ยท โโโโโโโโโโฌโโโโโโโโโ
ยท โฐโโ Unnecessary dependency `selectedSection?.id`
109 โ
โฐโโโโ
help: Extra dependencies can cause an effect to fire more often than it should, resulting in performance problems such as excessive renders and side effects
note: React Compiler skipped optimizing this component or hook. Additional guidance: https://react.dev/reference/eslint-plugin-react-hooks/lints/exhaustive-deps
โ react(set-state-in-effect): Calling setState synchronously within an effect can trigger cascading renders
โญโ[apps/mobile/src/features/review/useNativeReviewDiffHighlighting.ts:60:5]
55 โ
56 โ useEffect(() => {
ยท โโโโโฌโโโโ
ยท โฐโโ This is the containing effect
57 โ scheduler.reset();
58 โ highlightedRowIdsRef.current = new Set();
59 โ visibleChunkIndexRef.current = 0;
60 โ setVisibleRange({ firstRowIndex: 0, lastRowIndex: 80 });
ยท โโโโโโโโฌโโโโโโโ
ยท โฐโโ Avoid calling setState() directly within an effect
61 โ setTokensPatchJson(createEmptyTokenPatch(resetKey));
โฐโโโโ
help: Effects should synchronize React with external systems. Calling setState synchronously inside an effect starts another render and is usually unnecessary. Derive the value during render, initialize state directly, or update it from the event that caused the change. Use an effect only when synchronizing with an external system.
note: React Compiler skipped optimizing this component or hook. Additional guidance: https://react.dev/reference/eslint-plugin-react-hooks/lints/set-state-in-effect
โ react(exhaustive-effect-dependencies): Found extra effect dependencies
โญโ[apps/mobile/src/features/review/useNativeReviewDiffHighlighting.ts:63:7]
62 โ return () => scheduler.cancel();
63 โ }, [enabled, resetKey, rows.length, scheduler]);
ยท โโโโฌโโโ โโโโโโฌโโโโโ
ยท โ โฐโโ Unnecessary dependency `rows.length`
ยท โฐโโ Unnecessary dependency `enabled`
64 โ
โฐโโโโ
help: Extra dependencies can cause an effect to fire more often than it should, resulting in performance problems such as excessive renders and side effects
note: React Compiler skipped optimizing this component or hook. Additional guidance: https://react.dev/reference/eslint-plugin-react-hooks/lints/exhaustive-deps
โ react(exhaustive-effect-dependencies): Found extra effect dependencies
โญโ[apps/mobile/src/features/review/ReviewSheet.tsx:454:7]
453 โ showAuxiliaryPane("inspector");
454 โ }, [environmentId, showAuxiliaryPane, threadId]);
ยท โโโโโโโฌโโโโโโ โโโโโฌโโโ
ยท โ โฐโโ Unnecessary dependency `threadId`
ยท โฐโโ Unnecessary dependency `environmentId`
455 โ const {
โฐโโโโ
help: Extra dependencies can cause an effect to fire more often than it should, resulting in performance problems such as excessive renders and side effects
note: React Compiler skipped optimizing this component or hook. Additional guidance: https://react.dev/reference/eslint-plugin-react-hooks/lints/exhaustive-deps
โ react(static-components): Cannot create components during render
โญโ[apps/mobile/src/features/review/ReviewSheet.tsx:725:20]
492 โ // same check.
493 โ const NativeReviewDiffView = resolveNativeReviewDiffView();
ยท โโโโโโโโโโโโโโฌโโโโโโโโโโโโโ
ยท โฐโโ The component is created during render here
494 โ const nativeReviewDiffViewRef = useRef<NativeReviewDiffViewHandle>(null);
495 โ const showcasedReviewDrawRef = useRef<string | null>(null);
496 โ const [isPullRefreshing, setIsPullRefreshing] = useState(false);
497 โ const handlePullToRefresh = async () => {
498 โ setIsPullRefreshing(true);
499 โ await refreshSelectedSection();
500 โ setIsPullRefreshing(false);
501 โ };
502 โ const reviewFileNavigatorRef = useRef<ReviewFileNavigatorHandle>(null);
503 โ const reviewFiles = parsedDiff.kind === "files" ? parsedDiff.files : [];
504 โ const fileVisibility = useReviewFileVisibility({
505 โ threadKey: reviewCache.threadKey,
506 โ sectionId: selectedSection?.id ?? null,
507 โ files: reviewFiles,
508 โ cachedExpandedFileIds: selectedSection?.id
509 โ ? reviewCache.expandedFileIdsBySection[selectedSection.id]
510 โ : undefined,
511 โ cachedViewedFileIds: selectedSection?.id
512 โ ? reviewCache.viewedFileIdsBySection[selectedSection.id]
513 โ : undefined,
514 โ });
515 โ const { collapsedFileIds, toggleExpandedFile, toggleViewedFile, viewedFileIds } = fileVisibility;
516 โ const commentSelection = useReviewCommentSelectionController({
517 โ environmentId,
518 โ threadId,
519 โ selectedSection,
520 โ nativeReviewDiffData,
521 โ });
522 โ const nativeBridge = useNativeReviewDiffBridge({
523 โ threadKey: reviewCache.threadKey,
524 โ sectionId: selectedSection?.id ?? null,
525 โ diff: selectedSection?.diff,
526 โ data: nativeReviewDiffData,
527 โ collapsedFileIds,
528 โ viewedFileIds,
529 โ selectedRowIds: commentSelection.selectedRowIds,
530 โ canHighlight: parsedDiff.kind === "files",
531 โ });
532 โ const showcaseReviewKey =
533 โ SHOWCASE_ENABLED && parsedDiff.kind === "files" && selectedSection
534 โ ? `${reviewCache.threadKey}:${selectedSection.id}:${nativeBridge.tokensResetKey}:${nativeBridge.themeId}`
535 โ : null;
536 โ const handleNativeDebug = (event: NativeSyntheticEvent<Record<string, unknown>>) => {
537 โ nativeBridge.onDebug(event);
538 โ if (
539 โ showcaseReviewKey === null ||
540 โ showcasedReviewDrawRef.current === showcaseReviewKey ||
541 โ !isNativeReviewDiffDrawEvent(event.nativeEvent)
542 โ ) {
543 โ return;
544 โ }
545 โ showcasedReviewDrawRef.current = showcaseReviewKey;
546 โ reportShowcaseSceneRendered({ scene: "review", themeId: nativeBridge.themeId });
547 โ };
548 โ
549 โ const handleSelectFile = async (fileId: string | null) => {
550 โ loadVisibleFile(fileId, true);
551 โ commentSelection.clearSelection();
552 โ if (fileId !== null && collapsedFileIds.includes(fileId)) {
553 โ toggleExpandedFile(fileId);
554 โ }
555 โ const nativeView = nativeReviewDiffViewRef.current;
556 โ if (!nativeView) return;
557 โ const result = await settlePromise(() =>
558 โ fileId === null ? nativeView.scrollToTop(true) : nativeView.scrollToFile(fileId, true),
559 โ );
560 โ if (AsyncResult.isFailure(result)) {
561 โ console.error("[review] Failed to navigate to diff file", squashAtomCommandFailure(result));
562 โ }
563 โ };
564 โ const handleVisibleFileChange = (
565 โ event: NativeSyntheticEvent<{ readonly fileId?: string | null }>,
566 โ ) => {
567 โ loadVisibleFile(event.nativeEvent.fileId ?? null);
568 โ reviewFileNavigatorRef.current?.setVisibleFile(event.nativeEvent.fileId ?? null);
569 โ };
570 โ const renderInspector = () => (
571 โ <ReviewFileNavigator
572 โ ref={reviewFileNavigatorRef}
573 โ files={nativeReviewDiffData.files}
574 โ headerInset={insets.top}
575 โ sectionId={selectedSection?.id ?? null}
576 โ onSelectFile={(fileId) => void handleSelectFile(fileId)}
577 โ />
578 โ );
579 โ
580 โ const handleNativeToggleFile = (event: NativeSyntheticEvent<{ readonly fileId?: string }>) => {
581 โ const { fileId } = event.nativeEvent;
582 โ if (fileId) {
583 โ loadVisibleFile(fileId, true);
584 โ toggleExpandedFile(fileId);
585 โ }
586 โ };
587 โ
588 โ const handleNativeToggleViewedFile = (
589 โ event: NativeSyntheticEvent<{ readonly fileId?: string }>,
590 โ ) => {
591 โ const { fileId } = event.nativeEvent;
592 โ if (fileId) {
593 โ toggleViewedFile(fileId);
594 โ }
595 โ };
596 โ
597 โ const parsedDiffNotice =
598 โ parsedDiff.kind === "files" || parsedDiff.kind === "raw" ? parsedDiff.notice : null;
599 โ const hasCachedSelectedDiff = selectedSection?.diff != null;
600 โ const hasAnyCachedDiff = reviewSections.some((section) => section.diff != null);
601 โ const sectionMenu = buildReviewSectionMenu(reviewSections);
602 โ const { showConnectionNotice, showSectionToolbar } = resolveReviewAvailability({
603 โ hasEnvironmentPresentation: environment.isReady,
604 โ isEnvironmentConnected: isEnvironmentReady,
605 โ hasCachedSelectedDiff,
606 โ hasAnyCachedDiff,
607 โ });
608 โ const handleRetryEnvironment = () => {
609 โ void retryEnvironment(environmentId);
610 โ };
611 โ const handleReturnToThread = () => {
612 โ if (navigation.canGoBack()) {
613 โ navigation.goBack();
614 โ return;
615 โ }
616 โ navigation.navigate("Thread", {
617 โ environmentId: String(environmentId),
618 โ threadId: String(threadId),
619 โ });
620 โ };
621 โ const androidHeaderSubtitle = [
622 โ selectedSection?.title,
623 โ headerDiffSummary.additions,
624 โ headerDiffSummary.deletions,
625 โ ]
626 โ .filter((part): part is string => Boolean(part))
627 โ .join(" ยท ");
628 โ
629 โ const showChangedFilesPane =
630 โ !showConnectionNotice &&
631 โ selectedSection !== null &&
632 โ parsedDiff.kind === "files" &&
633 โ NativeReviewDiffView !== null;
634 โ useRegisterWorkspaceInspector(showChangedFilesPane ? renderInspector : undefined);
635 โ const showChangedFilesToggle = panes.supportsAuxiliaryPane && showChangedFilesPane;
636 โ
637 โ const listHeader = (() => {
638 โ const children: ReactElement[] = [];
639 โ
640 โ if (error) {
641 โ children.push(
642 โ <View
643 โ key="review-error"
644 โ className={cn(
645 โ "bg-card px-4 py-3",
646 โ Platform.OS === "android" ? "m-2 rounded-[20px]" : "border-b border-border",
647 โ )}
648 โ >
649 โ <Text className="text-sm font-t3-bold text-foreground">Review unavailable</Text>
650 โ <Text className="text-xs leading-normal text-foreground-muted">{error}</Text>
651 โ </View>,
652 โ );
653 โ }
654 โ
655 โ if (parsedDiffNotice) {
656 โ children.push(<ReviewNotice key="review-notice" notice={parsedDiffNotice} />);
657 โ }
658 โ
659 โ if (children.length === 0) {
660 โ return null;
661 โ }
662 โ
663 โ return <>{children}</>;
664 โ })();
665 โ const headerSubtitle = [
666 โ headerDiffSummary.additions,
667 โ headerDiffSummary.deletions,
668 โ pendingReviewCommentCount > 0
669 โ ? `${pendingReviewCommentCount} comment${pendingReviewCommentCount === 1 ? "" : "s"}`
670 โ : null,
671 โ ]
672 โ .filter(Boolean)
673 โ .join(" ยท ");
674 โ const headerTitleText = selectedSection?.title ?? "Review changes";
675 โ
676 โ return (
677 โ <>
678 โ <ReviewHeader
679 โ environmentId={environmentId}
680 โ threadId={threadId}
681 โ title={headerTitleText}
682 โ subtitle={headerSubtitle}
683 โ androidSubtitle={androidHeaderSubtitle}
684 โ iconColor={headerIcon}
685 โ selectedThreadCwd={selectedThreadCwd}
686 โ sectionMenu={sectionMenu}
687 โ selectedSection={selectedSection}
688 โ showSectionToolbar={showSectionToolbar}
689 โ showChangedFilesToggle={showChangedFilesToggle}
690 โ onRefresh={handlePullToRefresh}
691 โ onSelectSection={selectSection}
692 โ onReturnToThread={handleReturnToThread}
693 โ />
694 โ
695 โ <ScreenContent>
696 โ <View className="flex-1 bg-sheet android:bg-sheet-solid">
697 โ {showConnectionNotice ? (
698 โ <View className="flex-1" style={{ paddingTop: topContentInset }}>
699 โ <EnvironmentConnectionNotice
700 โ environmentLabel={environment.presentation?.entry.target.label ?? "Environment"}
701 โ connection={
702 โ environment.presentation?.connection ?? {
703 โ phase: "available",
704 โ error: null,
705 โ traceId: null,
706 โ }
707 โ }
708 โ resourceName="review"
709 โ onRetry={handleRetryEnvironment}
710 โ />
711 โ </View>
712 โ ) : selectedSection && parsedDiff.kind === "files" && NativeReviewDiffView ? (
713 โ <View
714 โ className="flex-1"
715 โ style={{
716 โ backgroundColor: nativeBridge.theme.background,
717 โ }}
718 โ >
719 โ <View
720 โ className="min-w-0 flex-1"
721 โ style={listHeader ? { paddingTop: topContentInset } : undefined}
722 โ >
723 โ {listHeader}
724 โ <View className="min-w-0 flex-1" collapsable={false}>
725 โ <NativeReviewDiffView
ยท โโโโโโโโโโโฌโโโโโโโโโ
ยท โฐโโ This component is created during render
726 โ collapsable={false}
โฐโโโโ
help: Components created during render will reset their state each time they are created. Declare components outside of render
note: React Compiler skipped optimizing this component or hook. Additional guidance: https://react.dev/reference/eslint-plugin-react-hooks/lints/static-components
โ eslint(no-empty-pattern): Empty object binding pattern
โญโ[apps/server/src/provider/Drivers/CodexDriver.test.ts:466:14]
465 โ
466 โ for (const {} of ["direct", "wrapper"] as const) {
ยท โโ
467 โ }
โฐโโโโ
help: Passing `null` or `undefined` will result in runtime error because `null` and `undefined` cannot be destructured.
โ eslint(no-unused-vars): Identifier 'Arr' is imported but never used.
โญโ[packages/client-runtime/src/state/threadSort.ts:4:13]
3 โ import type { EnvironmentThreadShell } from "./models.ts";
4 โ import * as Arr from "effect/Array";
ยท โโฌโ
ยท โฐโโ 'Arr' is imported here
5 โ import * as Order from "effect/Order";
โฐโโโโ
help: Consider removing this import.
โ eslint(no-unused-vars): Identifier 'Order' is imported but never used.
โญโ[packages/client-runtime/src/state/threadSort.ts:5:13]
4 โ import * as Arr from "effect/Array";
5 โ import * as Order from "effect/Order";
ยท โโโฌโโ
ยท โฐโโ 'Order' is imported here
6 โ
โฐโโโโ
help: Consider removing this import.
โ react(set-state-in-effect): Calling setState synchronously within an effect can trigger cascading renders
โญโ[apps/mobile/src/features/review/ReviewCommentComposerSheet.tsx:103:7]
100 โ
101 โ useEffect(() => {
ยท โโโโโฌโโโโ
ยท โฐโโ This is the containing effect
102 โ if (!target || selectedLines.length === 0) {
103 โ setHighlightedLinesById({});
ยท โโโโโโโโโโโโฌโโโโโโโโโโโ
ยท โฐโโ Avoid calling setState() directly within an effect
104 โ return;
โฐโโโโ
help: Effects should synchronize React with external systems. Calling setState synchronously inside an effect starts another render and is usually unnecessary. Derive the value during render, initialize state directly, or update it from the event that caused the change. Use an effect only when synchronizing with an external system.
note: React Compiler skipped optimizing this component or hook. Additional guidance: https://react.dev/reference/eslint-plugin-react-hooks/lints/set-state-in-effect
โ react(set-state-in-effect): Calling setState synchronously within an effect can trigger cascading renders
โญโ[apps/mobile/src/features/terminal/ThreadTerminalRouteScreen.tsx:643:5]
638 โ
639 โ useEffect(() => {
ยท โโโโโฌโโโโ
ยท โฐโโ This is the containing effect
640 โ if (pendingLaunchEntry.key === launchTargetKey) {
641 โ return;
642 โ }
643 โ setPendingLaunchEntry({
ยท โโโโโโโโโโโฌโโโโโโโโโโ
ยท โฐโโ Avoid calling setState() directly within an effect
644 โ key: launchTargetKey,
โฐโโโโ
help: Effects should synchronize React with external systems. Calling setState synchronously inside an effect starts another render and is usually unnecessary. Derive the value during render, initialize state directly, or update it from the event that caused the change. Use an effect only when synchronizing with an external system.
note: React Compiler skipped optimizing this component or hook. Additional guidance: https://react.dev/reference/eslint-plugin-react-hooks/lints/set-state-in-effect
โ react(set-state-in-effect): Calling setState synchronously within an effect can trigger cascading renders
โญโ[apps/mobile/src/features/terminal/ThreadTerminalRouteScreen.tsx:653:5]
648 โ
649 โ useEffect(() => {
ยท โโโโโฌโโโโ
ยท โฐโโ This is the containing effect
650 โ if (initialAttachGridEntry.key === launchTargetKey) {
651 โ return;
652 โ }
653 โ setInitialAttachGridEntry({
ยท โโโโโโโโโโโโโฌโโโโโโโโโโโโ
ยท โฐโโ Avoid calling setState() directly within an effect
654 โ key: launchTargetKey,
โฐโโโโ
help: Effects should synchronize React with external systems. Calling setState synchronously inside an effect starts another render and is usually unnecessary. Derive the value during render, initialize state directly, or update it from the event that caused the change. Use an effect only when synchronizing with an external system.
note: React Compiler skipped optimizing this component or hook. Additional guidance: https://react.dev/reference/eslint-plugin-react-hooks/lints/set-state-in-effect
โ react(set-state-in-effect): Calling setState synchronously within an effect can trigger cascading renders
โญโ[apps/mobile/src/features/terminal/ThreadTerminalRouteScreen.tsx:746:7]
743 โ
744 โ useEffect(() => {
ยท โโโโโฌโโโโ
ยท โฐโโ This is the containing effect
745 โ if (!routeEnvironmentId || !routeThreadId) {
746 โ setLastGridSize({
ยท โโโโโโโโฌโโโโโโโ
ยท โฐโโ Avoid calling setState() directly within an effect
747 โ cols: DEFAULT_TERMINAL_COLS,
โฐโโโโ
help: Effects should synchronize React with external systems. Calling setState synchronously inside an effect starts another render and is usually unnecessary. Derive the value during render, initialize state directly, or update it from the event that caused the change. Use an effect only when synchronizing with an external system.
note: React Compiler skipped optimizing this component or hook. Additional guidance: https://react.dev/reference/eslint-plugin-react-hooks/lints/set-state-in-effect
โ react(exhaustive-effect-dependencies): Found extra effect dependencies
โญโ[apps/mobile/src/features/terminal/ThreadTerminalRouteScreen.tsx:538:24]
537 โ });
538 โ }, [terminal.buffer, terminal.buffer.length, terminalKey]);
ยท โโโโโโโโโโโโฌโโโโโโโโโโ
ยท โฐโโ Overly precise dependency `terminal.buffer.length`, use `terminal.buffer` instead
539 โ const cwd = terminal.summary?.cwd ?? selectedThreadProject?.workspaceRoot ?? null;
โฐโโโโ
help: Extra dependencies can cause an effect to fire more often than it should, resulting in performance problems such as excessive renders and side effects
note: React Compiler skipped optimizing this component or hook. Additional guidance: https://react.dev/reference/eslint-plugin-react-hooks/lints/exhaustive-deps
โ react(exhaustive-effect-dependencies): Found extra effect dependencies
โญโ[apps/mobile/src/features/terminal/ThreadTerminalRouteScreen.tsx:709:7]
708 โ sentInitialInputKeyRef.current = null;
709 โ }, [terminalKey]);
ยท โโโโโโฌโโโโโ
ยท โฐโโ Unnecessary dependency `terminalKey`
710 โ
โฐโโโโ
help: Extra dependencies can cause an effect to fire more often than it should, resulting in performance problems such as excessive renders and side effects
note: React Compiler skipped optimizing this component or hook. Additional guidance: https://react.dev/reference/eslint-plugin-react-hooks/lints/exhaustive-deps
โ react(exhaustive-effect-dependencies): Found extra effect dependencies
โญโ[apps/mobile/src/features/terminal/ThreadTerminalRouteScreen.tsx:800:52]
799 โ };
800 โ }, [canOperateTerminal, isRunning, pasteSession, terminal.lifecycleVersion, terminalKey]);
ยท โโโโโโโโโโโโโฌโโโโโโโโโโโโ โโโโโโฌโโโโโ
ยท โ โฐโโ Unnecessary dependency `terminalKey`
ยท โฐโโ Unnecessary dependency `terminal.lifecycleVersion`
801 โ
โฐโโโโ
help: Extra dependencies can cause an effect to fire more often than it should, resulting in performance problems such as excessive renders and side effects
note: React Compiler skipped optimizing this component or hook. Additional guidance: https://react.dev/reference/eslint-plugin-react-hooks/lints/exhaustive-deps
โ react(refs): Cannot access refs during render
โญโ[apps/mobile/src/features/terminal/ThreadTerminalRouteScreen.tsx:793:24]
792 โ }
793 โ const pasteSession = pasteSessionRef.current;
ยท โโโโโโโโโโโโฌโโโโโโโโโโโ
ยท โฐโโ Cannot access ref value during render
794 โ
โฐโโโโ
help: React refs are values that are not needed for rendering. Refs should only be accessed outside of render, such as in event handlers or effects. Accessing a ref value (the `current` property) during render can cause your component not to update as expected
note: React Compiler skipped optimizing this component or hook. Additional guidance: https://react.dev/reference/eslint-plugin-react-hooks/lints/refs
โ react(set-state-in-effect): Calling setState synchronously within an effect can trigger cascading renders
โญโ[apps/mobile/src/features/terminal/terminalLaunchContext.ts:117:5]
112 โ const [entry, setEntry] = useState(() => ({ key: input.targetKey, location: candidate }));
113 โ useEffect(() => {
ยท โโโโโฌโโโโ
ยท โฐโโ This is the containing effect
114 โ if (entry.key === input.targetKey && (entry.location !== null || candidate === null)) {
115 โ return;
116 โ }
117 โ setEntry({ key: input.targetKey, location: candidate });
ยท โโโโโฌโโโ
ยท โฐโโ Avoid calling setState() directly within an effect
118 โ }, [candidate, entry.key, entry.location, input.targetKey]);
โฐโโโโ
help: Effects should synchronize React with external systems. Calling setState synchronously inside an effect starts another render and is usually unnecessary. Derive the value during render, initialize state directly, or update it from the event that caused the change. Use an effect only when synchronizing with an external system.
note: React Compiler skipped optimizing this component or hook. Additional guidance: https://react.dev/reference/eslint-plugin-react-hooks/lints/set-state-in-effect
โ react(no-array-index-key): Usage of Array index in keys is not allowed
โญโ[apps/mobile/src/features/terminal/TerminalContextSheet.tsx:72:15]
71 โ <Pressable
72 โ key={index}
ยท โโโโโโโโโโโ
73 โ accessibilityRole="button"
โฐโโโโ
help: Use a unique data-dependent key to avoid unnecessary rerenders
โ react(static-components): Cannot create components during render
โญโ[apps/mobile/src/features/terminal/NativeTerminalSurface.tsx:234:10]
196 โ const { onInput, onResize } = props;
197 โ const NativeTerminalSurfaceView = resolveNativeTerminalSurfaceView();
ยท โโโโโโโโโโโโโโโโโฌโโโโโโโโโโโโโโโ
ยท โฐโโ The component is created during render here
198 โ const hasNativeSurface = Boolean(NativeTerminalSurfaceView);
199 โ
200 โ useEffect(() => {
201 โ terminalDebugLog("native:surface", {
202 โ terminalKey: props.terminalKey,
203 โ native: hasNativeSurface,
204 โ hardwareKeyRevision: getNativeTerminalHardwareKeyRevision(),
205 โ bufferLen: props.buffer.length,
206 โ isRunning: props.isRunning,
207 โ });
208 โ }, [hasNativeSurface, props.buffer.length, props.isRunning, props.terminalKey]);
209 โ const handleNativeInput = useCallback(
210 โ (event: NativeSyntheticEvent<TerminalInputEvent>) => {
211 โ if (!props.isRunning || props.readOnly) {
212 โ return;
213 โ }
214 โ terminalDebugLog("native:onInput", {
215 โ codes: Array.from(event.nativeEvent.data, (char) => char.codePointAt(0)),
216 โ });
217 โ onInput(event.nativeEvent.data);
218 โ },
219 โ [onInput, props.isRunning, props.readOnly],
220 โ );
221 โ const handleNativeResize = useCallback(
222 โ (event: NativeSyntheticEvent<TerminalResizeEvent>) => {
223 โ onResize({
224 โ cols: event.nativeEvent.cols,
225 โ rows: event.nativeEvent.rows,
226 โ });
227 โ },
228 โ [onResize],
229 โ );
230 โ
231 โ if (NativeTerminalSurfaceView) {
232 โ return (
233 โ <View style={props.style}>
234 โ <NativeTerminalSurfaceView
ยท โโโโโโโโโโโโโฌโโโโโโโโโโโโ
ยท โฐโโ This component is created during render
235 โ appearanceScheme={themeAppearance}
โฐโโโโ
help: Components created during render will reset their state each time they are created. Declare components outside of render
note: React Compiler skipped optimizing this component or hook. Additional guidance: https://react.dev/reference/eslint-plugin-react-hooks/lints/static-components
โ eslint(no-unused-vars): Type 'EnvironmentId' is imported but never used.
โญโ[packages/client-runtime/src/state/sharedSettings.ts:2:3]
1 โ import type {
2 โ EnvironmentId,
ยท โโโโโโโฌโโโโโโ
ยท โฐโโ 'EnvironmentId' is imported here
3 โ ExecutionEnvironmentCapabilities,
โฐโโโโ
help: Consider removing this import.
โ eslint(no-unused-vars): Parameter 'stopSessions' is declared but never used. Unused parameters should start with a '_'.
โญโ[apps/server/src/provider/AntigravityAuth.ts:285:20]
284 โ },
285 โ (effect, flow, stopSessions) =>
ยท โโโโโโโฌโโโโโ
ยท โฐโโ 'stopSessions' is declared here
286 โ effect.pipe(
โฐโโโโ
help: Consider removing this parameter.
โ eslint(no-unused-vars): Type 'Scope' is imported but never used.
โญโ[apps/server/src/provider/ProviderAuthService.ts:15:18]
14 โ import * as Layer from "effect/Layer";
15 โ import type * as Scope from "effect/Scope";
ยท โโโฌโโ
ยท โฐโโ 'Scope' is imported here
16 โ import * as Stream from "effect/Stream";
โฐโโโโ
help: Consider removing this import.
โ react(set-state-in-effect): Calling setState synchronously within an effect can trigger cascading renders
โญโ[apps/mobile/src/features/showcase/ShowcaseCaptureCoordinator.tsx:123:7]
118 โ
119 โ useEffect(() => {
ยท โโโโโฌโโโโ
ยท โฐโโ This is the containing effect
120 โ if (orientationSettled) return;
121 โ const orientation = getNativeShowcaseOrientation();
122 โ if (orientation === null) {
123 โ setOrientationSettled(true);
ยท โโโโโโโโโโโฌโโโโโโโโโโ
ยท โฐโโ Avoid calling setState() directly within an effect
124 โ return;
โฐโโโโ
help: Effects should synchronize React with external systems. Calling setState synchronously inside an effect starts another render and is usually unnecessary. Derive the value during render, initialize state directly, or update it from the event that caused the change. Use an effect only when synchronizing with an external system.
note: React Compiler skipped optimizing this component or hook. Additional guidance: https://react.dev/reference/eslint-plugin-react-hooks/lints/set-state-in-effect
โ react(set-state-in-effect): Calling setState synchronously within an effect can trigger cascading renders
โญโ[apps/mobile/src/features/showcase/ShowcaseCaptureCoordinator.tsx:304:7]
292 โ
293 โ useEffect(() => {
ยท โโโโโฌโโโโ
ยท โฐโโ This is the containing effect
294 โ if (
295 โ scene === null ||
296 โ requestedScene === null ||
297 โ scene !== requestedScene ||
298 โ !hasFixture ||
299 โ !orientationSettled ||
300 โ !themeApplied ||
301 โ (scene === "agent-activity" && !agentActivityStaged) ||
302 โ !isShowcaseNativeContentReady({ scene, themeId, renderSignal })
303 โ ) {
304 โ setReadyScene(null);
ยท โโโโโโโฌโโโโโโ
ยท โฐโโ Avoid calling setState() directly within an effect
305 โ return;
โฐโโโโ
help: Effects should synchronize React with external systems. Calling setState synchronously inside an effect starts another render and is usually unnecessary. Derive the value during render, initialize state directly, or update it from the event that caused the change. Use an effect only when synchronizing with an external system.
note: React Compiler skipped optimizing this component or hook. Additional guidance: https://react.dev/reference/eslint-plugin-react-hooks/lints/set-state-in-effect
โ eslint(no-unused-vars): Variable 'lastOutcome' is declared but never used. Unused variables should start with a '_'.
โญโ[apps/mobile/src/features/showcase/ShowcaseCaptureCoordinator.tsx:128:9]
127 โ let cancelled = false;
128 โ let lastOutcome: string | null = null;
ยท โโโโโโฌโโโโโ
ยท โฐโโ 'lastOutcome' is declared here
129 โ void retryShowcaseOperation(async () => applyNativeShowcaseOrientation(orientation), {
โฐโโโโ
help: Consider removing this declaration.
โ react(set-state-in-effect): Calling setState synchronously within an effect can trigger cascading renders
โญโ[apps/mobile/src/features/settings/SettingsNotificationsRouteScreen.tsx:119:10]
117 โ
118 โ useEffect(() => {
ยท โโโโโฌโโโโ
ยท โฐโโ This is the containing effect
119 โ void refreshNotifications();
ยท โโโโโโโโโโโฌโโโโโโโโโ
ยท โฐโโ Avoid calling setState() directly within an effect
120 โ const subscription = AppState.addEventListener("change", (state) => {
โฐโโโโ
help: Effects should synchronize React with external systems. Calling setState synchronously inside an effect starts another render and is usually unnecessary. Derive the value during render, initialize state directly, or update it from the event that caused the change. Use an effect only when synchronizing with an external system.
note: React Compiler skipped optimizing this component or hook. Additional guidance: https://react.dev/reference/eslint-plugin-react-hooks/lints/set-state-in-effect
โ react(set-state-in-effect): Calling setState synchronously within an effect can trigger cascading renders
โญโ[apps/mobile/src/features/settings/SettingsNotificationsRouteScreen.tsx:128:7]
125 โ
126 โ useEffect(() => {
ยท โโโโโฌโโโโ
ยท โฐโโ This is the containing effect
127 โ if (!isLoaded) {
128 โ setLiveActivityStatus("checking");
ยท โโโโโโโโโโโฌโโโโโโโโโโ
ยท โฐโโ Avoid calling setState() directly within an effect
129 โ return;
โฐโโโโ
help: Effects should synchronize React with external systems. Calling setState synchronously inside an effect starts another render and is usually unnecessary. Derive the value during render, initialize state directly, or update it from the event that caused the change. Use an effect only when synchronizing with an external system.
note: React Compiler skipped optimizing this component or hook. Additional guidance: https://react.dev/reference/eslint-plugin-react-hooks/lints/set-state-in-effect
โ t3code(no-polling-loop-in-tests): Polling loop in a test. Spinning on `yieldNow`/`sleep` is scheduler- and load-dependent. Await the `Deferred`, `Queue.take`, `Stream` element, `drain()`, or `expect.poll` that marks the milestone.
โญโ[packages/client-runtime/src/rpc/client.test.ts:131:9]
130 โ ) {
131 โ โญโโถ for (let attempt = 0; attempt < 100; attempt += 1) {
132 โ โ if (subscriptions.length >= count) {
133 โ โ return;
134 โ โ }
135 โ โ yield* Effect.yieldNow;
136 โ โฐโโถ }
137 โ return yield* Effect.die(new Error(`Expected ${count} durable subscriptions.`));
โฐโโโโ
โ t3code(no-polling-loop-in-tests): Polling loop in a test. Spinning on `yieldNow`/`sleep` is scheduler- and load-dependent. Await the `Deferred`, `Queue.take`, `Stream` element, `drain()`, or `expect.poll` that marks the milestone.
โญโ[packages/client-runtime/src/rpc/client.test.ts:252:7]
251 โ yield* SubscriptionRef.set(activeSession, Option.some(session(firstClient)));
252 โ โญโโถ for (let attempt = 0; attempt < 100 && subscriptions.length < 1; attempt += 1) {
253 โ โ yield* Effect.yieldNow;
254 โ โฐโโถ }
255 โ yield* SubscriptionRef.set(activeSession, Option.none());
โฐโโโโ
โ t3code(no-polling-loop-in-tests): Polling loop in a test. Spinning on `yieldNow`/`sleep` is scheduler- and load-dependent. Await the `Deferred`, `Queue.take`, `Stream` element, `drain()`, or `expect.poll` that marks the milestone.
โญโ[packages/client-runtime/src/rpc/client.test.ts:258:7]
257 โ
258 โ โญโโถ for (let attempt = 0; attempt < 100 && subscriptions.length < 2; attempt += 1) {
259 โ โ yield* Effect.yieldNow;
260 โ โฐโโถ }
261 โ yield* Fiber.interrupt(subscriptionFiber);
โฐโโโโ
โ t3code(no-polling-loop-in-tests): Polling loop in a test. Spinning on `yieldNow`/`sleep` is scheduler- and load-dependent. Await the `Deferred`, `Queue.take`, `Stream` element, `drain()`, or `expect.poll` that marks the milestone.
โญโ[packages/client-runtime/src/rpc/client.test.ts:322:7]
321 โ );
322 โ โญโโถ for (let attempt = 0; attempt < 100 && observedFailures.length < 1; attempt += 1) {
323 โ โ yield* Effect.yieldNow;
324 โ โฐโโถ }
325 โ
โฐโโโโ
โ t3code(no-polling-loop-in-tests): Polling loop in a test. Spinning on `yieldNow`/`sleep` is scheduler- and load-dependent. Await the `Deferred`, `Queue.take`, `Stream` element, `drain()`, or `expect.poll` that marks the milestone.
โญโ[packages/client-runtime/src/rpc/client.test.ts:330:7]
329 โ yield* SubscriptionRef.set(activeSession, Option.some(session(secondClient)));
330 โ โญโโถ for (let attempt = 0; attempt < 100 && subscriptions.length < 2; attempt += 1) {
331 โ โ yield* Effect.yieldNow;
332 โ โฐโโถ }
333 โ yield* Fiber.interrupt(subscriptionFiber);
โฐโโโโ
โ t3code(no-polling-loop-in-tests): Polling loop in a test. Spinning on `yieldNow`/`sleep` is scheduler- and load-dependent. Await the `Deferred`, `Queue.take`, `Stream` element, `drain()`, or `expect.poll` that marks the milestone.
โญโ[packages/client-runtime/src/rpc/session.test.ts:226:3]
225 โ ) {
226 โ โญโโถ for (let attempt = 0; attempt < 100; attempt += 1) {
227 โ โ const socket = sockets[index];
228 โ โ if (socket) {
229 โ โ return socket;
230 โ โ }
231 โ โ yield* Effect.yieldNow;
232 โ โฐโโถ }
233 โ return yield* Effect.die(new Error("Expected the RPC protocol to create a websocket."));
โฐโโโโ
โ t3code(no-polling-loop-in-tests): Polling loop in a test. Spinning on `yieldNow`/`sleep` is scheduler- and load-dependent. Await the `Deferred`, `Queue.take`, `Stream` element, `drain()`, or `expect.poll` that marks the milestone.
โญโ[packages/client-runtime/src/rpc/session.test.ts:240:3]
239 โ ) {
240 โ โญโโถ for (let attempt = 0; attempt < 100; attempt += 1) {
241 โ โ const request = socket.sent.map((message) => decodeJson(message)).filter(isRpcRequest)[index];
242 โ โ if (request) {
243 โ โ return request;
244 โ โ }
245 โ โ yield* Effect.yieldNow;
246 โ โฐโโถ }
247 โ return yield* Effect.die(new Error("Expected the RPC protocol to send a request."));
โฐโโโโ
โ unicorn(prefer-array-find): Prefer `find` over filtering and accessing the first result.
โญโ[packages/client-runtime/src/operations/projects.ts:228:51]
227 โ ): string {
228 โ const folderName = workspaceRoot.split(/[\\/]/).filter(Boolean).at(-1) ?? "";
ยท โโโโโโ
229 โ return target.owner ? `${target.owner}/${folderName}` : folderName;
โฐโโโโ
help: Use `find(predicate)` instead of `filter(predicate)[0]` or similar patterns.
โ t3code(no-polling-loop-in-tests): Polling loop in a test. Spinning on `yieldNow`/`sleep` is scheduler- and load-dependent. Await the `Deferred`, `Queue.take`, `Stream` element, `drain()`, or `expect.poll` that marks the milestone.
โญโ[apps/mobile/src/features/agent-awareness/remoteRegistration.test.ts:223:5]
222 โ let idlePasses = 0;
223 โ โญโโถ for (;;) {
224 โ โ yield* Effect.promise(() => Promise.resolve());
225 โ โ const pending = backgroundRuntime.pending.shift();
226 โ โ if (!pending) {
227 โ โ idlePasses++;
228 โ โ if (idlePasses >= 3) {
229 โ โ return;
230 โ โ }
231 โ โ continue;
232 โ โ }
233 โ โ idlePasses = 0;
234 โ โ const exit = yield* Effect.exit(
235 โ โ pending.operation as Effect.Effect<unknown, unknown, ManagedRelay.ManagedRelayClient>,
236 โ โ );
237 โ โ yield* Effect.sync(() => {
238 โ โ pending.resolve(exit);
239 โ โ });
240 โ โฐโโถ }
241 โ },
โฐโโโโ
โ eslint(no-unused-vars): Variable 'layer' is declared but never used. Unused variables should start with a '_'.
โญโ[apps/server/src/orchestration-v2/ThreadPullRequestService.ts:408:7]
407 โ
408 โ const layer = Layer.effect(ThreadPullRequestServiceV2, make);
ยท โโโฌโโ
ยท โฐโโ 'layer' is declared here
โฐโโโโ
help: Consider removing this declaration.
โ react(exhaustive-effect-dependencies): Found extra effect dependencies
โญโ[apps/mobile/src/features/layout/AdaptiveWorkspaceLayout.tsx:215:7]
214 โ }
215 โ }, [wrappedRender]);
ยท โโโโโโโฌโโโโโโ
ยท โฐโโ Unnecessary dependency `wrappedRender`
216 โ
โฐโโโโ
help: Extra dependencies can cause an effect to fire more often than it should, resulting in performance problems such as excessive renders and side effects
note: React Compiler skipped optimizing this component or hook. Additional guidance: https://react.dev/reference/eslint-plugin-react-hooks/lints/exhaustive-deps
โ react(jsx-no-constructed-context-values): The Context `value` prop should not be constructed.
โญโ[apps/mobile/src/features/layout/AdaptiveWorkspaceLayout.tsx:817:35]
816 โ >
817 โ <AdaptiveWorkspaceContext value={contextValue}>
ยท โโโโโโโโโโโโโโโโโโโโ
818 โ <NativeWorkspaceInspectorContext
โฐโโโโ
help: Wrap the `value` prop in useMemo() or useCallback(), or use a constant value to prevent unnecessary re-renders.
Alternatively, move the value outside the render function if it doesn't depend on props or state.
โ react(jsx-no-constructed-context-values): The Context `value` prop should not be constructed.
โญโ[apps/mobile/src/features/layout/AdaptiveWorkspaceLayout.tsx:832:42]
831 โ >
832 โ <AdaptiveWorkspaceContext.Provider value={contextValue}>
ยท โโโโโโโโโโโโโโโโโโโโ
833 โ <WindowHingeContext value={windowHinge}>
โฐโโโโ
help: Wrap the `value` prop in useMemo() or useCallback(), or use a constant value to prevent unnecessary re-renders.
Alternatively, move the value outside the render function if it doesn't depend on props or state.
โ eslint(no-unused-vars): Variable 'layerTest' is declared but never used. Unused variables should start with a '_'.
โญโ[apps/server/src/usage/UsageService.ts:169:7]
168 โ
169 โ const layerTest = Layer.succeed(
ยท โโโโโฌโโโโ
ยท โฐโโ 'layerTest' is declared here
170 โ UsageService,
โฐโโโโ
help: Consider removing this declaration.
โ eslint(no-unused-vars): Variable 'layerDaemon' is declared but never used. Unused variables should start with a '_'.
โญโ[apps/server/src/orchestration-v2/EffectWorker.ts:914:7]
913 โ
914 โ const layerDaemon: Layer.Layer<never, never, OrchestrationEffectWorkerV2> = Layer.effectDiscard(
ยท โโโโโโฌโโโโโ
ยท โฐโโ 'layerDaemon' is declared here
915 โ runDaemon.pipe(Effect.forkScoped),
โฐโโโโ
help: Consider removing this declaration.
โ t3code(no-polling-loop-in-tests): Polling loop in a test. Spinning on `yieldNow`/`sleep` is scheduler- and load-dependent. Await the `Deferred`, `Queue.take`, `Stream` element, `drain()`, or `expect.poll` that marks the milestone.
โญโ[apps/server/src/usage/UsageService.test.ts:2383:7]
2382 โ let orphanedAt: number | undefined;
2383 โ โญโโถ for (let interruptAt = 1; interruptAt <= 31; interruptAt += 1) {
2384 โ โ const tasks: Array<() => void> = [];
2385 โ โ const dispatcher: Scheduler.SchedulerDispatcher = {
2386 โ โ scheduleTask: (task) => tasks.push(task),
2387 โ โ flush: () => {
2388 โ โ let task: (() => void) | undefined;
2389 โ โ while ((task = tasks.shift()) !== undefined) task();
2390 โ โ },
2391 โ โ };
2392 โ โ
2393 โ โ let requestFiber: Fiber.Fiber<unknown, unknown> | undefined;
2394 โ โ let requestChecks = 0;
2395 โ โ const scheduler: Scheduler.Scheduler = {
2396 โ โ executionMode: "async",
2397 โ โ makeDispatcher: () => dispatcher,
2398 โ โ shouldYield: (fiber) => {
2399 โ โ if (fiber !== requestFiber) return false;
2400 โ โ requestChecks += 1;
2401 โ โ if (requestChecks !== interruptAt) return false;
2402 โ โ fiber.interruptUnsafe();
2403 โ โ return true;
2404 โ โ },
2405 โ โ };
2406 โ โ
2407 โ โ const input: UsageSummaryInput = {
2408 โ โ ...WINDOW,
2409 โ โ sinceDay: UsageDay.make("2026-09-01"),
2410 โ โ untilDay: UsageDay.make(`2026-08-${String(interruptAt).padStart(2, "0")}`),
2411 โ โ };
2412 โ โ const first = yield* service
2413 โ โ .readSummary(input)
2414 โ โ .pipe(
2415 โ โ Effect.exit,
2416 โ โ Effect.provideService(Scheduler.Scheduler, scheduler),
2417 โ โ Effect.forkChild,
2418 โ โ );
2419 โ โ requestFiber = first;
2420 โ โ yield* Effect.yieldNow;
2421 โ โ dispatcher.flush();
2422 โ โ
2423 โ โ const second = yield* service.readSummary(input).pipe(
2424 โ โ Effect.match({
2425 โ โ onFailure: (error) => error.reason,
2426 โ โ onSuccess: () => "success" as const,
2427 โ โ }),
2428 โ โ Effect.provideService(Scheduler.Scheduler, scheduler),
2429 โ โ Effect.forkChild,
2430 โ โ );
2431 โ โ yield* Effect.yieldNow;
2432 โ โ dispatcher.flush();
2433 โ โ const secondExit = second.pollUnsafe();
2434 โ โ if (secondExit === undefined) {
2435 โ โ second.interruptUnsafe();
2436 โ โ orphanedAt = interruptAt;
2437 โ โ break;
2438 โ โ }
2439 โ โ if (Exit.isFailure(secondExit)) {
2440 โ โ assert.fail("the matching request fiber was interrupted");
2441 โ โ }
2442 โ โ assert.strictEqual(secondExit.value, "invalidWindow");
2443 โ โฐโโถ }
2444 โ
โฐโโโโ
โ t3code(no-inline-schema-compile): Hoist Schema.encodeEffect(...) to module scope: both the inline schema literal and the compiled function are rebuilt on every call. Move the compiled function to a module-level const.
โญโ[apps/server/src/serverSettings.test.ts:1741:32]
1740 โ const model = createModelSelection(ProviderInstanceId.make("codex"), "gpt-5.5");
1741 โ const modelJson = yield* Schema.encodeEffect(Schema.fromJsonString(ModelSelection))(model);
ยท โโโโโโโโโโโโโโโโโโโ
1742 โ const scriptsJson = yield* Schema.encodeEffect(
โฐโโโโ
โ t3code(no-inline-schema-compile): Hoist Schema.encodeEffect(...) to module scope: both the inline schema literal and the compiled function are rebuilt on every call. Move the compiled function to a module-level const.
โญโ[apps/server/src/serverSettings.test.ts:1742:34]
1741 โ const modelJson = yield* Schema.encodeEffect(Schema.fromJsonString(ModelSelection))(model);
1742 โ const scriptsJson = yield* Schema.encodeEffect(
ยท โโโโโโโโโโโโโโโโโโโ
1743 โ Schema.fromJsonString(Schema.Array(ProjectScript)),
โฐโโโโ
โ unicorn(no-useless-fallback-in-spread): Empty fallbacks in spreads are unnecessary
โญโ[scripts/lib/cli-external-packages.test.ts:114:11]
113 โ const declared = {
114 โ ...(manifest.dependencies ?? {}),
ยท โโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโ
115 โ ...(manifest.optionalDependencies ?? {}),
โฐโโโโ
help: Spreading falsy values in object literals won't add any unexpected properties, so it's unnecessary to add an empty object as fallback.
โ unicorn(no-useless-fallback-in-spread): Empty fallbacks in spreads are unnecessary
โญโ[scripts/lib/cli-external-packages.test.ts:115:11]
114 โ ...(manifest.dependencies ?? {}),
115 โ ...(manifest.optionalDependencies ?? {}),
ยท โโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโ
116 โ ...(manifest.peerDependencies ?? {}),
โฐโโโโ
help: Spreading falsy values in object literals won't add any unexpected properties, so it's unnecessary to add an empty object as fallback.
โ unicorn(no-useless-fallback-in-spread): Empty fallbacks in spreads are unnecessary
โญโ[scripts/lib/cli-external-packages.test.ts:116:11]
115 โ ...(manifest.optionalDependencies ?? {}),
116 โ ...(manifest.peerDependencies ?? {}),
ยท โโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโ
117 โ };
โฐโโโโ
help: Spreading falsy values in object literals won't add any unexpected properties, so it's unnecessary to add an empty object as fallback.
โ eslint(no-unused-vars): Variable 'layerFromProviderAdapter' is declared but never used. Unused variables should start with a '_'.
โญโ[apps/server/src/orchestration-v2/ProviderAdapterRegistry.ts:346:7]
345 โ
346 โ const layerFromProviderAdapter: Layer.Layer<
ยท โโโโโโโโโโโโโฌโโโโโโโโโโโ
ยท โฐโโ 'layerFromProviderAdapter' is declared here
347 โ ProviderAdapterRegistryV2,
โฐโโโโ
help: Consider removing this declaration.
โ t3code(no-polling-loop-in-tests): Polling loop in a test. Spinning on `yieldNow`/`sleep` is scheduler- and load-dependent. Await the `Deferred`, `Queue.take`, `Stream` element, `drain()`, or `expect.poll` that marks the milestone.
โญโ[apps/server/src/project/ProjectEnrichmentService.test.ts:28:3]
27 โ ) {
28 โ โญโโถ for (let attempt = 0; attempt < 100; attempt += 1) {
29 โ โ const available = yield* service.peek(workspaceRoot);
30 โ โ if (predicate(available)) return available;
31 โ โ yield* Effect.yieldNow;
32 โ โฐโโถ }
33 โ return yield* Effect.die(`Project metadata for ${workspaceRoot} was not resolved in time.`);
โฐโโโโ
โ t3code(no-inline-schema-compile): Hoist Schema.encodeUnknownSync(...) to module scope: both the inline schema literal and the compiled function are rebuilt on every call. Move the compiled function to a module-level const.
โญโ[packages/contracts/src/composerContext.test.ts:181:18]
180 โ it("sends a message without the records the wire cannot carry", () => {
181 โ const wire = Schema.encodeUnknownSync(Schema.toCodecJson(OrchestrationMessageContext))({
ยท โโโโโโโโโโโโโโโโโโโโโโโโ
182 โ version: 1,
โฐโโโโ
โ t3code(no-polling-loop-in-tests): Polling loop in a test. Spinning on `yieldNow`/`sleep` is scheduler- and load-dependent. Await the `Deferred`, `Queue.take`, `Stream` element, `drain()`, or `expect.poll` that marks the milestone.
โญโ[apps/server/src/project/ProjectService.test.ts:94:3]
93 โ ) {
94 โ โญโโถ for (let attempt = 0; attempt < 100; attempt += 1) {
95 โ โ const project = Option.getOrThrow(yield* service.getById(projectId));
96 โ โ if (predicate(project)) return project;
97 โ โ yield* Effect.yieldNow;
98 โ โฐโโถ }
99 โ return yield* Effect.die(`Project ${projectId} was not enriched in time.`);
โฐโโโโ
โ t3code(no-polling-loop-in-tests): Polling loop in a test. Spinning on `yieldNow`/`sleep` is scheduler- and load-dependent. Await the `Deferred`, `Queue.take`, `Stream` element, `drain()`, or `expect.poll` that marks the milestone.
โญโ[packages/client-runtime/src/connection/supervisor.test.ts:135:3]
134 โ let lastState = yield* SubscriptionRef.get(state);
135 โ โญโโถ for (let iteration = 0; iteration < 100; iteration += 1) {
136 โ โ lastState = yield* SubscriptionRef.get(state);
137 โ โ if (predicate(lastState)) {
138 โ โ return lastState;
139 โ โ }
140 โ โ yield* Effect.yieldNow;
141 โ โฐโโถ }
142 โ return yield* Effect.die(
โฐโโโโ
โ react(set-state-in-effect): Calling setState synchronously within an effect can trigger cascading renders
โญโ[apps/mobile/src/components/MediaVideoPlayer.tsx:60:5]
57 โ
58 โ useEffect(() => {
ยท โโโโโฌโโโโ
ยท โฐโโ This is the containing effect
59 โ const controller = new AbortController();
60 โ setLoadState("pending");
ยท โโโโโโโฌโโโโโ
ยท โฐโโ Avoid calling setState() directly within an effect
61 โ // A renewed signature is used on Retry, not as a reason to reset the native player.
โฐโโโโ
help: Effects should synchronize React with external systems. Calling setState synchronously inside an effect starts another render and is usually unnecessary. Derive the value during render, initialize state directly, or update it from the event that caused the change. Use an effect only when synchronizing with an external system.
note: React Compiler skipped optimizing this component or hook. Additional guidance: https://react.dev/reference/eslint-plugin-react-hooks/lints/set-state-in-effect
โ react(exhaustive-effect-dependencies): Found extra effect dependencies
โญโ[apps/mobile/src/components/MediaVideoPlayer.tsx:71:7]
70 โ return () => controller.abort();
71 โ }, [player, props.playRequested, attempt]);
ยท โโโโฌโโ โโโโโโโโโโฌโโโโโโโโโ โโโโฌโโโ
ยท โ โ โฐโโ Unnecessary dependency `attempt`
ยท โ โฐโโ Unnecessary dependency `props.playRequested`
ยท โฐโโ Unnecessary dependency `player_0`
72 โ
โฐโโโโ
help: Extra dependencies can cause an effect to fire more often than it should, resulting in performance problems such as excessive renders and side effects
note: React Compiler skipped optimizing this component or hook. Additional guidance: https://react.dev/reference/eslint-plugin-react-hooks/lints/exhaustive-deps
โ react(set-state-in-effect): Calling setState synchronously within an effect can trigger cascading renders
โญโ[apps/mobile/src/components/ProjectFavicon.tsx:158:5]
153 โ const [activeFaviconRequest, setActiveFaviconRequest] = useState<typeof faviconRequest>(null);
154 โ useLayoutEffect(() => {
ยท โโโโโโโโฌโโโโโโโ
ยท โฐโโ This is the containing effect
155 โ if (faviconRequest === null) return;
156 โ
157 โ const endRequest = beginProjectFaviconRequest(faviconRequest);
158 โ setActiveFaviconRequest(faviconRequest);
ยท โโโโโโโโโโโโฌโโโโโโโโโโโ
ยท โฐโโ Avoid calling setState() directly within an effect
159 โ return endRequest;
โฐโโโโ
help: Effects should synchronize React with external systems. Calling setState synchronously inside an effect starts another render and is usually unnecessary. Derive the value during render, initialize state directly, or update it from the event that caused the change. Use an effect only when synchronizing with an external system.
note: React Compiler skipped optimizing this component or hook. Additional guidance: https://react.dev/reference/eslint-plugin-react-hooks/lints/set-state-in-effect
โ react(set-state-in-effect): Calling setState synchronously within an effect can trigger cascading renders
โญโ[apps/mobile/src/components/VideoPreviewModal.tsx:68:5]
66 โ const { id: attachmentId, fileUri } = attachment;
67 โ useEffect(() => {
ยท โโโโโฌโโโโ
ยท โฐโโ This is the containing effect
68 โ setUri(null);
ยท โโโโฌโโ
ยท โฐโโ Avoid calling setState() directly within an effect
69 โ setError(null);
โฐโโโโ
help: Effects should synchronize React with external systems. Calling setState synchronously inside an effect starts another render and is usually unnecessary. Derive the value during render, initialize state directly, or update it from the event that caused the change. Use an effect only when synchronizing with an external system.
note: React Compiler skipped optimizing this component or hook. Additional guidance: https://react.dev/reference/eslint-plugin-react-hooks/lints/set-state-in-effect
โ react(exhaustive-effect-dependencies): Found extra effect dependencies
โญโ[apps/mobile/src/components/VideoPreviewModal.tsx:91:7]
90 โ };
91 โ }, [attachmentId, fileUri]);
ยท โโโโโโโฌโโโโโ โโโโฌโโโ
ยท โ โฐโโ Unnecessary dependency `fileUri`
ยท โฐโโ Unnecessary dependency `attachmentId`
92 โ const mimeType = videoMimeType(attachment) ?? attachment.mimeType;
โฐโโโโ
help: Extra dependencies can cause an effect to fire more often than it should, resulting in performance problems such as excessive renders and side effects
note: React Compiler skipped optimizing this component or hook. Additional guidance: https://react.dev/reference/eslint-plugin-react-hooks/lints/exhaustive-deps
โ react(exhaustive-effect-dependencies): Found missing/extra effect dependencies
โญโ[apps/mobile/src/components/VideoPreviewModal.tsx:213:34]
212 โ useEffect(() => {
213 โ if (!isFocused && hasSource) props.onRequestClose();
ยท โโโฌโโ
ยท โฐโโ Missing dependency `props`
214 โ }, [isFocused, hasSource, props.onRequestClose]);
ยท โโโโโโโโโโโฌโโโโโโโโโ
ยท โฐโโ Overly precise dependency `props.onRequestClose`, use `props` instead
215 โ const { source } = props;
โฐโโโโ
help: Missing dependencies can cause an effect to fire less often than it should. Extra dependencies can cause an effect to fire more often than it should, resulting in performance problems such as excessive renders and side effects
note: React Compiler skipped optimizing this component or hook. Additional guidance: https://react.dev/reference/eslint-plugin-react-hooks/lints/exhaustive-deps
โ eslint(no-empty-pattern): Empty object binding pattern
โญโ[apps/server/src/process/externalLauncher.test.ts:186:12]
185 โ
186 โ for (const {} of ["darwin", "linux"] as const) {
ยท โโ
187 โ }
โฐโโโโ
help: Passing `null` or `undefined` will result in runtime error because `null` and `undefined` cannot be destructured.
โ eslint(no-empty-pattern): Empty object binding pattern
โญโ[apps/server/src/process/externalLauncher.test.ts:189:12]
188 โ
189 โ for (const {} of [
ยท โโ
190 โ { kind: "browser", folderVerb: "none" },
โฐโโโโ
help: Passing `null` or `undefined` will result in runtime error because `null` and `undefined` cannot be destructured.
โ eslint(no-empty-pattern): Empty object binding pattern
โญโ[apps/server/src/process/externalLauncher.test.ts:311:12]
310 โ
311 โ for (const {} of ["rejected", "spawn-error", "stalled"] as const) {
ยท โโ
312 โ }
โฐโโโโ
help: Passing `null` or `undefined` will result in runtime error because `null` and `undefined` cannot be destructured.
โ eslint(no-empty-pattern): Empty object binding pattern
โญโ[apps/server/src/process/externalLauncher.test.ts:314:12]
313 โ
314 โ for (const {} of [
ยท โโ
315 โ {
โฐโโโโ
help: Passing `null` or `undefined` will result in runtime error because `null` and `undefined` cannot be destructured.
โ react(set-state-in-effect): Calling setState synchronously within an effect can trigger cascading renders
โญโ[apps/mobile/src/components/VideoPreviewModal.ios.tsx:63:55]
61 โ }, []);
62 โ useEffect(() => {
ยท โโโโโฌโโโโ
ยท โฐโโ This is the containing effect
63 โ if (playbackUrl === null && resolvedUrl !== null) setPlaybackUrl(resolvedUrl);
ยท โโโโโโโโฌโโโโโโ
ยท โฐโโ Avoid calling setState() directly within an effect
64 โ }, [playbackUrl, resolvedUrl]);
โฐโโโโ
help: Effects should synchronize React with external systems. Calling setState synchronously inside an effect starts another render and is usually unnecessary. Derive the value during render, initialize state directly, or update it from the event that caused the change. Use an effect only when synchronizing with an external system.
note: React Compiler skipped optimizing this component or hook. Additional guidance: https://react.dev/reference/eslint-plugin-react-hooks/lints/set-state-in-effect
โ react(refs): Cannot access refs during render
โญโ[apps/mobile/src/components/ui/AndroidAnchoredMenu.tsx:152:27]
151 โ <View ref={anchorRef} collapsable={false} className={props.className} style={props.style}>
152 โ {props.children(open)}
ยท โโโฌโ
ยท โฐโโ Cannot access ref value during render
153 โ </View>
โฐโโโโ
help: React refs are values that are not needed for rendering. Refs should only be accessed outside of render, such as in event handlers or effects. Accessing a ref value (the `current` property) during render can cause your component not to update as expected
note: React Compiler skipped optimizing this component or hook. Additional guidance: https://react.dev/reference/eslint-plugin-react-hooks/lints/refs
โ react(memo-dependencies): Found missing/extra memoization dependencies
โญโ[apps/mobile/src/components/ui/AndroidAnchoredMenu.tsx:140:9]
139 โ if (action.id !== undefined) {
140 โ props.onPressAction?.({
ยท โโโฌโโ
ยท โฐโโ Missing dependency `props`
141 โ nativeEvent: { event: action.id },
142 โ } as Parameters<NonNullable<MenuComponentProps["onPressAction"]>>[0]);
143 โ }
144 โ },
145 โ [close, props.onPressAction],
ยท โโโโโโโโโโฌโโโโโโโโโ
ยท โฐโโ Overly precise dependency `props.onPressAction`, use `props` instead
146 โ );
โฐโโโโ
help: Missing dependencies can cause a value to update less often than it should, resulting in stale UI. Extra dependencies can cause a value to update more often than it should, resulting in performance problems such as excessive renders or effects firing too often
note: React Compiler skipped optimizing this component or hook. Additional guidance: https://react.dev/reference/eslint-plugin-react-hooks/lints/exhaustive-deps
โ react(refs): Cannot access refs during render
โญโ[apps/mobile/src/components/ui/Menu.tsx:54:36]
53 โ const child = children as ReactElement<Pick<PressableProps, "onTouchStart" | "onPress">>;
54 โ โญโโถ children = cloneElement(child, {
55 โ โ onTouchStart: (event) => {
56 โ โ // Reset for a new touch, not onPressIn, which also fires when a
57 โ โ // finger moves out of the row and back during the same gesture.
58 โ โ menuPress.current.isPreparing = false;
59 โ โ menuPress.current.suppressPress = menuPress.current.isOpen;
60 โ โ pendingPress.current = null;
61 โ โ child.props.onTouchStart?.(event);
62 โ โ },
63 โ โ onPress: (event) => {
64 โ โ // Accessibility clicks have no touch identifier and must not inherit
65 โ โ // cancellation from a previous physical gesture.
66 โ โ const isTouch = typeof event.nativeEvent.identifier === "number";
67 โ โ if (isTouch ? menuPress.current.suppressPress : menuPress.current.isOpen) {
68 โ โ return;
69 โ โ }
70 โ โ if (isTouch && menuPress.current.isPreparing) {
71 โ โ // A release can arrive between native menu preparation and display.
72 โ โ // Let UIKit's display/cancel callback decide this press's outcome.
73 โ โ event.persist();
74 โ โ pendingPress.current = () => child.props.onPress?.(event);
75 โ โ return;
76 โ โ }
77 โ โ child.props.onPress?.(event);
78 โ โ },
79 โ โโโถ });
ยท โฐโโโโ Passing a ref to a function may read its value during render
80 โ menuProps.onMenuInteractionStart = () => {
โฐโโโโ
help: React refs are values that are not needed for rendering. Refs should only be accessed outside of render, such as in event handlers or effects. Accessing a ref value (the `current` property) during render can cause your component not to update as expected
note: React Compiler skipped optimizing this component or hook. Additional guidance: https://react.dev/reference/eslint-plugin-react-hooks/lints/refs
โ eslint(no-unsafe-optional-chaining): Unsafe usage of optional chaining
โญโ[apps/server/src/orchestration-v2/ThreadLaunchService.test.ts:1783:8]
1782 โ assert.equal(
1783 โ (stored.context?.records[0] as { attachmentId: string }).attachmentId,
ยท โโโโโโโโโโโโโโโโโโโโโโโโโโ
1784 โ stored.attachments[0]?.id,
โฐโโโโ
help: If this short-circuits with 'undefined' the evaluation will throw TypeError
โ unicorn(require-module-specifiers): Empty import specifier is not allowed
โญโ[apps/server/src/sourceControl/SourceControlProviderRegistry.ts:15:13]
14 โ } from "@t3tools/contracts";
15 โ import type {} from "@t3tools/contracts";
ยท โโ
16 โ import { detectSourceControlProviderFromRemoteUrl } from "@t3tools/shared/sourceControl";
โฐโโโโ
help: Remove empty braces
โ eslint(no-unused-vars): Parameter '_' is declared but never used.
โญโ[apps/server/src/mcp/WorktreeMcpService.test.ts:121:27]
120 โ const scope = makeScope(options.capabilities ?? new Set(["preview", "worktree"]));
121 โ const dispatch = vi.fn((_: unknown) =>
ยท โฌ
ยท โฐโโ '_' is declared here
122 โ (options.dispatchGate ?? Effect.void).pipe(
โฐโโโโ
help: Consider removing this parameter.
โ eslint(no-unused-vars): Parameter '_' is declared but never used.
โญโ[apps/server/src/mcp/WorktreeMcpService.test.ts:134:39]
133 โ );
134 โ const listLocalBranchNames = vi.fn((_: string) =>
ยท โฌ
ยท โฐโโ '_' is declared here
135 โ Effect.succeed(
โฐโโโโ
help: Consider removing this parameter.
โ eslint(no-unused-vars): Parameter '_' is declared but never used.
โญโ[apps/server/src/mcp/WorktreeMcpService.test.ts:178:31]
177 โ });
178 โ const sendToThread = vi.fn((_: unknown) => {
ยท โฌ
ยท โฐโโ '_' is declared here
179 โ switch (options.continuation ?? "queued") {
โฐโโโโ
help: Consider removing this parameter.
โ eslint(no-unused-vars): Parameter '_' is declared but never used.
โญโ[apps/server/src/mcp/WorktreeMcpService.test.ts:203:33]
202 โ );
203 โ const removeWorktree = vi.fn((_: unknown) =>
ยท โฌ
ยท โฐโโ '_' is declared here
204 โ options.removeWorktreeFails
โฐโโโโ
help: Consider removing this parameter.
โ eslint(no-unused-vars): Parameter '_' is declared but never used.
โญโ[apps/server/src/mcp/WorktreeMcpService.test.ts:208:36]
207 โ );
208 โ const deleteLocalBranch = vi.fn((_: unknown) =>
ยท โฌ
ยท โฐโโ '_' is declared here
209 โ options.deleteLocalBranchFails
โฐโโโโ
help: Consider removing this parameter.
โ eslint(no-unused-vars): Parameter '_' is declared but never used.
โญโ[apps/server/src/mcp/WorktreeMcpService.test.ts:213:42]
212 โ );
213 โ const fetchWorktreeBaseCommit = vi.fn((_: unknown) =>
ยท โฌ
ยท โฐโโ '_' is declared here
214 โ options.fetchWorktreeBaseFails
โฐโโโโ
help: Consider removing this parameter.
โ eslint(no-unused-vars): Parameter '_' is declared but never used.
โญโ[apps/server/src/mcp/WorktreeMcpService.test.ts:254:30]
253 โ );
254 โ const localStatus = vi.fn((_: unknown) =>
ยท โฌ
ยท โฐโโ '_' is declared here
255 โ Effect.succeed({
โฐโโโโ
help: Consider removing this parameter.
โ eslint(no-unused-vars): Parameter '_' is declared but never used.
โญโ[apps/server/src/mcp/WorktreeMcpService.test.ts:264:32]
263 โ );
264 โ const refreshStatus = vi.fn((_: string) => Effect.die("refreshStatus stub"));
ยท โฌ
ยท โฐโโ '_' is declared here
265 โ const runForThread = vi.fn((input: { readonly worktreePath: string }) => {
โฐโโโโ
help: Consider removing this parameter.
โ eslint(no-unused-vars): Variable 'revokeActiveMcpThread' is declared but never used. Unused variables should start with a '_'.
โญโ[apps/server/src/mcp/McpSessionRegistry.ts:218:7]
217 โ
218 โ const revokeActiveMcpThread = (threadId: ThreadId): Effect.Effect<void> =>
ยท โโโโโโโโโโโฌโโโโโโโโโโ
ยท โฐโโ 'revokeActiveMcpThread' is declared here
219 โ activeMcpSessionRegistry ? activeMcpSessionRegistry.revokeThread(threadId) : Effect.void;
โฐโโโโ
help: Consider removing this declaration.
โ eslint(no-unused-vars): Variable 'revokeAllActiveMcpCredentials' is declared but never used. Unused variables should start with a '_'.
โญโ[apps/server/src/mcp/McpSessionRegistry.ts:221:7]
220 โ
221 โ const revokeAllActiveMcpCredentials = (): Effect.Effect<void> =>
ยท โโโโโโโโโโโโโโโฌโโโโโโโโโโโโโโ
ยท โฐโโ 'revokeAllActiveMcpCredentials' is declared here
222 โ activeMcpSessionRegistry ? activeMcpSessionRegistry.revokeAll : Effect.void;
โฐโโโโ
help: Consider removing this declaration.
โ eslint(no-unused-vars): Function 'describeSchedule' is declared but never used.
โญโ[apps/server/src/scheduledTasks/Schedule.ts:79:10]
78 โ
79 โ function describeSchedule(schedule: ScheduledTaskSchedule): string {
ยท โโโโโโโโโฌโโโโโโโ
ยท โฐโโ 'describeSchedule' is declared here
80 โ if (schedule.type === "webhook") return "On webhook";
โฐโโโโ
help: Consider removing this declaration.
โ t3code(no-polling-loop-in-tests): Polling loop in a test. Spinning on `yieldNow`/`sleep` is scheduler- and load-dependent. Await the `Deferred`, `Queue.take`, `Stream` element, `drain()`, or `expect.poll` that marks the milestone.
โญโ[apps/server/src/scheduledTasks/ScheduledTaskService.webhook.test.ts:521:13]
520 โ })).delivery;
521 โ โญโโถ while (delivery.outcome === "accepted") {
522 โ โ yield* Effect.yieldNow;
523 โ โ delivery = (yield* service.getWebhookDelivery({
524 โ โ id: task.id,
525 โ โ deliveryId: deliveryId!,
526 โ โ })).delivery;
527 โ โฐโโถ }
528 โ assert.equal(delivery.outcome, "dispatch_failed");
โฐโโโโ
โ eslint(no-unused-vars): Variable 'layerUnavailable' is declared but never used. Unused variables should start with a '_'.
โญโ[apps/server/src/orchestration-v2/Orchestrator.ts:12340:7]
12339 โ
12340 โ const layerUnavailable: Layer.Layer<OrchestratorV2> = Layer.succeed(
ยท โโโโโโโโโฌโโโโโโโ
ยท โฐโโ 'layerUnavailable' is declared here
12341 โ OrchestratorV2,
โฐโโโโ
help: Consider removing this declaration.
โ t3code(no-polling-loop-in-tests): Polling loop in a test. Spinning on `yieldNow`/`sleep` is scheduler- and load-dependent. Await the `Deferred`, `Queue.take`, `Stream` element, `drain()`, or `expect.poll` that marks the milestone.
โญโ[apps/server/src/orchestration-v2/FoundationPersistence.test.ts:566:7]
565 โ let afterSequence = created[0]!.sequence;
566 โ โญโโถ for (let index = 1; index <= 32; index += 1) {
567 โ โ const nextEvent = {
568 โ โ id: EventId.make(`event:foundation-stream-race:${index}`),
569 โ โ type: "thread.metadata-updated" as const,
570 โ โ threadId,
571 โ โ providerInstanceId,
572 โ โ occurredAt: now,
573 โ โ payload: { ...thread, title: `Race update ${index}` },
574 โ โ } satisfies OrchestrationV2DomainEvent;
575 โ โ const reader = yield* eventSink
576 โ โ .stream({ threadId, afterSequence })
577 โ โ .pipe(Stream.runHead, Effect.forkChild);
578 โ โ yield* Effect.yieldNow;
579 โ โ const written = yield* eventSink.write({ events: [nextEvent] });
580 โ โ const received = yield* Fiber.join(reader);
581 โ โ if (Option.isNone(received)) {
582 โ โ return yield* Effect.die("The event stream ended before delivering the live event.");
583 โ โ }
584 โ โ assert.equal(received.value.sequence, written[0]?.sequence);
585 โ โ assert.equal(received.value.event.id, nextEvent.id);
586 โ โ afterSequence = received.value.sequence;
587 โ โฐโโถ }
588 โ }),
โฐโโโโ
โ t3code(no-polling-loop-in-tests): Polling loop in a test. Spinning on `yieldNow`/`sleep` is scheduler- and load-dependent. Await the `Deferred`, `Queue.take`, `Stream` element, `drain()`, or `expect.poll` that marks the milestone.
โญโ[apps/server/src/orchestration-v2/FoundationPersistence.test.ts:2327:9]
2326 โ let settled = false;
2327 โ โญโโถ while (!settled) {
2328 โ โ settled = (yield* outbox.listByCommandId(commandId)).every(
2329 โ โ (effect) => effect.status === "succeeded",
2330 โ โ );
2331 โ โ if (!settled) yield* Effect.yieldNow;
2332 โ โฐโโถ }
2333 โ }).pipe(Effect.provide(layerWorker), Effect.scoped);
โฐโโโโ
โ typescript(no-extraneous-class): Unexpected class with only a constructor.
โญโ[apps/desktop/src/preview/Manager.test.ts:158:18]
157 โ BrowserWindow: browserWindowConstructor,
158 โ โญโโถ ClipboardItem: class {
159 โ โ constructor(data: Record<string, unknown>) {
160 โ โ clipboardItemConstructor(data);
161 โ โ }
162 โ โฐโโถ },
163 โ clipboard: {
โฐโโโโ
help: Try replacing this class with a standalone function or deleting it entirely
โ eslint(no-unused-vars): Parameter '_' is declared but never used.
โญโ[apps/server/src/orchestration-v2/PullRequestSyncReactor.test.ts:555:70]
554 โ assert.deepStrictEqual(
555 โ (yield* Ref.get(fixture.syncCommands)).map(({ commandId: _, ...rest }) => rest),
ยท โฌ
ยท โฐโโ '_' is declared here
556 โ [
โฐโโโโ
help: Consider removing this parameter.
โ eslint(no-unused-vars): Parameter '_' is declared but never used.
โญโ[apps/server/src/orchestration-v2/PullRequestSyncReactor.test.ts:1155:70]
1154 โ assert.deepStrictEqual(
1155 โ (yield* Ref.get(fixture.linkCommands)).map(({ commandId: _, ...rest }) => rest),
ยท โฌ
ยท โฐโโ '_' is declared here
1156 โ [
โฐโโโโ
help: Consider removing this parameter.
โ eslint(no-unused-vars): Function 'resolveThreadWorkspaceCwd' is declared but never used.
โญโ[apps/server/src/checkpointing/Utils.ts:12:10]
11 โ
12 โ function resolveThreadWorkspaceCwd(input: {
ยท โโโโโโโโโโโโโฌโโโโโโโโโโโโ
ยท โฐโโ 'resolveThreadWorkspaceCwd' is declared here
13 โ readonly thread: {
โฐโโโโ
help: Consider removing this declaration.
โ t3code(no-inline-schema-compile): Hoist Schema.decodeUnknownSync(...) to module scope: the compiled function is rebuilt on every call. Move it to a module-level const.
โญโ[apps/server/src/auth/RpcAuthorization.ts:236:17]
235 โ const requiredScopesForSettingsUpdate = (payload: unknown) => {
236 โ const input = Schema.decodeUnknownSync(SettingsUpdate)(payload);
ยท โโโโโโโโโโโโโโโโโโโโโโโโ
237 โ const scopes = requiredScopesForServerSettingsPatch(input.patch);
โฐโโโโ
โ t3code(no-inline-schema-compile): Hoist Schema.decodeUnknownSync(...) to module scope: the compiled function is rebuilt on every call. Move it to a module-level const.
โญโ[apps/server/src/auth/RpcAuthorization.ts:255:26]
254 โ if (method === WS_METHODS.assetsCreateUrl) {
255 โ const { resource } = Schema.decodeUnknownSync(AssetCreateUrlInput)(payload);
ยท โโโโโโโโโโโโโโโโโโโโโโโโ
256 โ return [
โฐโโโโ
โ react(purity): Cannot call impure function during render
โญโ[apps/web/src/components/chat/useThreadLifecycle.tsx:178:58]
177 โ if (snoozeClockState.shell !== activeThreadShell) {
178 โ setSnoozeClockState({ shell: activeThreadShell, now: new Date().toISOString() });
ยท โโโโโโฌโโโโ
ยท โฐโโ Cannot call impure function
179 โ }
โฐโโโโ
help: `Date` is an impure function. Calling an impure function can produce unstable results that update unpredictably when the component re-renders
note: React Compiler skipped optimizing this component or hook. Additional guidance: https://react.dev/reference/eslint-plugin-react-hooks/lints/purity
โ eslint(no-unused-vars): Identifier 'identity' is imported but never used.
โญโ[apps/server/src/auth/http.ts:28:10]
27 โ import * as Schema from "effect/Schema";
28 โ import { identity } from "effect/Function";
ยท โโโโโฌโโโ
ยท โฐโโ 'identity' is imported here
29 โ import * as Layer from "effect/Layer";
โฐโโโโ
help: Consider removing this import.
โ t3code(no-polling-loop-in-tests): Polling loop in a test. Spinning on `yieldNow`/`sleep` is scheduler- and load-dependent. Await the `Deferred`, `Queue.take`, `Stream` element, `drain()`, or `expect.poll` that marks the milestone.
โญโ[apps/server/src/background/HostPowerMonitor.test.ts:133:11]
132 โ const monitor = yield* HostPowerMonitor.HostPowerMonitor;
133 โ โญโโถ for (
134 โ โ let attempt = 0;
135 โ โ attempt < 100 && (yield* monitor.snapshot).onBattery !== "true";
136 โ โ attempt += 1
137 โ โ ) {
138 โ โ yield* Effect.yieldNow;
139 โ โฐโโถ }
140 โ expect((yield* monitor.snapshot).onBattery).toBe("true");
โฐโโโโ
โ unicorn(prefer-set-has): should be a `Set`, and use `.has()` to check existence or non-existence.
โญโ[apps/web/src/components/chat/useComposerSend.ts:985:13]
984 โ const changedBeforeDecline = draftChangedSinceSend();
985 โ โญโโถ const pendingIdsBeforeDecline = pendingApprovalsRef.current.map(
986 โ โ (approval) => approval.requestId,
987 โ โฐโโถ );
988 โ const approvalResponding = approvalsToDecline.some((approval) =>
โฐโโโโ
help: Switch to `Set`
โ react(immutability): This value cannot be modified
โญโ[apps/mobile/src/features/connection/ConnectionStatusDot.tsx:58:7]
53 โ function usePulseAnimation(pulse: boolean) {
54 โ const pulseProgress = useSharedValue(0);
ยท โโโโโโโฌโโโโโโ
ยท โฐโโ `pulseProgress` originates here
55 โ
56 โ useEffect(() => {
57 โ if (pulse) {
58 โ pulseProgress.value = withRepeat(
ยท โโโโโโโฌโโโโโโ
ยท โฐโโ `pulseProgress` cannot be modified
59 โ withTiming(1, {
โฐโโโโ
help: Modifying a value returned from a hook is not allowed. Consider moving the modification into the hook where the value is constructed
note: React Compiler skipped optimizing this component or hook. Additional guidance: https://react.dev/reference/eslint-plugin-react-hooks/lints/immutability
โ react(set-state-in-effect): Calling setState synchronously within an effect can trigger cascading renders
โญโ[apps/mobile/src/features/connection/ConnectionsNewRouteScreen.tsx:79:5]
76 โ
77 โ useEffect(() => {
ยท โโโโโฌโโโโ
ยท โฐโโ This is the containing effect
78 โ const { host, code } = parsePairingUrl(connectionPairingUrl);
79 โ setHostInput(host);
ยท โโโโโโโฌโโโโโ
ยท โฐโโ Avoid calling setState() directly within an effect
80 โ setCodeInput(code);
โฐโโโโ
help: Effects should synchronize React with external systems. Calling setState synchronously inside an effect starts another render and is usually unnecessary. Derive the value during render, initialize state directly, or update it from the event that caused the change. Use an effect only when synchronizing with an external system.
note: React Compiler skipped optimizing this component or hook. Additional guidance: https://react.dev/reference/eslint-plugin-react-hooks/lints/set-state-in-effect
โ react(set-state-in-effect): Calling setState synchronously within an effect can trigger cascading renders
โญโ[apps/mobile/src/features/connection/ConnectionsNewRouteScreen.tsx:89:5]
82 โ
83 โ useEffect(() => {
ยท โโโโโฌโโโโ
ยท โฐโโ This is the containing effect
84 โ if (routePairingUrl.length === 0) {
85 โ return;
86 โ }
87 โ
88 โ const { host, code } = parsePairingUrl(routePairingUrl);
89 โ setHostInput(host);
ยท โโโโโโโฌโโโโโ
ยท โฐโโ Avoid calling setState() directly within an effect
90 โ setCodeInput(code);
โฐโโโโ
help: Effects should synchronize React with external systems. Calling setState synchronously inside an effect starts another render and is usually unnecessary. Derive the value during render, initialize state directly, or update it from the event that caused the change. Use an effect only when synchronizing with an external system.
note: React Compiler skipped optimizing this component or hook. Additional guidance: https://react.dev/reference/eslint-plugin-react-hooks/lints/set-state-in-effect
โ react(set-state-in-effect): Calling setState synchronously within an effect can trigger cascading renders
โญโ[apps/mobile/src/features/connection/ConnectionsNewRouteScreen.tsx:95:7]
92 โ
93 โ useEffect(() => {
ยท โโโโโฌโโโโ
ยท โฐโโ This is the containing effect
94 โ if (pairingConnectionError) {
95 โ setIsSubmitting(false);
ยท โโโโโโโโฌโโโโโโโ
ยท โฐโโ Avoid calling setState() directly within an effect
96 โ }
โฐโโโโ
help: Effects should synchronize React with external systems. Calling setState synchronously inside an effect starts another render and is usually unnecessary. Derive the value during render, initialize state directly, or update it from the event that caused the change. Use an effect only when synchronizing with an external system.
note: React Compiler skipped optimizing this component or hook. Additional guidance: https://react.dev/reference/eslint-plugin-react-hooks/lints/set-state-in-effect
Found 0 errors and 362 warnings in 5398 files (10.4s, 8 threads)
Post job cleanup.
Cache hit occurred on the primary key electron-Linux-X64-854e11ddd491bd4f350eebb67a74265df119376a3984c8e153cfe5fc8ced6309, not saving cache.
Post job cleanup.
##[start-action display=Cache full pnpm store;id=__933c87a0-9980-4ab4-bfb2-bb4e9bcb8cdc.__actions_cache]
Post job cleanup.
Cache hit occurred on the primary key pnpm-full-v1-Linux-X64-2baa264059789b1dde4bbc8fdc5b8342f31f2fc8e6176e5c5e486efdd242b36c, not saving cache.
##[end-action id=__933c87a0-9980-4ab4-bfb2-bb4e9bcb8cdc.__actions_cache;outcome=success;conclusion=success;duration_ms=165]
##[start-action display=Cache Vite+;id=__933c87a0-9980-4ab4-bfb2-bb4e9bcb8cdc.vp_cache]
Post job cleanup.
Cache hit occurred on the primary key vite-plus-home-v2-Linux-X64-1.3.0-node26.12.1-pnpm@12.14.0, not saving cache.
##[end-action id=__933c87a0-9980-4ab4-bfb2-bb4e9bcb8cdc.vp_cache;outcome=success;conclusion=success;duration_ms=101]
Post job cleanup.
[command]/usr/local/bin/git version
git version 2.55.0
Temporarily overriding HOME='/home/runner/_work/_temp/f7680194-ee8f-420f-b149-a806695ed6d8' before making global git config changes
Adding repository directory to the temporary git global config as a safe directory
[command]/usr/local/bin/git config --global --add safe.directory /home/runner/_work/t3code/t3code
Removing SSH command configuration
[command]/usr/local/bin/git config --local --name-only --get-regexp core\.sshCommand
[command]/usr/local/bin/git submodule foreach --recursive sh -c "git config --local --name-only --get-regexp 'core\.sshCommand' && git config --local --unset-all 'core.sshCommand' || :"
fatal: No url found for submodule path '.repos/alchemy-effect/submodules/distilled' in .gitmodules
Warning: The process '/usr/local/bin/git' failed with exit code 128
A job completed hook has been configured by the self-hosted runner administrator
โธ Run '/job_completed.sh'
shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
env:
BLACKSMITH_RUNNER_MESSAGE_WAIT_MS: 195
BLACKSMITH_RUNNER_ACQUIRE_JOB_MS: 729
BLACKSMITH_CHECK_RUN_ID: 120545088735
BLACKSMITH_JOB_DISPLAY_NAME: Lint
GITHUB_ACTIONS_CACHE_MODE: write
Docker container cache not activated, skipping hash computation.
No active SSH sessions detected. Proceeding with shutdown immediately.
Cleaning up orphan processes