docs/qa/full-width-header-2026-10-14/reviews.md
Independent review
Pinned diff 0a2cddd...7416ffe. Two code-review axes completed independently.
Spec
No actionable findings. Compact mark/name/branch beside navigation, blank space expands. Assertions bound label allocation and identity/navigation gaps in LTR/RTL. Details metadata/actions/focus, narrow behavior and terminal identity remain intact. No scope creep.
Standards and visual review
Zero documented Standards violations and no substantial smells. Native HeaderBar/CSD and toolkit boundaries remain intact, consistent with AGENTS.md, constitution §V/VII and docs06/14. Monitor-bounded test sizing adds no skipped case or unnecessary abstraction.
| Before | After | Why |
|---|---|---|
| Mark, name and branch separated | Compact identity near New Tab | Continuous reading at wide widths |
| Identity dispersed in RTL | Compact mirrored group | Preserves title/context relationship |
| Narrow abbreviated title | Useful allocation with attention visible | Preserves adaptive behavior |
Reviewer initially objected to the 1280px light render showing a clipped Changes strip while the baseline panel was docked. Implementer excluded that transient comparison. Reviewer inspected and approved the equivalent 890px shell-light pair with Changes closed, plus stable 2390px dark LTR/RTL standalone renders. No visual objections remain. Final 7416ffe native run reproduced these states unchanged.
Full gate was completed by the parent after review: 55 steps/43 GTK tests passed. Reviewers did not independently execute the full gate. Compositor behavior, screen-reader speech, OSK and IME remain unverified.