# std.crypto.ed25519 incremental signatures: hash the fallback noise \(\#13643\) · gitcafe/zig

[View on GitCafe](https://git.cafe/gitcafe/zig/commit/feb806a212355956a33cc843a6d593741b93c5ec)

Repository: [gitcafe/zig](https://git.cafe/gitcafe/zig)

Visibility: public

Requested revision: feb806a212355956a33cc843a6d593741b93c5ec

Requested commit: feb806a212355956a33cc843a6d593741b93c5ec

Commit: feb806a212355956a33cc843a6d593741b93c5ec

Tree: 55577e257e02bbf07a4afa251110d61cd09b347f

Author: Frank Denis

Committer: GitHub

## Message

```
std.crypto.ed25519 incremental signatures: hash the fallback noise (#13643)

If the noise parameter was null, we didn't use any noise at all.

We unconditionally generated random noise (`noise2`) but didn't use it.

Spotted by @cryptocode, thanks!
```

## Parents

- [02e1facc72fa9cb8e4793ecf114fdd61ea8df6bd](https://git.cafe/gitcafe/zig/commit/02e1facc72fa9cb8e4793ecf114fdd61ea8df6bd?format=markdown)

[Source at this commit](https://git.cafe/gitcafe/zig/tree/feb806a212355956a33cc843a6d593741b93c5ec?format=markdown)