# std.crypto.ed25519 incremental signatures: hash the fallback noise \(\#13643\) · gitcafe/zig

[View on GitCafe](https://git.cafe/gitcafe/zig/commit/ee8af8cffb42603ead90db6a3d7b7df9f2b2a683)

Repository: [gitcafe/zig](https://git.cafe/gitcafe/zig)

Visibility: public

Requested revision: ee8af8cffb42603ead90db6a3d7b7df9f2b2a683

Requested commit: ee8af8cffb42603ead90db6a3d7b7df9f2b2a683

Commit: ee8af8cffb42603ead90db6a3d7b7df9f2b2a683

Tree: c5bfd7c92ff25cb494b3cf56d8e2d9e3902937ad

Author: Frank Denis

Committer: Frank Denis

## Message

```
std.crypto.ed25519 incremental signatures: hash the fallback noise (#13643)

If the noise parameter was null, we didn't use any noise at all.

We unconditionally generated random noise (`noise2`) but didn't use it.

Spotted by @cryptocode, thanks!
```

## Parents

- [3ee5cf627fbf2e5e006535b25d48e070b4442ce8](https://git.cafe/gitcafe/zig/commit/3ee5cf627fbf2e5e006535b25d48e070b4442ce8?format=markdown)

[Source at this commit](https://git.cafe/gitcafe/zig/tree/ee8af8cffb42603ead90db6a3d7b7df9f2b2a683?format=markdown)