# rework generic function calls · gitcafe/zig

[View on GitCafe](https://git.cafe/gitcafe/zig/commit/db33ee45b7261c9ec62a1087cfc9377bc4e7aa8f)

Repository: [gitcafe/zig](https://git.cafe/gitcafe/zig)

Visibility: public

Requested revision: db33ee45b7261c9ec62a1087cfc9377bc4e7aa8f

Requested commit: db33ee45b7261c9ec62a1087cfc9377bc4e7aa8f

Commit: db33ee45b7261c9ec62a1087cfc9377bc4e7aa8f

Tree: 81e1f629c296a8a9c9573879382586dac3784737

Author: Andrew Kelley

Committer: Andrew Kelley

## Message

```
rework generic function calls

Abridged summary:

 * Move `Module.Fn` into `InternPool`.
 * Delete a lot of confusing and problematic `Sema` logic related to
   generic function calls.

This commit removes `Module.Fn` and replaces it with two new
`InternPool.Tag` values:

 * `func_decl` - corresponding to a function declared in the source
   code. This one contains line/column numbers, zir_body_inst, etc.

 * `func_instance` - one for each monomorphization of a generic
   function. Contains a reference to the `func_decl` from whence the
   instantiation came, along with the `comptime` parameter values (or
   types in the case of `anytype`)

Since `InternPool` provides deduplication on these values, these fields
are now deleted from `Module`:

 * `monomorphed_func_keys`
 * `monomorphed_funcs`
 * `align_stack_fns`

Instead of these, Sema logic for generic function instantiation now
unconditionally evaluates the function prototype expression for every
generic callsite. This is technically required in order for type
coercions to work. The previous code had some dubious, probably wrong
hacks to make things work, such as `hashUncoerced`. I'm not 100% sure
how we were able to eliminate that function and still pass all the
behavior tests, but I'm pretty sure things were still broken without
doing type coercion for every generic function call argument.

After the function prototype is evaluated, it produces a deduplicated
`func_instance` `InternPool.Index` which can then be used for the
generic function call.

Some other nice things made by this simplification are the removal of
`comptime_args_fn_inst` and `preallocated_new_func` from `Sema`, and the
messy logic associated with them.

I have not yet been able to measure the perf of this against master
branch. On one hand, it reduces memory usage and pointer chasing of the
most heavily used `InternPool` Tag - function bodies - but on the other
hand, it does evaluate function prototype expressions more than before.
We will soon find out.

```

## Parents

- [70c71935c7c9f20353dc2a50b497b752d70d3452](https://git.cafe/gitcafe/zig/commit/70c71935c7c9f20353dc2a50b497b752d70d3452?format=markdown)

[Source at this commit](https://git.cafe/gitcafe/zig/tree/db33ee45b7261c9ec62a1087cfc9377bc4e7aa8f?format=markdown)