# Avoid logic where we return success in case of an error \(\#25251\) · gitcafe/zig

[View on GitCafe](https://git.cafe/gitcafe/zig/commit/8e8a143d62b6176d94289a2a1e52295b46dfd319)

Repository: [gitcafe/zig](https://git.cafe/gitcafe/zig)

Visibility: public

Requested revision: 8e8a143d62b6176d94289a2a1e52295b46dfd319

Requested commit: 8e8a143d62b6176d94289a2a1e52295b46dfd319

Commit: 8e8a143d62b6176d94289a2a1e52295b46dfd319

Tree: f2b6d122f76ab43c37b4eff7210b967445521da9

Author: Frank Denis

Committer: GitHub

## Message

```
Avoid logic where we return success in case of an error (#25251)

In ed25519.zig, we checked if a test succeeds, in which case we
returned an error. This was confusing, and Andrew pointed out that
Zig weights branches against errors by default.
```

## Parents

- [9819f53453a95aee97bc12854e6d7653b597c2b3](https://git.cafe/gitcafe/zig/commit/9819f53453a95aee97bc12854e6d7653b597c2b3?format=markdown)

[Source at this commit](https://git.cafe/gitcafe/zig/tree/8e8a143d62b6176d94289a2a1e52295b46dfd319?format=markdown)