# build runner: don't incorrectly omit reference traces · gitcafe/zig

[View on GitCafe](https://git.cafe/gitcafe/zig/commit/721821804038d54cb0c0337fee03591545450310)

Repository: [gitcafe/zig](https://git.cafe/gitcafe/zig)

Visibility: public

Requested revision: 721821804038d54cb0c0337fee03591545450310

Requested commit: 721821804038d54cb0c0337fee03591545450310

Commit: 721821804038d54cb0c0337fee03591545450310

Tree: 5d35752e6c6f20507d42e56ab60aa74aaf6d3a2d

Author: mlugg

Committer: Alex Rønne Petersen

## Message

```
build runner: don't incorrectly omit reference traces

It's incorrect to ever set `include_reference_trace` here, because the
compiler has already given or not given reference traces depending on
the `-freference-trace` option propagated to the compiler process by
`std.Build.Step.Compile`.

Perhaps in future we could make the compiler always return the reference
trace when communicating over the compiler protocol; that'd be more
versatile than the current behavior, because the build runner could, for
instance, show a reference trace on-demand without having to even invoke
the compiler. That seems really useful, since the reference trace is
*often* unnecessary noise, but *sometimes* essential. However, we don't
live in that world right now, so passing the option here doesn't make
sense.

Resolves: #23415

```

## Parents

- [f377ea10609c1d3fb82688c51483821e318bd007](https://git.cafe/gitcafe/zig/commit/f377ea10609c1d3fb82688c51483821e318bd007?format=markdown)

[Source at this commit](https://git.cafe/gitcafe/zig/tree/721821804038d54cb0c0337fee03591545450310?format=markdown)