# Review comments from pbkdf2.zig · gitcafe/zig

[View on GitCafe](https://git.cafe/gitcafe/zig/commit/37db93e4260dfcb90ac1553cf096a35ada1825ca)

Repository: [gitcafe/zig](https://git.cafe/gitcafe/zig)

Visibility: public

Requested revision: 37db93e4260dfcb90ac1553cf096a35ada1825ca

Requested commit: 37db93e4260dfcb90ac1553cf096a35ada1825ca

Commit: 37db93e4260dfcb90ac1553cf096a35ada1825ca

Tree: 312b8490c7709d7c163904c7756f225a561c0c21

Author: Rob Napier

Committer: Rob Napier

## Message

```
Review comments from pbkdf2.zig

Move block definitions inside while loop.
Use usize for offset. (This still crashes on overflow)
Remove unneeded slice syntax.
Add slow test for Very large dkLen

```

## Parents

- [c2b02d01d5c0bb684565d5b23b34022b752e9507](https://git.cafe/gitcafe/zig/commit/c2b02d01d5c0bb684565d5b23b34022b752e9507?format=markdown)

[Source at this commit](https://git.cafe/gitcafe/zig/tree/37db93e4260dfcb90ac1553cf096a35ada1825ca?format=markdown)