# agent_ui: Expand model favoriting feature to external agents \(\#45528\) · gitcafe/zed

[View on GitCafe](https://git.cafe/gitcafe/zed/commit/f9d9721b934ba859928026fc71f74b6c5ff33ab2)

Repository: [gitcafe/zed](https://git.cafe/gitcafe/zed)

Visibility: public

Requested revision: f9d9721b934ba859928026fc71f74b6c5ff33ab2

Requested commit: f9d9721b934ba859928026fc71f74b6c5ff33ab2

Commit: f9d9721b934ba859928026fc71f74b6c5ff33ab2

Tree: 1ab560c4d931ca9c5721494ddca990d982542f4f

Author: Danilo Leal

Committer: GitHub

## Message

```
agent_ui: Expand model favoriting feature to external agents (#45528)

This PR adds the ability to favorite models for external agents—writing
to the settings in the `agent_servers` key—as well as a handful of other
improvements:

- Make the cycling keybinding `alt-enter` work for the inline assistant
as well as previous user messages
- Better organized the keybinding files removing some outdated
agent-related keybinding definitions
- Renamed the inline assistant key context to "InlineAssistant" as
"PromptEditor" is old and confusing
- Made the keybindings to rate an inline assistant response visible in
the thumbs up/down button's tooltip
- Created a unified component for the model selector tooltip given we
had 3 different places creating the same element
- Make the "Cycle Favorited Models" row in the tooltip visible only if
there is more than one favorite models

Release Notes:

- agent: External agents also now support the favoriting model feature,
which comes with a handy keybinding to cycle through the favorite list.
```

## Parents

- [cff3ac6f93f506330034652f0d2389591bfb45a0](https://git.cafe/gitcafe/zed/commit/cff3ac6f93f506330034652f0d2389591bfb45a0?format=markdown)

[Source at this commit](https://git.cafe/gitcafe/zed/tree/f9d9721b934ba859928026fc71f74b6c5ff33ab2?format=markdown)