# Change keymap precedence to favor user \(\#37557\) · gitcafe/zed

[View on GitCafe](https://git.cafe/gitcafe/zed/commit/f76407702028a7ca6f09981223db5f1d2993a028)

Repository: [gitcafe/zed](https://git.cafe/gitcafe/zed)

Visibility: public

Requested revision: f76407702028a7ca6f09981223db5f1d2993a028

Requested commit: f76407702028a7ca6f09981223db5f1d2993a028

Commit: f76407702028a7ca6f09981223db5f1d2993a028

Tree: 8869883d48eabcc00a08075f346889181f053b81

Author: Mitch \(a.k.a Voz\)

Committer: GitHub

## Message

```
Change keymap precedence to favor user (#37557)

Closes #35623 

Previously if a base keymap had a `null` set to an action, leading to a
`NoAction` being assigned to the keymap, if a user wanted to take
advantage of that keymap (in this particular case, `cmd-2`), the keymap
binding check would favor the `NoAction` over the user, since
technically the context depth matched better. Instead, we should always
prefer the user's settings over whatever base or default.

Release Notes:

- Fixed keymap precedence by favoring user settings over base keymap /
configs.
```

## Parents

- [9708c8d5079774b2d1e78408098278033471c420](https://git.cafe/gitcafe/zed/commit/9708c8d5079774b2d1e78408098278033471c420?format=markdown)

[Source at this commit](https://git.cafe/gitcafe/zed/tree/f76407702028a7ca6f09981223db5f1d2993a028?format=markdown)