# Remove workspace-hack \(\#40216\) · gitcafe/zed

[View on GitCafe](https://git.cafe/gitcafe/zed/commit/ef5b8c6fed25da85658ad2d376323f26daa88296)

Repository: [gitcafe/zed](https://git.cafe/gitcafe/zed)

Visibility: public

Requested revision: ef5b8c6fed25da85658ad2d376323f26daa88296

Requested commit: ef5b8c6fed25da85658ad2d376323f26daa88296

Commit: ef5b8c6fed25da85658ad2d376323f26daa88296

Tree: 2d7ae4c2f62a25ed84a8f37f92c74a292c10fb15

Author: Julia Ryan

Committer: GitHub

## Message

```
Remove workspace-hack (#40216)

We've been considering removing workspace-hack for a couple reasons:
- Lukas ran into a situation where its build script seemed to be causing
spurious rebuilds. This seems more likely to be a cargo bug than an
issue with workspace-hack itself (given that it has an empty build
script), but we don't necessarily want to take the time to hunt that
down right now.
- Marshall mentioned hakari interacts poorly with automated crate
updates (in our case provided by rennovate) because you'd need to have
`cargo hakari generate && cargo hakari manage-deps` after their changes
and we prefer to not have actions that make commits.

Currently removing workspace-hack causes our workspace to grow from
~1700 to ~2000 crates being built (depending on platform), which is
mainly a problem when you're building the whole workspace or running
tests across the the normal and remote binaries (which is where
feature-unification nets us the most sharing). It doesn't impact
incremental times noticeably when you're just iterating on `-p zed`, and
we'll hopefully get these savings back in the future when
rust-lang/cargo#14774 (which re-implements the functionality of hakari)
is finished.

Release Notes:

- N/A
```

## Parents

- [375a404132142c3fed7374c8387fcae9eb4f164a](https://git.cafe/gitcafe/zed/commit/375a404132142c3fed7374c8387fcae9eb4f164a?format=markdown)

[Source at this commit](https://git.cafe/gitcafe/zed/tree/ef5b8c6fed25da85658ad2d376323f26daa88296?format=markdown)