# Extract completion provider crate \(\#14823\) · gitcafe/zed

[View on GitCafe](https://git.cafe/gitcafe/zed/commit/ec487d8f649603e040fec4df2764585f9425532f)

Repository: [gitcafe/zed](https://git.cafe/gitcafe/zed)

Visibility: public

Requested revision: ec487d8f649603e040fec4df2764585f9425532f

Requested commit: ec487d8f649603e040fec4df2764585f9425532f

Commit: ec487d8f649603e040fec4df2764585f9425532f

Tree: c1e52f35e71a9e7faba63899a15d24a2477f0f95

Author: Richard Feldman

Committer: GitHub

## Message

```
Extract completion provider crate (#14823)

We will soon need `semantic_index` to be able to use
`CompletionProvider`. This is currently impossible due to a cyclic crate
dependency, because `CompletionProvider` lives in the `assistant` crate,
which depends on `semantic_index`.

This PR breaks the dependency cycle by extracting two crates out of
`assistant`: `language_model` and `completion`.

Only one piece of logic changed: [this
code](https://github.com/zed-industries/zed/commit/922fcaf5a6076e56890373035b1065b13512546d#diff-3857b3707687a4d585f1200eec4c34a7a079eae8d303b4ce5b4fce46234ace9fR61-R69).
* As of https://github.com/zed-industries/zed/pull/13276, whenever we
ask a given completion provider for its available models, OpenAI
providers would go and ask the global assistant settings whether the
user had configured an `available_models` setting, and if so, return
that.
* This PR changes it so that instead of eagerly asking the assistant
settings for this info (the new crate must not depend on `assistant`, or
else the dependency cycle would be back), OpenAI completion providers
now store the user-configured settings as part of their struct, and
whenever the settings change, we update the provider.

In theory, this change should not change user-visible behavior...but
since it's the only change in this large PR that's more than just moving
code around, I'm mentioning it here in case there's an unexpected
regression in practice! (cc @amtoaer in case you'd like to try out this
branch and verify that the feature is still working the way you expect.)

Release Notes:

- N/A

---------

Co-authored-by: Marshall Bowers <elliott.codes@gmail.com>
```

## Parents

- [b9a53ffa0b86b0076cb89b2a3cd16596caae98f9](https://git.cafe/gitcafe/zed/commit/b9a53ffa0b86b0076cb89b2a3cd16596caae98f9?format=markdown)

[Source at this commit](https://git.cafe/gitcafe/zed/tree/ec487d8f649603e040fec4df2764585f9425532f?format=markdown)