# tabular_data_preview: Revive filter funnel icon \(\#63266\) · gitcafe/zed

[View on GitCafe](https://git.cafe/gitcafe/zed/commit/e6690f38cc04e10b7fddef0dae61a03463879035)

Repository: [gitcafe/zed](https://git.cafe/gitcafe/zed)

Visibility: public

Requested revision: e6690f38cc04e10b7fddef0dae61a03463879035

Requested commit: e6690f38cc04e10b7fddef0dae61a03463879035

Commit: e6690f38cc04e10b7fddef0dae61a03463879035

Tree: 88db4426a7e1bbd9effdfff4cd057f3ce5d4a178

Author: Oleksandr Kholiavko

Committer: GitHub

## Message

```
tabular_data_preview: Revive filter funnel icon (#63266)

# Objective

Originally, `IconName::Filter` was a funnel glyph and
`IconName::Sliders` was used for settings/controls.

In #60937 (commit `a496bf0ff6`), `filter.svg` was replaced with the
sliders glyph, and `sliders.svg` / `Sliders` enum variants were deleted.
Consequently, `IconName::Filter` has become a sliders-shaped icon used
across 8+ surfaces in Zed (git_ui, search, debugger_ui, keymap_editor,
language_tools, quick_action_bar, editor view settings).

When moving tabular data preview settings to follow the editor's
convention (using `IconName::Filter` sliders for table view settings),
column filter buttons in the table header were left using the same
sliders icon instead of a traditional funnel.

Repurposing `IconName::Filter` back to a funnel would break all other UI
surfaces across Zed.

## Solution

- Restored the funnel icon under a new dedicated
`IconName::FilterFunnel` variant (`assets/icons/filter_funnel.svg` and
`crates/icons/src/icons.rs`).
- Updated `tabular_data_preview` column filter trigger buttons
(`table_header.rs`) to use `IconName::FilterFunnel`.
- Left all existing `IconName::Filter` (sliders) usages across the app
untouched.

Before:
<img width="363" height="156" alt="image"
src="https://github.com/user-attachments/assets/84ac5f87-c0f7-4de9-94ea-e4040e3b4a4a"
/>

After:
<img width="361" height="151" alt="image"
src="https://github.com/user-attachments/assets/38514f3a-0710-4273-b227-4623bf78410b"
/>

## Testing

- `cargo check -p icons -p tabular_data_preview` and `./script/clippy`
build clean.
- `cargo test -p tabular_data_preview --lib` passes.
- Verified column filter button renders the funnel icon in tabular data
preview and highlights correctly when filters are active.

## Self-Review Checklist:

- [x] I've reviewed my own diff for quality, security, and reliability
- [ ] Unsafe blocks (if any) have justifying comments
- [x] The content adheres to Zed's UI standards
([UX/UI](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist)
and
[icon](https://github.com/zed-industries/zed/blob/main/crates/icons/README.md)
guidelines)
- [ ] Tests cover the new/changed behavior
- [x] Performance impact has been considered and is acceptable

Release Notes:

- Replace column filter icon in tabular data preview with filter funnel
```

## Parents

- [ded896cc913e6c274e4ba5e28cb5975a566b6cc6](https://git.cafe/gitcafe/zed/commit/ded896cc913e6c274e4ba5e28cb5975a566b6cc6?format=markdown)

[Source at this commit](https://git.cafe/gitcafe/zed/tree/e6690f38cc04e10b7fddef0dae61a03463879035?format=markdown)