# snippet: Preserve escaped characters in non-default choice options \(\#61313\) · gitcafe/zed

[View on GitCafe](https://git.cafe/gitcafe/zed/commit/e651b6ddc31f4e9e2816d40d9498fd69ed117b44)

Repository: [gitcafe/zed](https://git.cafe/gitcafe/zed)

Visibility: public

Requested revision: e651b6ddc31f4e9e2816d40d9498fd69ed117b44

Requested commit: e651b6ddc31f4e9e2816d40d9498fd69ed117b44

Commit: e651b6ddc31f4e9e2816d40d9498fd69ed117b44

Tree: b0044a3384c4e51ff5419126a524fe03b5c64968

Author: Venkatesh R

Committer: GitHub

## Message

```
snippet: Preserve escaped characters in non-default choice options (#61313)

Closes #61312

In `parse_choices`, the escape branch only appended the escaped
character to `current_choice` when parsing the first choice, because the
push was placed inside the `!found_default_choice` guard. That guard is
only meant for `text` (the default value inserted into the buffer) — the
plain-text branch below handles it that way. As a result, `${1|a,b\,c|}`
offered the choices `a` and `bc` instead of `a` and `b,c`, and the same
applied to any `\,`, `\|`, or `\\` in choices after the first.

Moved `current_choice.push(c)` out of the guard and added a regression
test covering escaped comma, pipe, and backslash in non-first choices.
Escapes in the first choice were already covered by the existing test
and are unchanged.

Before / after (snippet body `"${1|a,b\\,c|}"`): the choice dropdown
showed `a` / `bc`, now shows `a` / `b,c`.

Release Notes:

- Fixed escaped characters (`\,`, `\|`, `\\`) being dropped from snippet
choice options after the first one
```

## Parents

- [2230c1a5bf5d4d8191917714b61641a5ffded163](https://git.cafe/gitcafe/zed/commit/2230c1a5bf5d4d8191917714b61641a5ffded163?format=markdown)

[Source at this commit](https://git.cafe/gitcafe/zed/tree/e651b6ddc31f4e9e2816d40d9498fd69ed117b44?format=markdown)