# agent_settings: Add \`always_play_sound_when_agent_done\` setting \(\#52284\) · gitcafe/zed

[View on GitCafe](https://git.cafe/gitcafe/zed/commit/e65066753d31eb058eb78ba10e28ce058aff7b1d)

Repository: [gitcafe/zed](https://git.cafe/gitcafe/zed)

Visibility: public

Requested revision: e65066753d31eb058eb78ba10e28ce058aff7b1d

Requested commit: e65066753d31eb058eb78ba10e28ce058aff7b1d

Commit: e65066753d31eb058eb78ba10e28ce058aff7b1d

Tree: 040cc73e83a2e1cf1b0ae13a50b792ed06e32983

Author: ifengqi

Committer: GitHub

## Message

```
agent_settings: Add `always_play_sound_when_agent_done` setting (#52284)

This PR changes `agent.play_sound_when_agent_done` from a boolean to an
enum with three options:

- `never` (default)
- `when_hidden`
- `always`

In Settings → Agent, this now appears as a _Play Sound When Agent Done_
dropdown.

Existing settings are migrated automatically:
- `false` → `never`
- `true` → `always`

### Why

A boolean only allowed the sound to be on or off. This change gives
users clearer control over when the agent notification sound should
play.

### Verification

- Added a migrator test for this setting change.
- Manually tested the settings UI, settings migration and the feature


Release Notes:

- Added new agent notification sound options

---------

Co-authored-by: Oleksiy Syvokon <oleksiy.syvokon@gmail.com>
```

## Parents

- [dc238f27ed55acd1e458bd9ed4158f0099fb63d6](https://git.cafe/gitcafe/zed/commit/dc238f27ed55acd1e458bd9ed4158f0099fb63d6?format=markdown)

[Source at this commit](https://git.cafe/gitcafe/zed/tree/e65066753d31eb058eb78ba10e28ce058aff7b1d?format=markdown)