# collab ui: Fix notification windows on external monitors \(\#9817\) · gitcafe/zed

[View on GitCafe](https://git.cafe/gitcafe/zed/commit/e272acd1bc9642846d2ec71c6a6c65fbf12ccfc0)

Repository: [gitcafe/zed](https://git.cafe/gitcafe/zed)

Visibility: public

Requested revision: e272acd1bc9642846d2ec71c6a6c65fbf12ccfc0

Requested commit: e272acd1bc9642846d2ec71c6a6c65fbf12ccfc0

Commit: e272acd1bc9642846d2ec71c6a6c65fbf12ccfc0

Tree: 7f7008a54511547a07befe734779903bdf012ec6

Author: Bennet Bo Fenner

Committer: GitHub

## Message

````
collab ui: Fix notification windows on external monitors (#9817)

Sharing a project displays a notification (window) on every screen.
Previously there was an issue with the positioning of windows on all
screens except the primary screen.

As you can see here:


![image](https://github.com/zed-industries/zed/assets/53836821/314cf367-8c70-4e8e-bc4a-dcbb99cb4f71)

Now:


![image](https://github.com/zed-industries/zed/assets/53836821/42af9ef3-8af9-453a-ad95-147b5f9d90ba)

@mikayla-maki and I also decided to refactor the `WindowOptions` a bit. 
Previously you could specify bounds which controlled the positioning and
size of the window in the global coordinate space, while also providing
a display id (which screen to show the window on). This can lead to
unusual behavior because you could theoretically specify a global bound
which does not even belong to the display id which was provided.

Therefore we changed the api to this:
```rust
struct WindowOptions {
    /// The bounds of the window in screen coordinates
    /// None -> inherit, Some(bounds) -> set bounds.
    pub bounds: Option<Bounds<DevicePixels>>,

    /// The display to create the window on, if this is None,
    /// the window will be created on the main display
    pub display_id: Option<DisplayId>,
}
```

This lets you specify a display id, which maps to the screen where the
window should be created and bounds relative to the upper left of the
screen.

Release Notes:

- Fixed positioning of popup windows (e.g. when sharing a project) when
using multiple external displays.

---------

Co-authored-by: Conrad Irwin <conrad.irwin@gmail.com>
````

## Parents

- [ffd698be1445a6b5356caaae9bfd377109a51dd6](https://git.cafe/gitcafe/zed/commit/ffd698be1445a6b5356caaae9bfd377109a51dd6?format=markdown)

[Source at this commit](https://git.cafe/gitcafe/zed/tree/e272acd1bc9642846d2ec71c6a6c65fbf12ccfc0?format=markdown)