# tabular_data_preview: Move settings into popup \(refine UI\) \(\#62812\) · gitcafe/zed

[View on GitCafe](https://git.cafe/gitcafe/zed/commit/e0f913b07d6a4c4ee4ee27119ec4ea3aadcd35e4)

Repository: [gitcafe/zed](https://git.cafe/gitcafe/zed)

Visibility: public

Requested revision: e0f913b07d6a4c4ee4ee27119ec4ea3aadcd35e4

Requested commit: e0f913b07d6a4c4ee4ee27119ec4ea3aadcd35e4

Commit: e0f913b07d6a4c4ee4ee27119ec4ea3aadcd35e4

Tree: f36e9d4ec34e52023d9cbc1a9b64a697ee3601d5

Author: Oleksandr Kholiavko

Committer: GitHub

## Message

```
tabular_data_preview: Move settings into popup (refine UI) (#62812)

# Objective

The settings panel rendered as a persistent bar above the table, always
taking up vertical space even though most of its controls (text
alignment, filter sort order, multiline rows, dev-only toggles) are
rarely touched. @Anthony-Eid suggested reworking it into popover

## Solution

Replaced the always-visible settings panel with a single settings icon
button (next to the row-identifier toggle) that opens a popover menu
with the same controls, grouped under headers:
- Text Alignment, Filter Sort, Display
- and (behind `dev-tools`) Rendering Mode / debug toggles.

Frees up the row of vertical space previously occupied by the panel.
Similarly how it's done in git pannel


## Testing

`cargo check -p tabular_data_preview` and `--features dev-tools` both
build clean; `./script/clippy` clean.
Manually opened the popover and toggled each setting (alignment, filter
sort, multiline rows) to confirm they still apply and persist while the
popover stays open.

## Demo

| Before | After |
| --- | --- |
| <img width="720" height="427" alt="image"
src="https://github.com/user-attachments/assets/0af2e7a5-ab70-4cb8-b106-6cecd5a5752d"
/> | <img width="721" height="384" alt="image"
src="https://github.com/user-attachments/assets/c2938156-938e-4f05-b842-08e599e4bcdd"
/> |

Line numbers vs Row number
<img width="572" height="253" alt="image"
src="https://github.com/user-attachments/assets/1ccc5e8b-ffa3-4a8f-9dcb-07cba340306c"
/>

<img width="571" height="412" alt="image"
src="https://github.com/user-attachments/assets/ecb3c686-cb4c-41e7-918c-b8a5e123a452"
/>


## Self-Review Checklist:

- [x] I've reviewed my own diff for quality, security, and reliability
- [ ] Unsafe blocks (if any) have justifying comments
- [x] The content adheres to Zed's UI standards
([UX/UI](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist)
and
[icon](https://github.com/zed-industries/zed/blob/main/crates/icons/README.md)
guidelines)
- [ ] Tests cover the new/changed behavior
- [x] Performance impact has been considered and is acceptable

---

~~# NOTE TO REVIEWER (release notes related)~~
~~This feature is still under feature flag, but I've head from
@Anthony-Eid few weeks ago that it's already good enough to go public.
Do we make it live and I keep release notes or should I remove release
notes due to some blockers?~~

Disabled feature flag in
https://github.com/zed-industries/zed/pull/62773

---

Release Notes:

- Refine tabular data preview setting UI

---------

Co-authored-by: Anthony Eid <56899983+Anthony-Eid@users.noreply.github.com>
```

## Parents

- [55007f518bc1d49e6b3291c5eaa1aabf649b36fd](https://git.cafe/gitcafe/zed/commit/55007f518bc1d49e6b3291c5eaa1aabf649b36fd?format=markdown)

[Source at this commit](https://git.cafe/gitcafe/zed/tree/e0f913b07d6a4c4ee4ee27119ec4ea3aadcd35e4?format=markdown)
