# acp: Better handling of terminal auth on remote connections \(\#53396\) · gitcafe/zed

[View on GitCafe](https://git.cafe/gitcafe/zed/commit/d81b73f3d6800c945b2effb72287ccf4658284d5)

Repository: [gitcafe/zed](https://git.cafe/gitcafe/zed)

Visibility: public

Requested revision: d81b73f3d6800c945b2effb72287ccf4658284d5

Requested commit: d81b73f3d6800c945b2effb72287ccf4658284d5

Commit: d81b73f3d6800c945b2effb72287ccf4658284d5

Tree: 423e2ee2df4917326f69d3ad96b94d8ff2facf4e

Author: Ben Brandt

Committer: GitHub

## Message

```
acp: Better handling of terminal auth on remote connections (#53396)

We were incorrectly wrapping new terminal auth methods in double ssh
calls.

Only affected ACP beta users, but important for testing and stabilizing
the feature.

We moved the ssh wrapping to be only added in the acp process creation
where it was needed.

Self-Review Checklist:

- [x] I've reviewed my own diff for quality, security, and reliability
- [x] Unsafe blocks (if any) have justifying comments
- [x] The content is consistent with the [UI/UX
checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist)
- [x] Tests cover the new/changed behavior
- [x] Performance impact has been considered and is acceptable

Release Notes:

- N/A

---------

Co-authored-by: Bennet Bo Fenner <bennetbo@gmx.de>
```

## Parents

- [64b93202f84373636494b7ec1d64cb998709b8bb](https://git.cafe/gitcafe/zed/commit/64b93202f84373636494b7ec1d64cb998709b8bb?format=markdown)

[Source at this commit](https://git.cafe/gitcafe/zed/tree/d81b73f3d6800c945b2effb72287ccf4658284d5?format=markdown)