# helix: Fix normal-mode selection expansion during \`vim::Scroll\` commands \(\#47024\) · gitcafe/zed

[View on GitCafe](https://git.cafe/gitcafe/zed/commit/d1f7c249b652e02751be1650b4e5f831b6a7278f)

Repository: [gitcafe/zed](https://git.cafe/gitcafe/zed)

Visibility: public

Requested revision: d1f7c249b652e02751be1650b4e5f831b6a7278f

Requested commit: d1f7c249b652e02751be1650b4e5f831b6a7278f

Commit: d1f7c249b652e02751be1650b4e5f831b6a7278f

Tree: 831d51ff3c46524088d263a09283886aea517dd4

Author: Josh Robson Chase

Committer: GitHub

## Message

```
helix: Fix normal-mode selection expansion during `vim::Scroll` commands (#47024)

Fixes the `vim::ScrollUp/Down` commands when a normal-mode vim or helix
selection exists.

Pretty straightforward: make the `scroll_editor` function aware of the
current vim/helix mode, and only expand the selection if a visual mode
is active.

Closes #47022

Release Notes:

- Fixed bug causing normal-mode vim/helix selections to get expanded
during `vim::Scroll` commands

---------

Co-authored-by: dino <dinojoaocosta@gmail.com>
```

## Parents

- [d9658563b514fc2b9333b4d26bd6217385ae2303](https://git.cafe/gitcafe/zed/commit/d9658563b514fc2b9333b4d26bd6217385ae2303?format=markdown)

[Source at this commit](https://git.cafe/gitcafe/zed/tree/d1f7c249b652e02751be1650b4e5f831b6a7278f?format=markdown)