# title_bar: Fix config merging to respect priority \(\#30980\) · gitcafe/zed

[View on GitCafe](https://git.cafe/gitcafe/zed/commit/ca513f52bf31286154e3a3dd84c5fc3e8f939cab)

Repository: [gitcafe/zed](https://git.cafe/gitcafe/zed)

Visibility: public

Requested revision: ca513f52bf31286154e3a3dd84c5fc3e8f939cab

Requested commit: ca513f52bf31286154e3a3dd84c5fc3e8f939cab

Commit: ca513f52bf31286154e3a3dd84c5fc3e8f939cab

Tree: e6aac618e7160b53598e0d9ac6433f1ff102dd51

Author: Andres Suarez

Committer: GitHub

## Message

```
title_bar: Fix config merging to respect priority (#30980)

This is a follow-up to #30450 so that _global_ `title_bar` configs
shadow _defaults_. The way `SettingsSources::json_merge` works is by
considering non-json-nulls as values to propagate. So it's important
that configs be `Option<T>` so any intent in overriding values is
captured.

This PR follows the same `*Settings<FileContent = *SettingsContent>`
pattern used throughout to keep the `Option`s in the "settings content"
type with the finalized values in the "settings" type.

Release Notes:

- N/A
```

## Parents

- [e9c9a8a269379f77bfadfe9a0aa00797d53e2ced](https://git.cafe/gitcafe/zed/commit/e9c9a8a269379f77bfadfe9a0aa00797d53e2ced?format=markdown)

[Source at this commit](https://git.cafe/gitcafe/zed/tree/ca513f52bf31286154e3a3dd84c5fc3e8f939cab?format=markdown)