# onboarding: Expand power of theme selector \(\#35421\) · gitcafe/zed

[View on GitCafe](https://git.cafe/gitcafe/zed/commit/c946b98ea16bee7099c820879be7188692808d84)

Repository: [gitcafe/zed](https://git.cafe/gitcafe/zed)

Visibility: public

Requested revision: c946b98ea16bee7099c820879be7188692808d84

Requested commit: c946b98ea16bee7099c820879be7188692808d84

Commit: c946b98ea16bee7099c820879be7188692808d84

Tree: 1297f0bb06f7c2e71c8cf3ee685d746615249d97

Author: Ben Kunkle

Committer: GitHub

## Message

````
onboarding: Expand power of theme selector (#35421)

Closes #ISSUE

The behavior of the theme selector is documented above the function,
copied here for reference:
```rust
/// separates theme "mode" ("dark" | "light" | "system") into two separate states
/// - appearance = "dark" | "light"
/// - "system" true/false
/// when system selected:
///  - toggling between light and dark does not change theme.mode, just which variant will be changed
/// when system not selected:
///  - toggling between light and dark does change theme.mode
/// selecting a theme preview will always change theme.["light" | "dark"] to the selected theme,
///
/// this allows for selecting a dark and light theme option regardless of whether the mode is set to system or not
/// it does not support setting theme to a static value
```

Release Notes:

- N/A *or* Added/Fixed/Improved ...
````

## Parents

- [c6947ee4f04b548f90751c31ed477685985a2865](https://git.cafe/gitcafe/zed/commit/c6947ee4f04b548f90751c31ed477685985a2865?format=markdown)

[Source at this commit](https://git.cafe/gitcafe/zed/tree/c946b98ea16bee7099c820879be7188692808d84?format=markdown)