# Take a \`Keymap\` when setting app menus · gitcafe/zed

[View on GitCafe](https://git.cafe/gitcafe/zed/commit/c8ddc95caa4860948fd6f9a7dc7801cc828a6b64)

Repository: [gitcafe/zed](https://git.cafe/gitcafe/zed)

Visibility: public

Requested revision: c8ddc95caa4860948fd6f9a7dc7801cc828a6b64

Requested commit: c8ddc95caa4860948fd6f9a7dc7801cc828a6b64

Commit: c8ddc95caa4860948fd6f9a7dc7801cc828a6b64

Tree: 2140907a6745f985ed134c2448a319293fb61f7b

Author: Antonio Scandurra

Committer: Antonio Scandurra

## Message

```
Take a `Keymap` when setting app menus

For a brief period on this branch, we were taking a `DispatchTree`. Doing so
resulted in more accurate key bindings but it meant that we would have had to
recompute the app menus every time the key context changed.

We decided to err on the side of keeping things simple and work in the same
way they worked back in zed1.

Co-Authored-By: Marshall <marshall@zed.dev>

```

## Parents

- [6549a9a091512f6db53e08efbd3a94d53d524f00](https://git.cafe/gitcafe/zed/commit/6549a9a091512f6db53e08efbd3a94d53d524f00?format=markdown)

[Source at this commit](https://git.cafe/gitcafe/zed/tree/c8ddc95caa4860948fd6f9a7dc7801cc828a6b64?format=markdown)
