# Warn about unknown fields when editing settings json \(\#33678\) · gitcafe/zed

[View on GitCafe](https://git.cafe/gitcafe/zed/commit/c74ecb46545b8dd45d957abab8987ae5295b0cfc)

Repository: [gitcafe/zed](https://git.cafe/gitcafe/zed)

Visibility: public

Requested revision: c74ecb46545b8dd45d957abab8987ae5295b0cfc

Requested commit: c74ecb46545b8dd45d957abab8987ae5295b0cfc

Commit: c74ecb46545b8dd45d957abab8987ae5295b0cfc

Tree: 074684962f548a163860f51fa462c474256337a2

Author: Michael Sloan

Committer: GitHub

## Message

```
Warn about unknown fields when editing settings json (#33678)

Closes #30017

* While generating the settings JSON schema, defaults all schema
definitions to reject unknown fields via `additionalProperties: false`.

* Uses `unevaluatedProperties: false` at the top level to check fields
that remain after the settings field names + release stage override
field names.

* Changes json schema version from `draft07` to `draft_2019_09` to have
support for `unevaluatedProperties`.

Release Notes:

- Added warnings for unknown fields when editing `settings.json`.
```

## Parents

- [7609ca7a8df233654dea961494a6f67a4ce28147](https://git.cafe/gitcafe/zed/commit/7609ca7a8df233654dea961494a6f67a4ce28147?format=markdown)

[Source at this commit](https://git.cafe/gitcafe/zed/tree/c74ecb46545b8dd45d957abab8987ae5295b0cfc?format=markdown)