# Appropriately pick venv activation script \(\#33205\) · gitcafe/zed

[View on GitCafe](https://git.cafe/gitcafe/zed/commit/c29c46d3b604e00234b44b4fc5cc7feaf9f92d9f)

Repository: [gitcafe/zed](https://git.cafe/gitcafe/zed)

Visibility: public

Requested revision: c29c46d3b604e00234b44b4fc5cc7feaf9f92d9f

Requested commit: c29c46d3b604e00234b44b4fc5cc7feaf9f92d9f

Commit: c29c46d3b604e00234b44b4fc5cc7feaf9f92d9f

Tree: 3964a219e4df2e1a2f3e5005b758a8b0cfe54dcb

Author: Ragul R

Committer: GitHub

## Message

```
Appropriately pick venv activation script (#33205)

when `terminal.detect_venv.activate_script` setting is default, pick the
appropriate activate script as per the `terminal.shell` settings
specified by the user. Previously when the activate_script setting is
default, zed always try to use the `activate` script, which only works
when the user shell is `bash or zsh`. But what if the user is using
`fish` shell in zed?

Release Notes:

- python: value of `activate_script` setting is now automatically
inferred based on the kind of shell the user is running with.

---------

Co-authored-by: Piotr Osiewicz <24362066+osiewicz@users.noreply.github.com>
```

## Parents

- [312369c84f826643ff0e5ebb7dc66ff4fe367dce](https://git.cafe/gitcafe/zed/commit/312369c84f826643ff0e5ebb7dc66ff4fe367dce?format=markdown)

[Source at this commit](https://git.cafe/gitcafe/zed/tree/c29c46d3b604e00234b44b4fc5cc7feaf9f92d9f?format=markdown)