# migrator: Add migration for settings changed prior to migrator-introduction \(\#27375\) · gitcafe/zed

[View on GitCafe](https://git.cafe/gitcafe/zed/commit/be83c5e1c56f6cad862415b7b003d8b32b7fbfd9)

Repository: [gitcafe/zed](https://git.cafe/gitcafe/zed)

Visibility: public

Requested revision: be83c5e1c56f6cad862415b7b003d8b32b7fbfd9

Requested commit: be83c5e1c56f6cad862415b7b003d8b32b7fbfd9

Commit: be83c5e1c56f6cad862415b7b003d8b32b7fbfd9

Tree: dfb7e58b661e09d097a1ea63f9e5924b148db7a5

Author: Finn Evers

Committer: GitHub

## Message

```
migrator: Add migration for settings changed prior to migrator-introduction (#27375)

This PR updates two existing settings to use the settings migrator
instead of a manually implemented visitor. Both of these settings were
changed prior to the introduction of automatic migrations and the
visitor ensured that the settings were kept backwards compatible. See
https://github.com/zed-industries/zed/pull/22200 and
https://github.com/zed-industries/zed/pull/22364 respectively.

WIth this change, existing user configurations are updated accordingly
and the corresponding settings can derive `Deserialize` again.

I also added tests for the replacement of settings values, as there was
no test for this behaviour. Additionally, I added a seperate test for
the existing migration of `always_show_close_button`, since that
migration updated both the key and value.

Release Notes:

- N/A
```

## Parents

- [46d67a33c79bf125831810630f31a152f7f86a96](https://git.cafe/gitcafe/zed/commit/46d67a33c79bf125831810630f31a152f7f86a96?format=markdown)

[Source at this commit](https://git.cafe/gitcafe/zed/tree/be83c5e1c56f6cad862415b7b003d8b32b7fbfd9?format=markdown)