# helix: Fix insert line above/below with selection \(\#46492\) · gitcafe/zed

[View on GitCafe](https://git.cafe/gitcafe/zed/commit/be6cd3e5f70438f36b5a483f30cd84977e78073e)

Repository: [gitcafe/zed](https://git.cafe/gitcafe/zed)

Visibility: public

Requested revision: be6cd3e5f70438f36b5a483f30cd84977e78073e

Requested commit: be6cd3e5f70438f36b5a483f30cd84977e78073e

Commit: be6cd3e5f70438f36b5a483f30cd84977e78073e

Tree: 8358fb960340ac1058f6d735f9e24585e6536d24

Author: Josh Robson Chase

Committer: GitHub

## Message

```
helix: Fix insert line above/below with selection (#46492)

Fix Helix `o`/`O` behavior when a selection is active.

This updates `InsertLineAbove` and `InsertLineBelow` to use the
selection bounds correctly for Helix selections, including line
selections whose end is represented at column 0 of the following line.

It also adds Helix select-mode keybindings for `o` and `O`, and adds
tests covering both line selections and selections created via `v`.

Closes #43210

Release Notes:

- helix: Fixed insert line above/below behavior when a full line is
selected

---------

Co-authored-by: dino <dinojoaocosta@gmail.com>
```

## Parents

- [260280d3e74a916ff3939bcb31122e885a1cd566](https://git.cafe/gitcafe/zed/commit/260280d3e74a916ff3939bcb31122e885a1cd566?format=markdown)

[Source at this commit](https://git.cafe/gitcafe/zed/tree/be6cd3e5f70438f36b5a483f30cd84977e78073e?format=markdown)