Fix Checking Indicator (Diagnostics) (#3940)

Fixes some issues with the Checking icon I added last week.

- Use default text color for "Checking..." text and icon
- Always show text and icon while checks are running

I think we should probably remove the `✅` while checks are running as it
incorrectly indicates nothing is wrong when we don't yet know that – but
that is a larger change so I'll keep this fix contained.

Release Notes:

- Fixes "Checking" diagnostics icon only showing until the first
diagnostics item is found.
bba3449f4bNate Butler committed on 1/8/2024, 5:01:52 PM· committed by GitHubparents3541dd81ede003
2 files changedLine totals unavailable