Self-Review Checklist: - [x] I've reviewed my own diff for quality, security, and reliability - [x] Unsafe blocks (if any) have justifying comments - [x] The content is consistent with the [UI/UX checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist) - [x] Tests cover the new/changed behavior - [x] Performance impact has been considered and is acceptable Closes #54160 Summary: In Helix mode, rename could fail when the cursor was visually positioned on the last character of a symbol. The editor renders some Vim/Helix selections with the visible cursor offset from the selection head, but rename was still using the raw selection head as the LSP prepare-rename position. This updates rename to use the visible cursor position for point lookup when cursor offset rendering is active. It also adds regression coverage for Helix rename and Vim visual rename. Verification: - `cargo check -p editor` - `cargo fmt --check --package editor --package vim` - `git diff --check -- crates\editor\src\editor.rs crates\vim\src\test.rs` - `test::test_rename` - `test::test_helix_rename_uses_visible_cursor_position` - `test::test_visual_rename_uses_visible_cursor_position` Release Notes: - Fixed Helix mode rename when the cursor is visually on the last character of a symbol. --------- Co-authored-by: dino <dinojoaocosta@gmail.com>
3 files changedLine totals unavailable