# file_finder: Fix panic when file name contains new line \(\#26791\) · gitcafe/zed

[View on GitCafe](https://git.cafe/gitcafe/zed/commit/ae017c3f96ffb88c4b918bb761757798bf7dd84c)

Repository: [gitcafe/zed](https://git.cafe/gitcafe/zed)

Visibility: public

Requested revision: ae017c3f96ffb88c4b918bb761757798bf7dd84c

Requested commit: ae017c3f96ffb88c4b918bb761757798bf7dd84c

Commit: ae017c3f96ffb88c4b918bb761757798bf7dd84c

Tree: 3fd49ee4a53d3da6e4380af41bfd25b30d09f482

Author: Smit Barmase

Committer: GitHub

## Message

````
file_finder: Fix panic when file name contains new line (#26791)

Closes #26777

This PR fixes a panic when a file name contains a newline and a
multi-byte character like 👋 (4 bytes in UTF-8). The issue was in the
regex not considering newlines in file names, causing it to match only
the latter part of the file name.

For example:

```
 left: PathWithPosition { path: "ab", row: None, column: None } // matched
 right: PathWithPosition { path: "ab\ncd", row: None, column: None } // actual file name
```


This resulted in incorrect index calculation later in the code, which
went unnoticed until now due to the lack of tests with file names
containing newlines.

We discovered this issue when a panic occurred due to incorrect index
calculation while trying to get the index of a multi-byte character.
After the newline fix, the index calculation is always correct, even in
the case of multi-byte characters.

Release Notes:

- Fixed an issue where file names with newlines and multi-byte
characters could cause a crash in certain cases.
````

## Parents

- [f587e95a7e0de31f818c7f5b45f50ebb1b6ec914](https://git.cafe/gitcafe/zed/commit/f587e95a7e0de31f818c7f5b45f50ebb1b6ec914?format=markdown)

[Source at this commit](https://git.cafe/gitcafe/zed/tree/ae017c3f96ffb88c4b918bb761757798bf7dd84c?format=markdown)