# zeta: Add zlib to license detection \+ ignore symbol differences \(\#37238\) · gitcafe/zed

[View on GitCafe](https://git.cafe/gitcafe/zed/commit/ad746f25f268ef0ad3aeddc41bc05287c1d0d006)

Repository: [gitcafe/zed](https://git.cafe/gitcafe/zed)

Visibility: public

Requested revision: ad746f25f268ef0ad3aeddc41bc05287c1d0d006

Requested commit: ad746f25f268ef0ad3aeddc41bc05287c1d0d006

Commit: ad746f25f268ef0ad3aeddc41bc05287c1d0d006

Tree: cb328deb01bd097e7e9ec227295d6189254d7fdd

Author: Michael Sloan

Committer: GitHub

## Message

```
zeta: Add zlib to license detection + ignore symbol differences (#37238)

See discussion on #36564. Makes the license regexes a less fragile by
not matching on symbols, while also excluding cases where a long file
ends with a valid license. Also adds Zlib license, a commented out test
to check all license-like files discovered in the homedir, and more
testcases.

Not too happy with the efficiency here, on my quite good computer it
takes ~120ms to compile the regex and allocates ~8mb for it. This is
just not a great use of regexes, I think something using eager substring
matching would be much more efficient - hoping to followup with that.

Release Notes:

- Edit Prediction: Added Zlib license to open-source licenses eligible
for data collection.
```

## Parents

- [de576bd1b81cef5a8bc41506806ea44c92d9d9a5](https://git.cafe/gitcafe/zed/commit/de576bd1b81cef5a8bc41506806ea44c92d9d9a5?format=markdown)

[Source at this commit](https://git.cafe/gitcafe/zed/tree/ad746f25f268ef0ad3aeddc41bc05287c1d0d006?format=markdown)