# Remove \`into SelectionEffects\` from \.change_selections \(\#33554\) · gitcafe/zed

[View on GitCafe](https://git.cafe/gitcafe/zed/commit/a675ca7a1e61da03071755187cf69d1c34fdd152)

Repository: [gitcafe/zed](https://git.cafe/gitcafe/zed)

Visibility: public

Requested revision: a675ca7a1e61da03071755187cf69d1c34fdd152

Requested commit: a675ca7a1e61da03071755187cf69d1c34fdd152

Commit: a675ca7a1e61da03071755187cf69d1c34fdd152

Tree: a237f0fd276f978813e255d66ead8ce98e6f3805

Author: Conrad Irwin

Committer: GitHub

## Message

```
Remove `into SelectionEffects` from .change_selections (#33554)

In #32656 I generalized the argument to change selections to allow
controling both the scroll and the nav history (and the completion
trigger).

To avoid conflicting with ongoing debugger cherry-picks I left the
argument as an `impl Into<>`, but I think it's clearer to make callers
specify what they want here.

I converted a lot of `None` arguments to `SelectionEffects::no_scroll()`
to be exactly compatible; but I think many people used none as an "i
don't care" value in which case Default::default() might be more
appropraite

Closes #ISSUE

Release Notes:

- N/A
```

## Parents

- [6e762d9c05a8f5688b112c1e2dbfbf19c2ae4293](https://git.cafe/gitcafe/zed/commit/6e762d9c05a8f5688b112c1e2dbfbf19c2ae4293?format=markdown)

[Source at this commit](https://git.cafe/gitcafe/zed/tree/a675ca7a1e61da03071755187cf69d1c34fdd152?format=markdown)