# Fix opening GoToLine from Command · gitcafe/zed

[View on GitCafe](https://git.cafe/gitcafe/zed/commit/a2f0accb74813c2c1dbcaeb7a4f409fe5589f291)

Repository: [gitcafe/zed](https://git.cafe/gitcafe/zed)

Visibility: public

Requested revision: a2f0accb74813c2c1dbcaeb7a4f409fe5589f291

Requested commit: a2f0accb74813c2c1dbcaeb7a4f409fe5589f291

Commit: a2f0accb74813c2c1dbcaeb7a4f409fe5589f291

Tree: d39a9c4c98f24336e0736c95b403f09eff28dce2

Author: Conrad Irwin

Committer: Conrad Irwin

## Message

```
Fix opening GoToLine from Command

This was broken because of the async hop introduced by should_dismiss.

Change that API to instead be syncronous, and require that implementors
(of which there is only one) to call dismiss again if they want to.

```

## Parents

- [c9aa4a0e00c49dceb7558e3c49b408ba3e49280c](https://git.cafe/gitcafe/zed/commit/c9aa4a0e00c49dceb7558e3c49b408ba3e49280c?format=markdown)

[Source at this commit](https://git.cafe/gitcafe/zed/tree/a2f0accb74813c2c1dbcaeb7a4f409fe5589f291?format=markdown)