# Remove cx from ThemeSettings \(\#38836\) · gitcafe/zed

[View on GitCafe](https://git.cafe/gitcafe/zed/commit/a2a7bd139a3f94202d2a050a2bc7e50dc139000b)

Repository: [gitcafe/zed](https://git.cafe/gitcafe/zed)

Visibility: public

Requested revision: a2a7bd139a3f94202d2a050a2bc7e50dc139000b

Requested commit: a2a7bd139a3f94202d2a050a2bc7e50dc139000b

Commit: a2a7bd139a3f94202d2a050a2bc7e50dc139000b

Tree: 9f8a58f90e23d548ffb3f2fa292c31197963e42c

Author: Conrad Irwin

Committer: GitHub

## Message

```
Remove cx from ThemeSettings (#38836)

Before this change the active theme and icon theme were retrofitted onto
the ThemeSettings.

Now they're in their own new global (GlobalTheme::theme(cx) and
GlobalTheme::icon_theme(cx))

This lets us remove cx from the settings traits, and tidy up a few other
things along the way.

Release Notes:

- N/A
```

## Parents

- [4de13e06ec44a3fa0b6d38db92fecba100f0bda2](https://git.cafe/gitcafe/zed/commit/4de13e06ec44a3fa0b6d38db92fecba100f0bda2?format=markdown)

[Source at this commit](https://git.cafe/gitcafe/zed/tree/a2a7bd139a3f94202d2a050a2bc7e50dc139000b?format=markdown)