# git: Fix logging FromUtf8Error when diffing \(\#28276\) · gitcafe/zed

[View on GitCafe](https://git.cafe/gitcafe/zed/commit/9e504a1ed9fdc51c090e4fac9bfa3403707bd1c0)

Repository: [gitcafe/zed](https://git.cafe/gitcafe/zed)

Visibility: public

Requested revision: 9e504a1ed9fdc51c090e4fac9bfa3403707bd1c0

Requested commit: 9e504a1ed9fdc51c090e4fac9bfa3403707bd1c0

Commit: 9e504a1ed9fdc51c090e4fac9bfa3403707bd1c0

Tree: fd91c7a2f78e3e61d0193feb9820186668935068

Author: Peter Tripp

Committer: GitHub

## Message

````
git: Fix logging FromUtf8Error when diffing (#28276)

If you attempt to load a git diff which includes a non utf-8 file,
previously
(1) the entire contents of the file was logged as ordinals and
(2) a second spurious error was logged

```
2025-04-07T16:21:28.392845-04:00 [ERROR] FromUtf8Error { bytes: [0, 1, 0, 0, 0, 19, 1, 0, 0, 4, 0, 48, 68, 83, 73, 71, 0, 0, 0, 1, 0, 2, 241, 204, 0, 0, 0, 8, 71, 68, 69, 70, 164, 172, 164, ...

[2025-04-07T17:12:16-04:00 ERROR git::repository] Error loading index text: invalid utf-8 sequence of 1 bytes from index 35
```

Having 1MB binary file in a commit would generate ~3MB-5MB of log
output.

Discovered while investigating
https://github.com/zed-industries/zed/issues/28241

Release Notes:

- git: Fixed an issue where non-UTF8 files in a git diff would generate
log spam.
````

## Parents

- [ca4cc4764bcc2f29f5a6c305e80369a9f0fb80c2](https://git.cafe/gitcafe/zed/commit/ca4cc4764bcc2f29f5a6c305e80369a9f0fb80c2?format=markdown)

[Source at this commit](https://git.cafe/gitcafe/zed/tree/9e504a1ed9fdc51c090e4fac9bfa3403707bd1c0?format=markdown)