# Fix unregistration logic for pull diagnostics \(\#44294\) · gitcafe/zed

[View on GitCafe](https://git.cafe/gitcafe/zed/commit/9e33243015d39ac54060c074d275aca3de77f2d9)

Repository: [gitcafe/zed](https://git.cafe/gitcafe/zed)

Visibility: public

Requested revision: 9e33243015d39ac54060c074d275aca3de77f2d9

Requested commit: 9e33243015d39ac54060c074d275aca3de77f2d9

Commit: 9e33243015d39ac54060c074d275aca3de77f2d9

Tree: 13bc5ff11c36120727e60efdb9879ca0a1280da7

Author: John Tur

Committer: GitHub

## Message

```
Fix unregistration logic for pull diagnostics (#44294)

Even if `workspace_diagnostics_refresh_tasks` is empty, registrations
which didn't advertise support for workspace diagnostics may still
exist.

Release Notes:

- N/A
```

## Parents

- [a0848daab44c05f69e6adfcfa0682b84a0bd06d7](https://git.cafe/gitcafe/zed/commit/a0848daab44c05f69e6adfcfa0682b84a0bd06d7?format=markdown)

[Source at this commit](https://git.cafe/gitcafe/zed/tree/9e33243015d39ac54060c074d275aca3de77f2d9?format=markdown)