# Apply \`show_completions_on_input: false\` to word & snippet completions \(\#44021\) · gitcafe/zed

[View on GitCafe](https://git.cafe/gitcafe/zed/commit/96a917091a80c0430b6b7d816d747e3bbf14f533)

Repository: [gitcafe/zed](https://git.cafe/gitcafe/zed)

Visibility: public

Requested revision: 96a917091a80c0430b6b7d816d747e3bbf14f533

Requested commit: 96a917091a80c0430b6b7d816d747e3bbf14f533

Commit: 96a917091a80c0430b6b7d816d747e3bbf14f533

Tree: f4d6f4c9a17340923a9c883ac8949c3bbf0d9fa1

Author: Andrew Farkas

Committer: GitHub

## Message

```
Apply `show_completions_on_input: false` to word & snippet completions (#44021)

Closes #43408

Previously, we checked the setting inside `is_completion_trigger()`,
which only affects LSP completions. This was ok because user-defined
snippets were tacked onto LSP completions. Then #42122 and #42398 made
snippet completions their own thing, similar to word completions,
surfacing #43408. This PR moves the settings check into
`open_or_update_completions_menu()` so it applies to all completions.

Release Notes:

- Fixed setting `show_completions_on_input: false` so that it affects
word and user-defined snippet completions as well as LSP completions
```

## Parents

- [a2ddb0f1cb96f3711da4cf85d51282103820831c](https://git.cafe/gitcafe/zed/commit/a2ddb0f1cb96f3711da4cf85d51282103820831c?format=markdown)

[Source at this commit](https://git.cafe/gitcafe/zed/tree/96a917091a80c0430b6b7d816d747e3bbf14f533?format=markdown)