client: Remove unused `subscription_period` from `UserStore` (#35454)
This PR removes the `subscription_period` field from the `UserStore`, as
its usage has been replaced by the `CloudUserStore`.
Release Notes:
- N/A
8be3f48f37Marshall Bowers committed on 8/1/2025, 3:10:16 AM· committed by GitHubparent76a8293