# Delete pulled diagnostics when the source registration is unregistered \(\#46105\) · gitcafe/zed

[View on GitCafe](https://git.cafe/gitcafe/zed/commit/8ba030ab1e3ac7aed03e22f85e82842bb712e056)

Repository: [gitcafe/zed](https://git.cafe/gitcafe/zed)

Visibility: public

Requested revision: 8ba030ab1e3ac7aed03e22f85e82842bb712e056

Requested commit: 8ba030ab1e3ac7aed03e22f85e82842bb712e056

Commit: 8ba030ab1e3ac7aed03e22f85e82842bb712e056

Tree: a6bf0e81ca32c931bfd0e0038bd5914e167e3f8a

Author: John Tur

Committer: GitHub

## Message

```
Delete pulled diagnostics when the source registration is unregistered (#46105)

Additionally, fix a race condition where we'd still insert diagnostics
from a document or workspace pull even if the registration had been
unregistered in the time since the request was issued.

And, as a bonus: when a new pull diagnostics registration is added,
issue document pulls immediately.

This should fix regressions with basedpyright caused by
https://github.com/zed-industries/zed/pull/43703.

Release Notes:

- N/A
```

## Parents

- [6625997e0f6c6b2bc8584a4ee672a21f279ff1a0](https://git.cafe/gitcafe/zed/commit/6625997e0f6c6b2bc8584a4ee672a21f279ff1a0?format=markdown)

[Source at this commit](https://git.cafe/gitcafe/zed/tree/8ba030ab1e3ac7aed03e22f85e82842bb712e056?format=markdown)