# Fix regression preventing new predictions from being previewed in subtle mode \(\#51887\) · gitcafe/zed

[View on GitCafe](https://git.cafe/gitcafe/zed/commit/8b822f9e101c4abb99e4b141301112ae78a3b91f)

Repository: [gitcafe/zed](https://git.cafe/gitcafe/zed)

Visibility: public

Requested revision: 8b822f9e101c4abb99e4b141301112ae78a3b91f

Requested commit: 8b822f9e101c4abb99e4b141301112ae78a3b91f

Commit: 8b822f9e101c4abb99e4b141301112ae78a3b91f

Tree: 41320f85519fe74bdab903888b9a2c6f75eafd62

Author: Ben Kunkle

Committer: GitHub

## Message

```
Fix regression preventing new predictions from being previewed in subtle mode (#51887)

## Context

<!-- What does this PR do, and why? How is it expected to impact users?
     Not just what changed, but what motivated it and why this approach.

Link to Linear issue (e.g., ENG-123) or GitHub issue (e.g., Closes #456)
     if one exists — helps with traceability. -->
Fixes some issues with https://github.com/zed-industries/zed/pull/51842
Namely that the tests were scattered and not well organized (this PR
also makes them more thorough), and a regression where holding the
modifiers for the accept prediction keybind would not cause an incoming
prediction to be immediately previewed.

## How to Review

<!-- Help reviewers focus their attention:
- For small PRs: note what to focus on (e.g., "error handling in
foo.rs")
- For large PRs (>400 LOC): provide a guided tour — numbered list of
files/commits to read in order. (The `large-pr` label is applied
automatically.)
     - See the review process guidelines for comment conventions -->

## Self-Review Checklist

<!-- Check before requesting review: -->
- [x] I've reviewed my own diff for quality, security, and reliability
- [x] Unsafe blocks (if any) have justifying comments
- [x] The content is consistent with the [UI/UX
checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist)
- [x] Tests cover the new/changed behavior
- [x] Performance impact has been considered and is acceptable

Release Notes:

- (Preview v0.229.x only) Fixed a regression where holding the modifiers
for the accept edit prediction keybind would not immediately preview
predictions as they arrived
```

## Parents

- [fb1a98cfeffd1413661416ac35f84ea5d3eca7c4](https://git.cafe/gitcafe/zed/commit/fb1a98cfeffd1413661416ac35f84ea5d3eca7c4?format=markdown)

[Source at this commit](https://git.cafe/gitcafe/zed/tree/8b822f9e101c4abb99e4b141301112ae78a3b91f?format=markdown)