# Fix \#24081 \- lsp diagnostic code type conversion \(\#24347\) · gitcafe/zed

[View on GitCafe](https://git.cafe/gitcafe/zed/commit/8b3d315e406eb121b7b0030a7f39a4c9777a2e08)

Repository: [gitcafe/zed](https://git.cafe/gitcafe/zed)

Visibility: public

Requested revision: 8b3d315e406eb121b7b0030a7f39a4c9777a2e08

Requested commit: 8b3d315e406eb121b7b0030a7f39a4c9777a2e08

Commit: 8b3d315e406eb121b7b0030a7f39a4c9777a2e08

Tree: e19d4d16693671904e8994f82e18bb22cdaeffca

Author: Ben Kunkle

Committer: GitHub

## Message

```
Fix #24081 - lsp diagnostic code type conversion (#24347)

- **store `buffer::Diagnostic`as NumberOrString instead of assuming
String**
- **update zed-industries/lsp-types rev**

Closes #24081

Release Notes:

- Fixed an issue where language server diagnostic codes would be converted to strings leading to errors with some language servers
```

## Parents

- [10b6bc2508a7ef6041a035ef2cc507e73e0ccd47](https://git.cafe/gitcafe/zed/commit/10b6bc2508a7ef6041a035ef2cc507e73e0ccd47?format=markdown)

[Source at this commit](https://git.cafe/gitcafe/zed/tree/8b3d315e406eb121b7b0030a7f39a4c9777a2e08?format=markdown)