# debugger: Fix gdb adapter and logger \(\#28280\) · gitcafe/zed

[View on GitCafe](https://git.cafe/gitcafe/zed/commit/862d0c07ca434315555fd086bc1327d3d0ac502d)

Repository: [gitcafe/zed](https://git.cafe/gitcafe/zed)

Visibility: public

Requested revision: 862d0c07ca434315555fd086bc1327d3d0ac502d

Requested commit: 862d0c07ca434315555fd086bc1327d3d0ac502d

Commit: 862d0c07ca434315555fd086bc1327d3d0ac502d

Tree: 472bd6bb6b818dd6292f69370bf60d980c9ae4ae

Author: Anthony Eid

Committer: GitHub

## Message

````
debugger: Fix gdb adapter and logger (#28280)

There were two bugs that caused the gdb adapter not to work properly,
one on our end and one their end.

The bug on our end was sending `stopOnEntry: null` in our launch request
when stop on entry had no value. I fixed that bug across all dap
adapters

The other bug had to do with python's "great" type system and how we
serialized our unit structs to json; mainly,
`ConfigurationDoneArguments` and `ThreadsArguments`. Gdb seems to follow
a pattern for handling requests where they pass `**args` to a function,
this errors out when the equivalent json is `"arguments": null`.

```py
@capability("supportsConfigurationDoneRequest")
@request("configurationDone", on_dap_thread=True)
def config_done(**args): ### BUG!!
    ...
```

Release Notes:

- N/A
````

## Parents

- [56ed5dcc89dfe80349bd265b649a1f252065425f](https://git.cafe/gitcafe/zed/commit/56ed5dcc89dfe80349bd265b649a1f252065425f?format=markdown)

[Source at this commit](https://git.cafe/gitcafe/zed/tree/862d0c07ca434315555fd086bc1327d3d0ac502d?format=markdown)