# settings_ui: Fix switching icon themes from "dynamic" to "static" always selecting the dark theme \(\#54647\) · gitcafe/zed

[View on GitCafe](https://git.cafe/gitcafe/zed/commit/7dfe0fb3a4f4fb1c0a0bc580f0faaa8671b77bad)

Repository: [gitcafe/zed](https://git.cafe/gitcafe/zed)

Visibility: public

Requested revision: 7dfe0fb3a4f4fb1c0a0bc580f0faaa8671b77bad

Requested commit: 7dfe0fb3a4f4fb1c0a0bc580f0faaa8671b77bad

Commit: 7dfe0fb3a4f4fb1c0a0bc580f0faaa8671b77bad

Tree: 61b924b1cb5dd92ca5c85f32391d2bfec743bd4e

Author: galuis116

Committer: GitHub

## Message

```
settings_ui: Fix switching icon themes from "dynamic" to "static" always selecting the dark theme (#54647)

Self-Review Checklist:

- [x] I've reviewed my own diff for quality, security, and reliability
- [x] Unsafe blocks (if any) have justifying comments
- [x] The content is consistent with the [UI/UX
checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist)
- [x] Tests cover the new/changed behavior
- [x] Performance impact has been considered and is acceptable

Closes #54646 

Release Notes:

- Fixed settings behavior where switching Icon Theme from "Dynamic"
(System mode) to "Static" now selects the icon theme that matches the
current OS appearance (light or dark), instead of always defaulting to
the dark variant.

---------

Co-authored-by: Marshall Bowers <git@maxdeviant.com>
```

## Parents

- [b178949033c8062c817bcf6a02fd0d5de87fd9dd](https://git.cafe/gitcafe/zed/commit/b178949033c8062c817bcf6a02fd0d5de87fd9dd?format=markdown)

[Source at this commit](https://git.cafe/gitcafe/zed/tree/7dfe0fb3a4f4fb1c0a0bc580f0faaa8671b77bad?format=markdown)