# fs: Pre-filter the event kind before acquiring global lock and cloning callback handlers \(\#55683\) · gitcafe/zed

[View on GitCafe](https://git.cafe/gitcafe/zed/commit/7ba7b4b981b5dec2e0d3beeb7076ea3256a4a99b)

Repository: [gitcafe/zed](https://git.cafe/gitcafe/zed)

Visibility: public

Requested revision: 7ba7b4b981b5dec2e0d3beeb7076ea3256a4a99b

Requested commit: 7ba7b4b981b5dec2e0d3beeb7076ea3256a4a99b

Commit: 7ba7b4b981b5dec2e0d3beeb7076ea3256a4a99b

Tree: e171d3f8b2e34bd1b7a9fae901d55a725996ebff

Author: Josh Robson Chase

Committer: GitHub

## Message

```
fs: Pre-filter the event kind before acquiring global lock and cloning callback handlers (#55683)

In #54481, the `handle_event` function was altered to check for an
`Access` event after the callbacks were acquired via a global state
lock. The lock/Vec-collect has enough overhead (or maybe there's enough
lock contention?) that the handler isn't performant enough to keep up
with the volume of inotify events, and its queue fills up, resulting in
[a rescan event getting
emitted](https://github.com/notify-rs/notify/blob/79007aefb41d9f853d00656eb768600e3ea41ee0/notify/src/inotify.rs#L304-L306),
which presumably results in *more* access events for the file as it's
rescanned, which further serve to fill up the inotify queue.

Moving the check for an `Access` event and returning before doing
anything remotely expensive seems to resolve the issues I've been having
lately. Not sure if it addresses the original issue in #53480 though.

Longer-term, it might be prudent to do the event handler's heavy-lifting
in a separate thread with its own event queue, and let the handler
passed to the `notify` crate be just a dumb `tx` sender.

Self-Review Checklist:

- [x] I've reviewed my own diff for quality, security, and reliability
- [x] Unsafe blocks (if any) have justifying comments
- [x] The content is consistent with the [UI/UX
checklist](https://github.com/zed-industries/zed/blob/main/CONTRIBUTING.md#uiux-checklist)
- [ ] Tests cover the new/changed behavior
- [x] Performance impact has been considered and is acceptable

Related to #53480
Fixes #55829 

Release Notes:

- Fixed inotify event queue overflows on linux
```

## Parents

- [3767d69d6470f028411cfb75d25adbe5548ff9ca](https://git.cafe/gitcafe/zed/commit/3767d69d6470f028411cfb75d25adbe5548ff9ca?format=markdown)

[Source at this commit](https://git.cafe/gitcafe/zed/tree/7ba7b4b981b5dec2e0d3beeb7076ea3256a4a99b?format=markdown)