# onboarding: Fix theme picker always updating theme based on system appearance \(\#47245\) · gitcafe/zed

[View on GitCafe](https://git.cafe/gitcafe/zed/commit/6ab03c6c1f17d44c5857dbbd9694d338826a0f17)

Repository: [gitcafe/zed](https://git.cafe/gitcafe/zed)

Visibility: public

Requested revision: 6ab03c6c1f17d44c5857dbbd9694d338826a0f17

Requested commit: 6ab03c6c1f17d44c5857dbbd9694d338826a0f17

Commit: 6ab03c6c1f17d44c5857dbbd9694d338826a0f17

Tree: 49045f8020640c9903e08627d0d1b41b7b9887f0

Author: Michael Hackner

Committer: GitHub

## Message

```
onboarding: Fix theme picker always updating theme based on system appearance (#47245)

The settings store separate themes for Light and Dark modes. When the
user clicks a theme, the code uses the system appearance to decide which
to update, rather than the mode the user selected in the UI. This causes
the wrong theme to be saved when the system appearance differs from the
selected mode.

<img width="746" height="324" alt="image"
src="https://github.com/user-attachments/assets/b8f8d937-172d-4da8-b572-4f3db7f1de9a"
/>

Release Notes:

- Fixed onboarding page sometimes rendering the wrong theme

---------

Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
Co-authored-by: MrSubidubi <finn@zed.dev>
```

## Parents

- [7bd3075d532cdfd28a414c18d1dfb45c4a2ebcc3](https://git.cafe/gitcafe/zed/commit/7bd3075d532cdfd28a414c18d1dfb45c4a2ebcc3?format=markdown)

[Source at this commit](https://git.cafe/gitcafe/zed/tree/6ab03c6c1f17d44c5857dbbd9694d338826a0f17?format=markdown)